Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <843a059dec8607ce694adb82ddcbda2dfc01f833.camel@xry111.site>
Subject: Re: [PATCH] loongarch: Remove spurious "source
 drivers/firmware/Kconfig"
From:   Xi Ruoyao <xry111@xry111.site>
To:     Huacai Chen <chenhuacai@kernel.org>
Cc:     loongarch@lists.linux.dev, WANG Xuerui <kernel@xen0n.name>,
        linux-kernel@vger.kernel.org
Date:   Tue, 08 Aug 2023 15:56:26 +0800
In-Reply-To: <CAAhV-H5=FJqx3FcR71LXuMB51PBAKXMO-t7DqJj_dr2BD-JtZw@mail.gmail.com>
References: <20230808034836.418485-1-xry111@xry111.site>
         <CAAhV-H5=FJqx3FcR71LXuMB51PBAKXMO-t7DqJj_dr2BD-JtZw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-08-08 at 15:16 +0800, Huacai Chen wrote:
> Hi, Ruoyao,
>=20
> I think the title should be "LoongArch: Remove redundant "source
> drivers/firmware/Kconfig""?

Yes, it looks better.  I've sent v2 with the change.

Thanks!

>=20
> Huacai
>=20
> On Tue, Aug 8, 2023 at 11:49=E2=80=AFAM Xi Ruoyao <xry111@xry111.site> wr=
ote:
> >=20
> > In drivers/Kconfig, drivers/firmware/Kconfig is sourced for all
> > ports so
> > there is no need to source it in the port-specific Kconfig file.=C2=A0
> > And
> > sourcing it here also caused the "Firmware Drivers" menu appeared
> > two
> > times: once in the "Device Drivers" menu, another time in the
> > toplevel
> > menu.=C2=A0 This was really puzzling.
> >=20
> > Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> > ---
> > =C2=A0arch/loongarch/Kconfig | 2 --
> > =C2=A01 file changed, 2 deletions(-)
> >=20
> > diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> > index e71d5bf2cee0..465759f6b0ed 100644
> > --- a/arch/loongarch/Kconfig
> > +++ b/arch/loongarch/Kconfig
> > @@ -662,5 +662,3 @@ source "kernel/power/Kconfig"
> > =C2=A0source "drivers/acpi/Kconfig"
> >=20
> > =C2=A0endmenu
> > -
> > -source "drivers/firmware/Kconfig"
> > --
> > 2.41.0
> >=20

--=20
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University