Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 8 Aug 2023 16:55:50 +0100 (BST)
From:   "Maciej W. Rozycki" <macro@orcam.me.uk>
To:     Zhangjin Wu <falcon@tinylab.org>
cc:     tanyuan@tinylab.org, linux-kernel@vger.kernel.org,
        linux-mips@vger.kernel.org, linux@weissschuh.net,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>, w@1wt.eu
Subject: Re: [RFC 0/1] mips: malta: Select PCI_QUIRKS if POWER_RESET_PIIX4_POWEROFF
 is enabled
In-Reply-To: <20230805191407.45290-1-falcon@tinylab.org>
Message-ID: <alpine.DEB.2.21.2308081633120.38537@angie.orcam.me.uk>
References: <686dbb3128ad4e413b22685cd466a68e1adf670b.1690968173.git.tanyuan@tinylab.org> <20230805191407.45290-1-falcon@tinylab.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sun, 6 Aug 2023, Zhangjin Wu wrote:

> To simplify the enablement of the poweroff support, selecting the required
> options for CONFIG_POWER_RESET=y may make many people happy especially when
> they are using a customized config (maybe tinyconfig based) for a target qemu
> board. Without normal poweroff support from the kernel side, qemu will simply
> hang there after a 'poweroff' command, which is a very bad experience for the
> automatical tests. Currently, based on tinyconfig, it is very hard to find the
> exact poweroff options, some architectures simply enable poweroff support by
> default, the others' poweroff options are hidden deeply, which make things very
> hard. 

 The settings are a bit buried indeed and I was hit by that myself at one 
point when upgrading the kernel using old .config, but honestly I think we 
want to let people strip the kernel from options they don't want or need, 
so I think it will best be sorted by presetting the useful options in the 
respective defconfigs and then maybe guard the more critical ones with `if 
EXPERT'.

  Maciej