Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <61efe587-9a7a-063c-a388-eed9f51958d4@amd.com>
Date:   Tue, 8 Aug 2023 11:04:09 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v6 3/4] drm: Expand max DRM device number to full
 MINORBITS
To:     =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        Simon Ser <contact@emersion.fr>
Cc:     =?UTF-8?Q?Micha=c5=82_Winiarski?= <michal.winiarski@intel.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        intel-gfx@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Matthew Wilcox <willy@infradead.org>,
        Oded Gabbay <ogabbay@kernel.org>,
        James Zhu <James.Zhu@amd.com>,
        Pekka Paalanen <pekka.paalanen@collabora.com>,
        Emil Velikov <emil.l.velikov@gmail.com>
References: <20230724211428.3831636-1-michal.winiarski@intel.com>
 <20230724211428.3831636-4-michal.winiarski@intel.com>
 <83s0YPWEdYE6C2a8pa6UAa3EaWZ2zG-q7IL9M-y6W1ucF9V54VnZtigKj3BGKUA2FZpIrs0VVxmpHO2RAhs_FdOnss9vNLQNSHySY8uH7YA=@emersion.fr>
 <69801f61-37b0-3e46-cbef-31ff80ae9a34@amd.com>
 <TAdBP5BOy3cy7VnUb4t7ZkDOMK6wI_gPCjXanItN3TOsA1TbSk_6yrlcPTqvk3AZjamo96yHlEhjpfNUPFF6tA_9K8iRoie3h_z5Jf6zNtc=@emersion.fr>
 <ad26d275-4373-429f-ecaa-3e35978f1fb0@amd.com>
Content-Language: en-US
From:   James Zhu <jamesz@amd.com>
Organization: AMD RTG
In-Reply-To: <ad26d275-4373-429f-ecaa-3e35978f1fb0@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGJOd2RxVnlEYlMwUWNITTNGSGs3WldCOHFPODE0L2pmZHVPVkxRN3E4bUhO?=
 =?utf-8?B?WWFGOWdqYW83RzduMk50aVUzWEpQNjFmK1luUGlKLzl3Mnc5a1Zzb3pFckpp?=
 =?utf-8?B?TVNXUUZpZ3VjcFRuRUVYTkhPd0VHNVRLOE00bnJBcFZyWk9lby9YQjd1eE9S?=
 =?utf-8?B?NmlmNFpHZVBRQVU2K3U4TXJ2ajY3QmdJcEl4WnN5NVVBdXBnMjNvYUJvL1Q3?=
 =?utf-8?B?UllHdzZPcndBQ2dwR1ZyMHNhMllDTm43YjhrMkVMemVYMTBuNmM5MmJEbEpz?=
 =?utf-8?B?TnVGVmZ6N1N4SFBiRGx2cHBvSGdjVkJPazVTNlhBOVdQd0JtUlJNM1k4YlVt?=
 =?utf-8?B?OWt0dEVnK00vbm0zbFV2cC9FT3VXK3FkMGM3TlJldisyL2VRbTFrZ2RNc2JP?=
 =?utf-8?B?N2FTYjU5ZXRRRmtSRUV6UTJxNVNjazZCT0dPRzdCMUtaTHJLVllGNVVsbTF4?=
 =?utf-8?B?ZnRoQ1JiNWNuZjhnc3VoNlE5TDh1U1M1WktPV3p1NUhvNkEyMlB5cFZBNTRy?=
 =?utf-8?B?ZXlWdmtLUHZzSEorK3RveHpHbFMzUk9mckJ5bVRNalIxRFR5ancrYXc4dmZB?=
 =?utf-8?B?Y3pzdTlMVEdwVG5VbXdKbGxwZ09DL2VISmN0TGNOUk95T0RIb3h4T2Vpb3dk?=
 =?utf-8?B?azhOazE1b2phei8rT2dQa2s1UVArcnF4NGhyV0tsQlpoQjM5RER6Qzd4OTVQ?=
 =?utf-8?B?a2RiM1JUSnJKalRLYjlwaEFqWGFFZlRNVUgrUVFNOVpCUEFVR0pIMDNHYlhN?=
 =?utf-8?B?MU1ObjJqUmo0SmdYUk1tNm1FeDV2akdzdUhxWkcrbFRCR1pGZ2o0RUp3Z0o2?=
 =?utf-8?B?SXhLaXFSNE1TMHloaW5MeHcwaE9icGt5ajJKUzhKT2NITDU4WGV3TVdPR3kz?=
 =?utf-8?B?UWEvZHFiSVVDMmgrU3RTZFRWdDhvd0RpRmpHK3J4RjEwY1hCQm5kOG53QXpx?=
 =?utf-8?B?aHE3Mmx5UHZ5RkFjcFVhZHBOcVFTOUdIRVNGQnM5ZFlvQ0Robk1XK0p4QktW?=
 =?utf-8?B?TlJvUWZ5Q2tnR0pSNXIrdmU1b2Z6cVdhUmkzd3krcHNCY1lReXE3SjZRUlh0?=
 =?utf-8?B?WTJaMEwzUzk3YU1DZWNwaVFLSDJaRDlaMnpGVFNYVFY2T21FM2VGZkM3SjE2?=
 =?utf-8?B?clZNcDNhNDJJbHlSRUF4YnlvR2pwSzNFY21QdGZBZXJub1pROUcvUWk3VnlQ?=
 =?utf-8?B?dUlHN21QV0ZIZ1Q1UytUd0NqMElkS1FjS3dTS1oyS0R2Rys1dUM4eDV0VzJr?=
 =?utf-8?B?MWIybWlUOEUwZXprdHNNcXovaVVaRUJ4cXdsUUlueFJVRy9TTkJqbGdJaCt4?=
 =?utf-8?B?MmVoTVlPYzkzTytsTHpORkpsRUc3Q2RVK0prY0o3cGZGWFBOT0Nwb250YWNX?=
 =?utf-8?B?Sk8vWk9KcWZ1bjFITEw1VmUyNXZEZHRnck15RXd1UU5wWGduSkIxckg5TjZq?=
 =?utf-8?B?N1RNK3pCNlEyc1oxYk5FMHkvVlphWmQrMlR1Rk52QUZ3UEg4a1UvaXYxQk5C?=
 =?utf-8?B?Slg3NHVPdU5xdkJNQkFhRXluU1V0TFk2b3JIK0hpd2NlWXNqVE5sd2pKNC9V?=
 =?utf-8?B?ZTR6b25UaW15VHVKWjFDVVNCVks3QWZ6ZVcvM213L3lRTkM3ZTZLMXFEUkhw?=
 =?utf-8?B?NW5sc05HSmdXeHNUT1Q2QnZlb2JweUNNSXhlNW9URlVsMk1DRy9QcHZ1TmZ5?=
 =?utf-8?B?bGZ2M2VvRHdjck5pa3FQODJOQkhEUTZLTVZZaFd5RzN6MnZxOTZTdGU2cTNM?=
 =?utf-8?B?ZXJQUFNxa08vRzhZVEo4dGVvQWhnZGFOZC9zSVMwVHZhWnJiSk53NTUzM3ph?=
 =?utf-8?B?d201Y3cwdXFNUy81U0xkUUZqZXNtaE5ZZno1dWlHOTdUV0pQR0ZJUnMxQmJn?=
 =?utf-8?B?NHVGZHI5ckFrdzJ3YnZKMVc4ZE9oK0tVRlJuQjliWm9SdmdMdnM1N1ViN2w0?=
 =?utf-8?B?RkFmanRTRUhFRS9PeUJ5ZWRqbjNVZExDblBwQ2M1M2daSHNyYjlLa3hKM3NP?=
 =?utf-8?B?ckU5UlA3WVpxZ3V3YU1PSkhvRXZmRFo2b3VjekZVdTJZMDBzM0E2cHZpd01H?=
 =?utf-8?B?Mks1SXpnbnlabVZiVlFxNy96R2pNaWRpSzNPeWdYVG9kSTYvaVJpMDdHNjFQ?=
 =?utf-8?Q?8NJIf4H6qOUxNKMQameaxRwLC?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3619547-2849-4331-2205-08db9820ba68
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR12MB6760.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 15:04:13.8237
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uSKVrETxuiRGobUnpxC1yFiqi6TvdFBqKTg5ehot0BNQFHWSuxeXsF/25ImIVu33
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5881
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I would like if these kernel patches are accepted by everyone, If yes, 
when they can be upstream.

I have a MR for libdrm to support drm nodes type up to 2^MINORBITS  
nodes which can work with these patches,

https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/305

Thanks!

James

On 2023-08-08 09:55, Christian König wrote:
> Am 28.07.23 um 16:22 schrieb Simon Ser:
>> On Thursday, July 27th, 2023 at 14:01, Christian König 
>> <christian.koenig@amd.com> wrote:
>>
>>>> We do need patches to stop trying to infer the node type from the 
>>>> minor
>>>> in libdrm, though. Emil has suggested using sysfs, which we already do
>>>> in a few places in libdrm.
>>> That sounds like a really good idea to me as well.
>>>
>>> But what do we do with DRM_MAX_MINOR? Change it or keep it and say apps
>>> should use drmGetDevices2() like Emil suggested?
>> DRM_MAX_MINOR has been bumped to 64 now.
>>
>> With the new minor allocation scheme, DRM_MAX_MINOR is meaningless
>> because there is no "max minor per type" concept anymore: the minor no
>> longer contains the type.
>>
>> So I'd suggest leaving it as-is (so that old apps still continue to
>> work on systems with < 64 devices like they do today) and mark it as
>> deprecated.
>
> Sounds like a plan to me.
>
> Regards,
> Christian.