Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f989cd56-a066-409a-8d82-40d0bc6ff89b@amd.com>
Date:   Tue, 8 Aug 2023 10:07:19 -0400
User-Agent: Mozilla Thunderbird
Cc:     yazen.ghannam@amd.com, linux-kernel@vger.kernel.org,
        avadhut.naik@amd.com
Subject: Re: [PATCH 1/2] platform/x86/amd: Introduce AMD Address Translation
 Library
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>,
        "Limonciello, Mario" <mario.limonciello@amd.com>,
        linux-edac@vger.kernel.org, hdegoede@redhat.com,
        markgross@kernel.org, platform-driver-x86@vger.kernel.org,
        "Luck, Tony" <tony.luck@intel.com>
References: <20230802185504.606855-1-yazen.ghannam@amd.com>
 <20230802185504.606855-2-yazen.ghannam@amd.com>
 <58934edf-4fad-48e0-bc5d-62712b11e607@amd.com>
 <894b3737-1a0a-4139-9c73-686a95481795@amd.com>
 <B3BE6B56-FBAB-4878-A45D-E95AFAC86AB1@alien8.de>
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <B3BE6B56-FBAB-4878-A45D-E95AFAC86AB1@alien8.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkFpY3hibkVvdDZNZXR0OVFybUY1TjRxU2FSOG9TTmV1dGJPL2p3RkE5Q2dl?=
 =?utf-8?B?b3haL1NXS3dLTXhNQW1qOVJLaU1aanY4Rmg4TEVCZmdPbnhCSndZZDFkV0xx?=
 =?utf-8?B?WkdDYngrLzRZWFNqcE41Y2o3WVVoWW9FYmIzTUtYTFNUWW8xRHRwZGh3Mk1h?=
 =?utf-8?B?cEFiMTNmNGZuN0tyZ29KYXJGU0lET3FqcklBd3lDYXc4ZFpyaE5GODlHTy9Z?=
 =?utf-8?B?aXcvUEtMem1MSVVYU0NEZnJmZVpGbFZpaHVvYnFkbXViN1p1ZlE2VzRTVURs?=
 =?utf-8?B?WGVsZGtFY3NjdGl1SjY5RGptVUplTGtLUGVGbUhlVGl3VFZGYUdUY3loeWMy?=
 =?utf-8?B?NXFVL2UzWEQ4L05kaUtvQjBxMjREYzZKaXh6TE0xZzVRYW5lWWFpeDc0NEk4?=
 =?utf-8?B?MFVUb0xLYnNXWnI5N2w3SFRyQW9aaFh5N3RBemVXdVdvQk1hZWxMMW9ybEM3?=
 =?utf-8?B?TTczRk54V0t1VEJ1alBRS2RFdXpsVHc3NG0yYTRxT1lTYkVNWGZlNkI3MmVr?=
 =?utf-8?B?S282MWZibXAwUHludWRQeDZFYjBnbzdqUDhhbjZ5UkQ0T2MxeHFGM1B5ZlY2?=
 =?utf-8?B?RHNJQ1IwY0ZtK0VQUFJnS05TVFo5ZTE3VlZGRG8vQWhEU3BNbE8yK3V4V3Vi?=
 =?utf-8?B?VXJWb1FrMm5DZ1ZkZlJGdE9KR2tkWTFsYWw1VkJ1cG5UZm13RFh2eGxoU3hR?=
 =?utf-8?B?SlIvUW1KM2VKNExrUWJxYUZDZ0V0c3BwU2FHQnhhRFZ6dXdrai9kdHAvZUN0?=
 =?utf-8?B?K3ZYNEszU3Fscm1TeitnQzkxdVFleHlKby9zbEdCcVBzbCtHMUlyaFNFbkJo?=
 =?utf-8?B?a0RMay9MTzZzM2J5Nzg2cWpiOWRqMzFTS3lnYzFOSy8rT1NobTJ5eEpvUUZt?=
 =?utf-8?B?WFFQY214d0hIakprdHhFaitiWWF6Q3BwU1YxRHZiblNBT244RWJYaVJpUUVB?=
 =?utf-8?B?eWtqajBBZCtWNXN5RVlxdFpwdU0xdGh2SlhlNXNaSHVtMFRXaENmRWFuWHlH?=
 =?utf-8?B?bXUxa20wUW43M1p0ZkRYcElGWHVWNkkwRXE0L3l5Q3I0K2tGMTlMV2xTN0ta?=
 =?utf-8?B?NVdhSm42aW12aEpXVGdzK2RqRFlJL21rVmpxN2J2ajBZOXFyWVZGcE1DSFln?=
 =?utf-8?B?TjhzL3FMMVE0cnhZRzZJMlBnYzl1SERTTWIvdWtwc3NpZjZMWVQ1TElPTjlw?=
 =?utf-8?B?a0dvNTE3NmJCNHEvQk1obU1iV2ZaL2M0SytaUVdIdzNicjd6bkdUYUZPb28x?=
 =?utf-8?B?RHZjaytmeU5FbTJHZG5uVUtHY05mblJkTk82MS9id3hFQ2pkbjNwYnVjK0Jw?=
 =?utf-8?B?Zmt4dkE0SS9MN1h4N2NwNnFrVU9uZFh4c3RtOHVjUGpUK3M0ckdsay9EcDhY?=
 =?utf-8?B?RU1LZXh4SEFVZWU3UW9uNjN2OWxqVzk4WUZ2Z3dTcEk5VFFUQzNGWmQyeEZh?=
 =?utf-8?B?WnEyd1Mrb3c2RVEwcXpZYk9ib2F5YXZtQnRSQVVEc1VmZW9yVlM3ZG9hd1Qz?=
 =?utf-8?B?OG1rZCtJTnZPQlJCOFdjdTFETVljQ2sxM3daaTVxY3pXeU1BT2c3aUpRb3VX?=
 =?utf-8?B?TzJWcHlqT0hTRmwxSkJrbjhCZUZETzNtM1p3eHh3ang1dUdlMUliRjBoS21H?=
 =?utf-8?B?OGxpVno3bEh2T1dSdG5QZ0Q1OWRIR1hxS2hRSmtrYlV3anRNb3d1RHlycG5H?=
 =?utf-8?B?ajBhYXVQZ0VteVRidzBSOHVZbHo3emtjQnRXOC9CV25NZ3FUT1BxM01yUSs1?=
 =?utf-8?B?RHpwRDJqeExtbDdiZ3dRZGJsaTFnWXdUbWhXU3lWRWJ1T09VY2RraVVmYXNN?=
 =?utf-8?B?NlRiZmNHcDBrcEZPWmk4cW1EQ2N2emE4UmRyQmFZSWNNa1Q1cHVQalhwWjVu?=
 =?utf-8?B?akF0bjRVZTlIRWREeUtpcWhWR0pMQVZ5bC9ZVGY1UmNLc3RwVGFIeHAydXlQ?=
 =?utf-8?B?T1I3eUFhWVhXUHBZOWNZOC92dlRzSDFVbnlFUElmcXlJazR3WlkvT1ZMd2o2?=
 =?utf-8?B?MVdudEszQ2NRbTBUUk5NVFY0bStqNGVxWnlmaGVBUWNnZktHa3VDSHVFU2ZP?=
 =?utf-8?B?STZoZitQV1g2VmJ2WkZlS1pjbGljdW9HOTZ3SGFaejdhc1BBNFBXM0NpNWFx?=
 =?utf-8?Q?r1djnDDzI8/2buNPxkjVjN4Y7?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b172fe25-48ce-40f6-c09c-08db9818e234
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 14:08:04.7834
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VutBfZ1wifkoClFqz4euCiF7tWH4K+LtNtiXwxM08s9YXXwAi7Lw7Wyak4T1dOY04tbmTBNfsbVeFy51n57wyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4122
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/8/2023 8:10 AM, Borislav Petkov wrote:
> On August 8, 2023 5:17:33 AM GMT+02:00, "Limonciello, Mario" <mario.limonciello@amd.com> wrote:
>> Given it's 'library code' to be used by a bunch of things and also want to be able to use a module, what about putting it in lib/?  There's plenty of library code there as tristate.
> 
> It is x86-specific so not in there. Also, it might be used by multiple things so you want it as a separate "translation" service which is called by other modules.
> 

There are modules in arch/x86, so I guess that's not an issue (not sure 
what I was thinking).

This code is AMD-specific, and there's vendor-specific code in arch/x86 
already. So it may be fine to have this in arch/x86/ras.

But just because there's existing vendor-specific code in arch/x86 
doesn't necessarily mean we should keep adding to it. So is this okay?

Thanks,
Yazen