Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <91e640d6-6d1b-48bc-87b9-755869af87dc@amd.com>
Date:   Tue, 8 Aug 2023 10:43:09 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V1 1/6] ACPI: CPPC: Add get the highest performance cppc
 control
Content-Language: en-US
To:     Meng Li <li.meng@amd.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Huang Rui <ray.huang@amd.com>
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        x86@kernel.org, linux-acpi@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>,
        linux-kselftest@vger.kernel.org,
        Nathan Fontenot <nathan.fontenot@amd.com>,
        Deepak Sharma <deepak.sharma@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Shimmer Huang <shimmer.huang@amd.com>,
        Perry Yuan <Perry.Yuan@amd.com>,
        Xiaojian Du <Xiaojian.Du@amd.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Borislav Petkov <bp@alien8.de>
References: <20230808081001.2215240-1-li.meng@amd.com>
 <20230808081001.2215240-2-li.meng@amd.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20230808081001.2215240-2-li.meng@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qk1wMmhaSS85UmE3WDFnY1R1VzlYdnlOQUxzS21IN1VrWE1BY2FlRHdwSG9Z?=
 =?utf-8?B?N25EQjNtNTB5akVJS0VQZ2FoR0FPTzhuWkRBSUwxTVhROExVbmhocjZReWRH?=
 =?utf-8?B?dDd6YkZJWjJROXVDL1dYUnVqdnk3a1dpbkpST2NQVDlGb0loWmpkdzJscUdr?=
 =?utf-8?B?dStBSUdadGJZVkV0ZnBHdmRrV3VCcTh4V1grTmFiZGk5OUFvQURlY3MyT0Rw?=
 =?utf-8?B?aW5oajZiVHNFQ1MxdmhsZG1hUW9tWFVFVlJLS3RhNmRaS3hEVzI1TXdHZ0lj?=
 =?utf-8?B?VFVFbGdqV0dOQ2tFdjBNcnFwNWhmMjZMSTNFK3pvUHZwRTRRbnpCaEZCNjUz?=
 =?utf-8?B?SkUvaVJBMkdLSVBNaG5oVVM5S2lvdFl4U1liYmsxbXBBd2pNUGsrY3ZmTWhl?=
 =?utf-8?B?Y0ZDOFpsS3lqakV2N1BWSGxTZGFiWVF1UXA0RklrbXcvWUFKUWNiaEJFT2tF?=
 =?utf-8?B?aWdOcXFMNm5oTDJaM3k2bDNLN0JFSUFHMVZiSE54RHNjQTNZUUxielFudGNO?=
 =?utf-8?B?b3FEUXhIRGdETmlMMUNTR2FYakZPV1htNGZ0RUVVa2xhbzJEbEtsSGN1ZDBY?=
 =?utf-8?B?NnptNGpKVFlmTVIrZ0srTy9FYXBuS1A3dEE1blIzT3d2MFA1SnJpRDNCWERC?=
 =?utf-8?B?N1BKY2wrSzR6dzJKUWNORnVQZFZXalEvY1ZXejgxM1FJY2M5QzVLQlBLVU5u?=
 =?utf-8?B?M0hQNFZpNmVlb0Q3Qkg5YThtYmNROVVPUzFaUDF6cXE0eDNMTUhuTFdZTm83?=
 =?utf-8?B?bUpCakRrWSs5cXFXVmIwM0swMzh3RTlmK0NyVnBhTG9XWGg5L0ZZTHVNSXpY?=
 =?utf-8?B?SXNKcGlHeXlWenh2YTFsOGVsUGpRSkFzbGY5bUlYQmhONElkb1U5TnhjYndS?=
 =?utf-8?B?UCtuLzZwNXJTeWpDRXBCcnp3SXExRkVXQjhVOUtFMVZIdG9RNzEwTW52NUcz?=
 =?utf-8?B?SWZqZnA0YVRKQ3FEL3AxYmRKendZZ1VNbWdvKzhPTDlWbjhTbDZqM1hzWXBW?=
 =?utf-8?B?L0xpUStjdnJVSjEwcm5lQVJKYjNCZTdKZ3QxRWtaVDZtSjBVK2E2b2NNN3FU?=
 =?utf-8?B?bS9hR1VseWtjRWVZTXRtcnpDVVpnVDRxS2U4b3BhSnl5RzN1Mm0vM3h4Z0Fs?=
 =?utf-8?B?UkVvT1BvUVp4d3dJdXVJaGlndERUUEVlWG9HY1hTQjZmY2xEV1MwaXVGV3pB?=
 =?utf-8?B?TjY1UFJiVzk0N3l5OXFGK25qSkxpZ0xWUTFnZ3AxWHFHTlpXU0pIREluQThu?=
 =?utf-8?B?M1FUb0ZFOUNkS2JuQUYvUk5rbmtER2tydmRSc3hyN0g4TThSeGVsajFsd3Jr?=
 =?utf-8?B?bXhnWU5LU0JKZGhHck53Sk52L0hPNWpTT2JUdk9jOU1QYWx4bExsalBMNUsw?=
 =?utf-8?B?ZDhEMTRJbktZRHhVeEZtMmVlUE8wRFJUOFdrdXRlWDh1VzY2MjVvKzhGSDIx?=
 =?utf-8?B?NFBYbG44L21EOHBJZWFVOWR0RkRoY09zMXRqOWowckRmbHpSaEpiTTJOZ2JS?=
 =?utf-8?B?UTBDYnpIZ2sxN2RRZTNka1FjaldsRXZtN1JMRGxDOWFCQWhSSDVNL1RqdVZ0?=
 =?utf-8?B?Yi85VDFpZGY3NkxxbGZTVDZvcFpsMkpMU2dUeXR0YWs1MW56aTlranVkNjU3?=
 =?utf-8?B?dUVMbzczZmprOEF1S29LTkVKM21CWGxaZUJaR1NEL25WRFdXSnhtQmU3SG5a?=
 =?utf-8?B?ZmlVRkU1Qm5ST1ZNcXBVTk1lYWJSZS9lSjVTd1JIOGRlZTdNUGVCZ21HTlA3?=
 =?utf-8?B?N1ViaHIzWWF6Q00rSWNZQnpOb09iZ1NHWTY1QXVLM0VyNEJPdndFT2dxUGtL?=
 =?utf-8?B?cjk4akNkbUVTRVdlbzJzOWxya2lsU2ZVL2I2WXNSZlFlYW1WNlRSYXdqb1Vk?=
 =?utf-8?B?RURZZHlsVjBnMVZJbTRmUmgxOWh2UXZSQzJ3bFVRdjB4djZzT3RBM0gwbjZ1?=
 =?utf-8?B?OFFQZTh0dmx5V0IzV0FiMVlNKzMxMnJiei81NUhMTllYNW4wTTFLb1pYQmds?=
 =?utf-8?B?YWwrTFo0MkpIQ1U1V1FzRVorSVExNk1JSWNzRVZKQm1sNFd0OGtUVXprYXVJ?=
 =?utf-8?B?WWZNYmVOeGVlYjdmcU5QaEdUYjVVOVRRRlo3RlN5MWJsaHpkRFNqbUUrbURJ?=
 =?utf-8?Q?VRIjcAFAWmx/DutnX13/Yf4A2?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ff48565-3392-42e1-fb6e-08db98262c36
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 15:43:12.3416
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C1DlWGqsoUjVsDba3WeXvVJFexL0uMON5gxi/zHv54IT9XDvIdlzRV8vNOZ3R0uZn+lgl2tHj35WR0083rNS/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB7088
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/8/2023 03:09, Meng Li wrote:
> Add support for getting the highest performance to the
> generic CPPC driver. This enables downstream drivers
> such as amd-pstate to discover and use these values.
> 

I suggest adding this to commit message:

Link: 
https://uefi.org/specs/ACPI/6.5/08_Processor_Configuration_and_Control.html?highlight=cppc#cpc-continuous-performance-control

> Signed-off-by: Meng Li <li.meng@amd.com>

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   drivers/acpi/cppc_acpi.c | 13 +++++++++++++
>   include/acpi/cppc_acpi.h |  5 +++++
>   2 files changed, 18 insertions(+)
> 
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index 7ff269a78c20..ad388a0e8484 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -1154,6 +1154,19 @@ int cppc_get_nominal_perf(int cpunum, u64 *nominal_perf)
>   	return cppc_get_perf(cpunum, NOMINAL_PERF, nominal_perf);
>   }
>   
> +/**
> + * cppc_get_highest_perf - Get the highest performance register value.
> + * @cpunum: CPU from which to get highest performance.
> + * @highest_perf: Return address.
> + *
> + * Return: 0 for success, -EIO otherwise.
> + */
> +int cppc_get_highest_perf(int cpunum, u64 *highest_perf)
> +{
> +	return cppc_get_perf(cpunum, HIGHEST_PERF, highest_perf);
> +}
> +EXPORT_SYMBOL_GPL(cppc_get_highest_perf);
> +
>   /**
>    * cppc_get_epp_perf - Get the epp register value.
>    * @cpunum: CPU from which to get epp preference value.
> diff --git a/include/acpi/cppc_acpi.h b/include/acpi/cppc_acpi.h
> index 6126c977ece0..c0b69ffe7bdb 100644
> --- a/include/acpi/cppc_acpi.h
> +++ b/include/acpi/cppc_acpi.h
> @@ -139,6 +139,7 @@ struct cppc_cpudata {
>   #ifdef CONFIG_ACPI_CPPC_LIB
>   extern int cppc_get_desired_perf(int cpunum, u64 *desired_perf);
>   extern int cppc_get_nominal_perf(int cpunum, u64 *nominal_perf);
> +extern int cppc_get_highest_perf(int cpunum, u64 *highest_perf);
>   extern int cppc_get_perf_ctrs(int cpu, struct cppc_perf_fb_ctrs *perf_fb_ctrs);
>   extern int cppc_set_perf(int cpu, struct cppc_perf_ctrls *perf_ctrls);
>   extern int cppc_set_enable(int cpu, bool enable);
> @@ -165,6 +166,10 @@ static inline int cppc_get_nominal_perf(int cpunum, u64 *nominal_perf)
>   {
>   	return -ENOTSUPP;
>   }
> +static inline int cppc_get_highest_perf(int cpunum, u64 *highest_perf)
> +{
> +	return -ENOTSUPP;
> +}
>   static inline int cppc_get_perf_ctrs(int cpu, struct cppc_perf_fb_ctrs *perf_fb_ctrs)
>   {
>   	return -ENOTSUPP;