Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 8 Aug 2023 13:46:08 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Cc:     Serge Semin <fancer.lancer@gmail.com>, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: dw: Set default value if reg-io-width isn't
 specified
Message-ID: <1505ec01-186d-451a-9164-d42796954c01@sirena.org.uk>
References: <20230807001621.196776-1-hayashi.kunihiko@socionext.com>
 <az7wvv5f42mnuuwkqzpfmwg4ngvl4jvpcfmns7d6lhzogc4qdi@ox64l6i7b44r>
 <213763b3-5a8b-3a88-54f1-024325f7fe80@socionext.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="TJalYs/MizfFRmvC"
Content-Disposition: inline
In-Reply-To: <213763b3-5a8b-3a88-54f1-024325f7fe80@socionext.com>
Precedence: bulk


--TJalYs/MizfFRmvC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Aug 08, 2023 at 09:00:18AM +0900, Kunihiko Hayashi wrote:
> On 2023/08/08 7:57, Serge Semin wrote:
> > On Mon, Aug 07, 2023 at 09:16:21AM +0900, Kunihiko Hayashi wrote:

> > > According to the dt-bindings, the default value of reg-io-width is 4.
> > > However, the value becomes zero when reg-io-width isn't specified.

> > This semantic is implied by the dw_read_io_reg() and dw_write_io_reg()
> > methods. It doesn't seem like that much necessary duplicating it in the
> > property parse procedure, if not to say - redundant.

> I see. Currently since the variable reg_io_width has no other references
> other than dw_{read, write}_io_reg(), it means the default value is taken
> if this is zero.

> So, I think we should be careful when actually using the value of
> this variable.

It does feel like a sensible robustness improvement, even if it's not
fixing a specific issue now it might save us from future issues.

--TJalYs/MizfFRmvC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTSORAACgkQJNaLcl1U
h9AB8wf/ddcf2la7li0vRgQn1O0T32/K+4cecju7caiwiFf/8icP1QlQpElqHyQw
nEIpn+pzs8QWVREykUqKt6WWLI+KhtIDrUuSSs3NoIFkQ7yk9Gacfr4Y/SLP0JCf
uwMaSRVdapPl2ou5KcfyI0MK/Cc1BlMjwNPFb4POpub+0qdJRp8ImCeKfy7wzKSr
Tx0d7tv/IxzjD3ScGT6ydIm6BTFLJg2g6WXgeJMZQLmX3Kqv1J0Th376pxMNpqST
EoXlOy5DlAHs3X21KnUeThzEYd8NhCdhi1WYK/02LPG21geKPnYYgsOf3KBbh5nG
Zx0Ufq9+SoGZEJRJ99eR97Uy09USVQ==
=2aGO
-----END PGP SIGNATURE-----

--TJalYs/MizfFRmvC--