Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp4647087rwb; Tue, 8 Aug 2023 11:26:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFITpNxCJdIpXUayd3vGRLxiqXxpvfiigNIaXsHV9MTkmb94kOSevTS6ktYsfJYQxqs88Vc X-Received: by 2002:a17:906:7392:b0:993:f497:adbe with SMTP id f18-20020a170906739200b00993f497adbemr360243ejl.19.1691519216215; Tue, 08 Aug 2023 11:26:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691519216; cv=none; d=google.com; s=arc-20160816; b=xa51RMCtqGhdbVeCkdHUzZ5WYAsjwb1dxJuxZwdmTt0zbwJuU5bJa6InqZkPKZCaH8 JRENSAa53rvHlGBJNrjBH0IOLbXwMeTrapyno1/sVwkbiBClp4wc4oIkxmTVWGNhkaO/ Fli9uiHOsYAtqzziJ+4XuKrDnxmWnxeG2gnvQ6QFibvpc4McuTdxqgMjGfc8wHF5nvtK kSs+f3XGoIP7WODrFvRfr0m1y6Gp33h56YnlaI3hqGlScxze7aLr3Z0iXUfqbICENV6o cpeblxXCq6qUeXK59xBSBTr7D8ivBiQ5tzm6HuQVguRPZUtasSLmfzJ7R5a+ymJfJX+J /6zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=myK7mXCh0wWPVk2WKDJhq9932yiA/YXPt7S9v5nTug0=; fh=jFV/cP3AXUUX4k/QD5zn8bRJMI4FFq6CCXakx8v5J3g=; b=pxVGLDBdTbUH7jHmmgwBfYTA53jTHoqHJbTXi8jntWQpREtImiOllSumYVRzkq/n/x tvBhTw2x7Wb35vGFwgah1ify5QDGQpWrfXwk5tVBQOOdniDgxoEl+XjU1kLal53wlhD9 Php3yh0paRZpFQhond/T7siDy994xQnVRbUyiTtIaYG2JuWrwTGthK7sFzouQ9zZw1Tl MQvnjJITK/TSi8pImlwq0jaftp6+TSwJ7NmWwGIUyarHJvtc32WtGDhCNF2eArtkg/iN T1j2nP7yHNhT//AaALRTTy1Zh1mq1Td7fqyv2lcu1jkHNAFt+hJ6NW9AviFrRzjlbLMX RcPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gu16-20020a170906f29000b00988c76f9d4bsi7827170ejb.347.2023.08.08.11.26.31; Tue, 08 Aug 2023 11:26:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235548AbjHHSQO (ORCPT + 99 others); Tue, 8 Aug 2023 14:16:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235446AbjHHSPx (ORCPT ); Tue, 8 Aug 2023 14:15:53 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6A851F41F; Tue, 8 Aug 2023 10:22:25 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 25D9C68AA6; Tue, 8 Aug 2023 19:22:20 +0200 (CEST) Date: Tue, 8 Aug 2023 19:22:19 +0200 From: Christoph Hellwig To: Christian Brauner Cc: Christoph Hellwig , clm@fb.com, dsterba@suse.com, josef@toxicpanda.com, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, syzbot Subject: Re: [syzbot] [btrfs?] KASAN: slab-use-after-free Read in btrfs_open_devices Message-ID: <20230808172219.GA17612@lst.de> References: <0000000000007921d606025b6ad6@google.com> <000000000000094846060260e710@google.com> <20230808-zentimeter-kappen-5da1e70c5535@brauner> <20230808160141.GA15875@lst.de> <20230808-wohnsiedlung-exerzierplatz-02b1257b97a2@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230808-wohnsiedlung-exerzierplatz-02b1257b97a2@brauner> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 08, 2023 at 06:35:04PM +0200, Christian Brauner wrote: > On Tue, Aug 08, 2023 at 06:01:41PM +0200, Christoph Hellwig wrote: > > Yes, probably. The lifetimes looked fishy to me to start with, but > > this might have made things worse. > > It looks like we should be able to just drop that patch. > Ok, are you fixing this or should I drop this patch? I plan to fix it, but you can drop it for. If we want to go on top drop get_super like the preview series I sent you we'll eventually need something like this patch back, though.