Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i426947f3:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-624-g7714e4406d-fm-20230801.001-g7714e440
Mime-Version: 1.0
Message-Id: <b84c2fba-1bbe-4842-a861-525784d8a361@app.fastmail.com>
In-Reply-To: <0248d597-b72a-5b7c-63a4-6d72384f9854@kernel.org>
References: <20230808013157.80913-1-mark.tomlinson@alliedtelesis.co.nz>
 <0248d597-b72a-5b7c-63a4-6d72384f9854@kernel.org>
Date:   Tue, 08 Aug 2023 17:54:41 +1000
From:   "Mathew McBride" <matt@traverse.com.au>
To:     "Krzysztof Kozlowski" <krzk@kernel.org>,
        "Mark Tomlinson" <mark.tomlinson@alliedtelesis.co.nz>,
        "Jean Delvare" <jdelvare@suse.com>,
        "Guenter Roeck" <linux@roeck-us.net>
Cc:     linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 1/2] hwmon: Add driver for EMC181x temperature sensors
Content-Type: text/plain
Precedence: bulk

Hi Krzysztof,

On Tue, Aug 8, 2023, at 5:38 PM, Krzysztof Kozlowski wrote:
> On 08/08/2023 03:31, Mark Tomlinson wrote:
> > This patch adds a HWMON driver for the EMC1812, EMC1813, EMC1814,
> > EMC1815 and EMC1833 temperature sensor chips from microchip. Does not
> > currently support the alert outputs.
> > 
> > Signed-off-by: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
> > Co-developed-by: Mathew McBride <matt@traverse.com.au>
> > Signed-off-by: Mathew McBride <matt@traverse.com.au>
> 
> The order of these tags is clearly not correct. It says Mathew is
> sending, but you are not Mathew?

Just to clarify, Mark has developed this version based off something I wrote a while ago:

https://gitlab.com/traversetech/ls1088firmware/traverse-sensors/-/blob/master/emc181x/emc181x.c?ref_type=heads

Hence my copyright is listed in the header.

I advised him to list the authors in that order following the example in the kernel's "submitting patches" guide [2] which provides an example of such a situation:

https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

If I interpreted the guidelines incorrectly, happy to be corrected.

Best Regards,
Matt