Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] mm: remove unneeded __meminit annotation
To:     Matthew Wilcox <willy@infradead.org>
CC:     <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
References: <20230808015831.608454-1-linmiaohe@huawei.com>
 <ZNGo5Y4vQ3rQn0vf@casper.infradead.org>
 <308f326d-c7ae-be49-22af-189a81a89aa2@huawei.com>
 <ZNGzqRYzC8lbLG9s@casper.infradead.org>
 <ZNG1+PV5nG8YZDev@casper.infradead.org>
From:   Miaohe Lin <linmiaohe@huawei.com>
Message-ID: <68b73067-59bf-e25f-448f-79ec60fc6639@huawei.com>
Date:   Tue, 8 Aug 2023 14:10:43 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <ZNG1+PV5nG8YZDev@casper.infradead.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/8/8 11:26, Matthew Wilcox wrote:
> On Tue, Aug 08, 2023 at 04:16:57AM +0100, Matthew Wilcox wrote:
>> On Tue, Aug 08, 2023 at 11:08:36AM +0800, Miaohe Lin wrote:
>>> On 2023/8/8 10:31, Matthew Wilcox wrote:
>>>> On Tue, Aug 08, 2023 at 09:58:31AM +0800, Miaohe Lin wrote:
>>>>> kswapd_stop() and kcompactd_stop() are only called when MEMORY_HOTREMOVE
>>>>> is enabled. So wrap them under CONFIG_MEMORY_HOTREMOVE and further remove
>>>>> __meminit annotation. No functional change intended.
>>>>
>>>> I don't understand why this is an improvement.  If CONFIG_MEMORY_HOTREMOVE
>>>> is disabled, the linker drops this section (... right?)  If it's enabled,
>>>
>>> When CONFIG_MEMORY_HOTREMOVE is disabled, without this patch:
>>>
>>> size mm/compaction.o
>>>    text	   data	    bss	    dec	    hex	filename
>>>  103164	  30873	      0	 134037	  20b95	mm/compaction.o
>>>
>>> size mm/vmscan.o
>>>    text	   data	    bss	    dec	    hex	filename
>>>  158775	  49612	     64	 208451	  32e43	mm/vmscan.o
>>>
>>> while with this patch:
>>>
>>> size mm/compaction.o
>>>    text	   data	    bss	    dec	    hex	filename
>>>  102915	  30865	      0	 133780	  20a94	mm/compaction.o
>>>
>>> size mm/vmscan.o
>>>    text	   data	    bss	    dec	    hex	filename
>>>  158534	  49604	     64	 208202	  32d4a	mm/vmscan.o
>>>
>>> We can reduce each .o by ~250 bytes.
>>
>> But this is before the linker step!  That will be where the meminit
>> sections get dropped.  Assuming they are; I haven't verified.  You need
>> to compare before/after of the vmlinux, not the individual .o files.

When CONFIG_MEMORY_HOTREMOVE is disabled, without patch:

size vmlinux
   text	   data	    bss	    dec	    hex	filename
70648396	21668938	17985540	110302874	693169a	vmlinux

while with patch:

size vmlinux
   text	   data	    bss	    dec	    hex	filename
70648128	21668938	17985540	110302606	693158e	vmlinux

vmlinux is still reduced by 268 bytes.

> 
> Ah, found it:
> 
> #if defined(CONFIG_MEMORY_HOTPLUG)
> #define MEM_KEEP(sec)    *(.mem##sec)
> #define MEM_DISCARD(sec)
> #else
> #define MEM_KEEP(sec)
> #define MEM_DISCARD(sec) *(.mem##sec)
> #endif
> 
> in include/asm-generic/vmlinux.lds.h

When CONFIG_MEMORY_HOTREMOVE is disabled, without this patch, kswapd_stop() and kcompactd_stop()
are dropped after system init.

But no insist in this patch.

Thanks for your comment.