Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230808-um_hostaudio-v1-1-3d40fbe1fb1e@google.com>
In-Reply-To: <20230808-um_hostaudio-v1-1-3d40fbe1fb1e@google.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Tue, 8 Aug 2023 10:22:21 -0700
Message-ID: <CAKwvOd=+GHvgFhZyWbZsR8+-Z0WzVAvncM-mhcycR1q244GykA@mail.gmail.com>
Subject: Re: [PATCH] uml: audio: fix -Wmissing-variable-declarations
To:     Richard Weinberger <richard@nod.at>,
        Anton Ivanov <anton.ivanov@cambridgegreys.com>,
        Johannes Berg <johannes@sipsolutions.net>
Cc:     Nathan Chancellor <nathan@kernel.org>, Tom Rix <trix@redhat.com>,
        linux-um@lists.infradead.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev, kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Aug 8, 2023 at 10:21=E2=80=AFAM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> I'm looking to enable -Wmissing-variable-declarations behind W=3D1. 0day
> bot spotted the following instance:
>
>   arch/um/drivers/hostaudio_kern.c:316:3: warning: no previous extern
>   declaration for non-static variable 'module_data'
>   [-Wmissing-variable-declarations]
>   } module_data;
>     ^
>   arch/um/drivers/hostaudio_kern.c:313:1: note: declare 'static' if the
>   variable is not intended to be used outside of this translation unit
>   struct {
>   ^
>
> This symbol is not referenced by more than one translation unit, so give
> it static storage.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/llvm/202308081000.tTL1ElTr-lkp@intel.com/

^ D'oh, wrong report, this should be
https://lore.kernel.org/llvm/202308081050.sZEw4cQ5-lkp@intel.com/
Resending.

> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
>  arch/um/drivers/hostaudio_kern.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/um/drivers/hostaudio_kern.c b/arch/um/drivers/hostaudio=
_kern.c
> index 5b064d360cb7..c42b793bce65 100644
> --- a/arch/um/drivers/hostaudio_kern.c
> +++ b/arch/um/drivers/hostaudio_kern.c
> @@ -310,7 +310,7 @@ static const struct file_operations hostmixer_fops =
=3D {
>         .release        =3D hostmixer_release,
>  };
>
> -struct {
> +static struct {
>         int dev_audio;
>         int dev_mixer;
>  } module_data;
>
> ---
> base-commit: 14f9643dc90adea074a0ffb7a17d337eafc6a5cc
> change-id: 20230808-um_hostaudio-21d7207deaed
>
> Best regards,
> --
> Nick Desaulniers <ndesaulniers@google.com>
>


--=20
Thanks,
~Nick Desaulniers