Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 8 Aug 2023 09:24:33 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Robert Marko <robert.marko@sartura.hr>,
        Luka Perkov <luka.perkov@sartura.hr>,
        Michael Walle <michael@walle.cc>, linux-kernel@vger.kernel.org,
        Randy Dunlap <rdunlap@infradead.org>,
        Chen-Yu Tsai <wenst@chromium.org>,
        Daniel Golle <daniel@makrotopia.org>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
Subject: Re: [PATCH v9 1/7] nvmem: core: Create all cells before adding the
 nvmem device
Message-ID: <20230808092433.039e2f48@xps-13>
In-Reply-To: <b49f8d07-9de9-48b5-27bd-fce02a82c515@linaro.org>
References: <20230808062932.150588-1-miquel.raynal@bootlin.com>
        <20230808062932.150588-2-miquel.raynal@bootlin.com>
        <b49f8d07-9de9-48b5-27bd-fce02a82c515@linaro.org>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Srinivas,

srinivas.kandagatla@linaro.org wrote on Tue, 8 Aug 2023 07:56:47 +0100:

> On 08/08/2023 07:29, Miquel Raynal wrote:
> > Let's pack all the cells creation in one place, so they are all created
> > before we add the nvmem device.
> >=20
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >   drivers/nvmem/core.c | 12 ++++++------
> >   1 file changed, 6 insertions(+), 6 deletions(-)
> >=20
> > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> > index 3f8c7718412b..48659106a1e2 100644
> > --- a/drivers/nvmem/core.c
> > +++ b/drivers/nvmem/core.c
> > @@ -998,12 +998,6 @@ struct nvmem_device *nvmem_register(const struct n=
vmem_config *config)
> >   	if (rval)
> >   		goto err_remove_cells; =20
> >   > -	dev_dbg(&nvmem->dev, "Registering nvmem device %s\n", config->nam=
e); =20
> > -
> > -	rval =3D device_add(&nvmem->dev);
> > -	if (rval)
> > -		goto err_remove_cells;
> > -
> >   	rval =3D nvmem_add_cells_from_fixed_layout(nvmem);
> >   	if (rval)
> >   		goto err_remove_cells;
> > @@ -1012,6 +1006,12 @@ struct nvmem_device *nvmem_register(const struct=
 nvmem_config *config)
> >   	if (rval)
> >   		goto err_remove_cells; =20
> >   > +	dev_dbg(&nvmem->dev, "Registering nvmem device %s\n", config->nam=
e); =20
> > +
> > +	rval =3D device_add(&nvmem->dev);
> > +	if (rval)
> > +		goto err_remove_cells; =20
>=20
> All the error handling paths are now messed up with this patch, put_devic=
e() in error path will be called incorrectly from multiple places.

I'm not sure what this means. Perhaps I should additionally call
device_del() after device_add was successful to mimic the
device_unregister() call from the remove path. Is that what you mean?

I also see the layout_np below should be freed before jumping in the
error section.

Is there anything else I missed? Because you said "from multiple
places", and I don't see this.

Thanks,
Miqu=C3=A8l