Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp4668889rwb; Tue, 8 Aug 2023 11:49:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEuOKg2/F1ZVSz/vNZSKQbJgX7MpmPtrqFJRmUIQTPD9pPD3jHNfz30UMy91JrnanFoR3/J X-Received: by 2002:a17:906:283:b0:99b:4d3c:d7e4 with SMTP id 3-20020a170906028300b0099b4d3cd7e4mr342339ejf.63.1691520575749; Tue, 08 Aug 2023 11:49:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691520575; cv=none; d=google.com; s=arc-20160816; b=AA8Xk4U7mRJxWNR/aEyVAl6T0LK8xC1u2d2D0VAi6ukIySZP5qWbxPkwvJPAUWsBpN yGempf0IHX//RG/1NvaMW1Cj3a2aEQKGK3PTwOEg1XNRZDfj1jn6bBsfTJRpU7HQeYJ9 UIgV59BW+t6Nh/Ftfe8ECKRnwRXjNm0dPF9OCGYtH9mjemgX+Xs0w3byuJ8tdK5GwG2I gFxr7FcFzayjR3bdPY2bc0KiAaC72a1F6hQqy8o3x8XfifKok3iRjKf8zREJhwrghQ1u PZvrLbZlNx8eNL4hr2/VOxL9K8DQVsfZfsHL5p82Xoqs8ZBAREf5OuGvhgSFX1uOWr5k mAdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=5O2J3ZOvO2rHCsErDQjcGUfCgAaBbnfOM3Ddj2mjhyk=; fh=TxQCLceVCK6DhfyPqM45vpOgVORz2Z0wQK0TRO2Rn6o=; b=JbnELxDNCtk2gHBAgwfVOqKZSOas9j/H6VRu/anubC6kZcOIhbHH5qPBfkzGi38CHg kqZOVI85snkIpjLot5jsCJwi+QJMGLqm7uEVZ6zAsbKIf6htGqB4SnDWomhz0K4fUMfc W7Jn3ESgOhBkYmyuDzND4zQRrE6lAsLqKXtPhzu2sJdiZXM8xmU/roN2MoDJBuZJyB8U rQxzeyGs6RaKtbTxc2tid8ZClRT3Z3HOrc2WrhsvB1C7KTE1Z83Xi0+UotmG4IwrJrr0 qK+LR5SK2dpvo3cq7EUsx16eYz569BA+6NX9+vInafP/zi35OLHc9CW9EcuLK2eNyj4o +DUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@treblig.org header.s=bytemarkmx header.b=Vq2SMmKs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g11-20020a17090669cb00b0099bd2095b65si7428949ejs.917.2023.08.08.11.49.11; Tue, 08 Aug 2023 11:49:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@treblig.org header.s=bytemarkmx header.b=Vq2SMmKs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234242AbjHHSU3 (ORCPT + 99 others); Tue, 8 Aug 2023 14:20:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233796AbjHHSUC (ORCPT ); Tue, 8 Aug 2023 14:20:02 -0400 Received: from mx.treblig.org (unknown [IPv6:2a00:1098:5b::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 176AB21240 for ; Tue, 8 Aug 2023 10:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID :Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=5O2J3ZOvO2rHCsErDQjcGUfCgAaBbnfOM3Ddj2mjhyk=; b=Vq2SMmKsiIQ4V2d0R0GIxbtD8t rhzaB4rM41FepLLQIOy6dCcivND3z7YakVxQok02wev6LbOrgElrlslBW9gX67WJHPItY+wmmRcxy zTWgI1QjxDuaZGa/X0N22s//Pf+77jSahC/pk55krmXTac+IvjB0V6cpmi6Vw3eJ6+xCEsnmjresP qzUhMlNuCxtqzEEJNHiHK9U0hh5itD6iDWHVu8ZQKiKDr+Mv1sM02dz3jE3TksPm2CnUWyQc+/KrT ulP2OqYxb6IyTGMS4zSh+L7Gql2+dUoDFzuaKmPeqW/jc4BJDKB6DMq/2EX1riIEXTsPqQOOaY7PT MGH8+bZw==; Received: from dg by mx.treblig.org with local (Exim 4.94.2) (envelope-from ) id 1qTQVX-005lCt-AT; Tue, 08 Aug 2023 17:28:35 +0000 Date: Tue, 8 Aug 2023 17:28:35 +0000 From: "Dr. David Alan Gilbert" To: Randy Dunlap Cc: mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, sam@ravnborg.org, benh@kernel.crashing.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] powerpc: Use shared font data Message-ID: References: <20230807010721.799613-1-linux@treblig.org> <828497a6-80c2-329f-8b47-2311bf08943d@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <828497a6-80c2-329f-8b47-2311bf08943d@infradead.org> X-Chocolate: 70 percent or better cocoa solids preferably X-Operating-System: Linux/5.10.0-23-amd64 (x86_64) X-Uptime: 17:25:06 up 33 days, 2:56, 1 user, load average: 0.06, 0.05, 0.07 User-Agent: Mutt/2.0.5 (2021-01-21) X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,RDNS_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Randy Dunlap (rdunlap@infradead.org) wrote: > Hi-- > > On 8/6/23 18:07, linux@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > > > PowerPC has a 'btext' font used for the console which is almost identical > > to the shared font_sun8x16, so use it rather than duplicating the data. > > > > They were actually identical until about a decade ago when > > commit bcfbeecea11c ("drivers: console: font_: Change a glyph from > > "broken bar" to "vertical line"") > > > > which changed the | in the shared font to be a solid > > bar rather than a broken bar. That's the only difference. > > > > This was originally spotted by PMD which noticed that sparc does > > the same thing with the same data, and they also share a bunch > > of functions to manipulate the data. I've previously posted a near > > identical patch for sparc. > > > > One difference I notice in PowerPC is that there are a bunch of compile > > options for the .c files for the early code to avoid a bunch of security > > compilation features; it's not clear to me if this is a problem for > > this font data. > > > > Tested very lightly with a boot without FS in qemu. > > > > v2 > > Added 'select FONT_SUPPORT' (to stop modconfig causing the font to be > > linked into a module rather than the main kernel) > > Added 'select FONTS' to satisfy requirements in lib/fonts > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > arch/powerpc/Kconfig.debug | 3 + > > arch/powerpc/kernel/btext.c | 360 +----------------------------------- > > 2 files changed, 9 insertions(+), 354 deletions(-) > > > > diff --git a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug > > index 2a54fadbeaf51..521c4baf30e88 100644 > > --- a/arch/powerpc/Kconfig.debug > > +++ b/arch/powerpc/Kconfig.debug > > @@ -147,6 +147,9 @@ config BDI_SWITCH > > config BOOTX_TEXT > > bool "Support for early boot text console (BootX or OpenFirmware only)" > > depends on PPC_BOOK3S > > + select FONT_SUN8x16 > > + select FONT_SUPPORT > > + select FONTS > > help > > Say Y here to see progress messages from the boot firmware in text > > mode. Requires either BootX or Open Firmware. > > kconfig tells me: > > WARNING: unmet direct dependencies detected for FONTS > Depends on [n]: FONT_SUPPORT [=y] && (FRAMEBUFFER_CONSOLE [=n] || STI_CONSOLE [=n]) > Selected by [y]: > - BOOTX_TEXT [=y] && PPC_BOOK3S [=y] > > WARNING: unmet direct dependencies detected for FONT_SUN8x16 > Depends on [n]: FONT_SUPPORT [=y] && FRAMEBUFFER_CONSOLE [=n] && (!SPARC && FONTS [=y] || SPARC) > Selected by [y]: > - BOOTX_TEXT [=y] && PPC_BOOK3S [=y] > > because FONTS depends on FRAMEBUFFER_CONSOLE || STI_CONSOLE and neither of those is set. I'm not getting the warnings in the v2, with a few configs; what command are using? I'm tempted to change the FONT_SUN8x16 dependency line to have SPARC||BOOTX_TEXT or SPARC||POWERPC and drop the 'select FONTS' I added. Dave > > -- > ~Randy -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/