Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <631c5c8c-2a7a-41cb-85fa-6bdded27670e@amd.com>
Date:   Tue, 8 Aug 2023 10:37:06 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V1 6/6] Documentation: introduce AMD Pstate Preferrd Core
 mode kernel command line options
Content-Language: en-US
To:     Meng Li <li.meng@amd.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Huang Rui <ray.huang@amd.com>
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        x86@kernel.org, linux-acpi@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>,
        linux-kselftest@vger.kernel.org,
        Nathan Fontenot <nathan.fontenot@amd.com>,
        Deepak Sharma <deepak.sharma@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Shimmer Huang <shimmer.huang@amd.com>,
        Perry Yuan <Perry.Yuan@amd.com>,
        Xiaojian Du <Xiaojian.Du@amd.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Borislav Petkov <bp@alien8.de>
References: <20230808081001.2215240-1-li.meng@amd.com>
 <20230808081001.2215240-7-li.meng@amd.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20230808081001.2215240-7-li.meng@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dm1WcS96Tm93YkRmK0hmV3k4ZzRMWFNqSHB5OU9VbVR3NktsOUFVRkJuOXNU?=
 =?utf-8?B?OHRmZEowWEJWaEJRblg5d2RMdytvb1puNDZzU0lONWlWTlJaL0lndUQrUmFm?=
 =?utf-8?B?VjBhVDFtbENHb2t3RkxjKzhManVsWkZBbEt3ZEJ0ZGpRcGw4QTNHenQ4MHNl?=
 =?utf-8?B?ZEhrS1BiOGhkenlmQ3RtcUdjYUp3dm1KUG9hK1dhajBDQ0owWEk4UXZ0V2lk?=
 =?utf-8?B?VHRoVVlweVZkaCs5UEFaT1dKdzBwcmJ3NFp3OGV1WVN5NTBXOHBSbTQwdVQz?=
 =?utf-8?B?amc0RnI1TCtPaGNBUTFIV2N0YTg4UmtlNzhSSC9IdXB5eXdnWkxUL3QvTkNq?=
 =?utf-8?B?ZTlVdXY5MXZDdzNrWEJuenFRMTRQQ1ZVRzBtUFdJVEZLMnhNWTVIQjZ6UCtx?=
 =?utf-8?B?dE90UFJFYTlmM1k3ckRXR2Z1eDhyVGczMjFIZjd0L1dCTURFb1NieE5yWDNr?=
 =?utf-8?B?NTVQZ3A2WnNuTkZVMVlVRVM0b3FScHBWUm45SVdWQlBBcUdJQkFHQVpRdTEv?=
 =?utf-8?B?TEtVbzBlVHRRTVBjTUJnSTUxdVdBWWsycERTT2QrdStIdzJESHVhWDZqQ0Yr?=
 =?utf-8?B?OGtmZGFESSswa21HYXMwQjkzbDBvZWtGNnBLd0tWc21odHVFWHp0NUJBZFdi?=
 =?utf-8?B?b3RCSWV3cEdUYVJKT0swcmh5N1NHUkFOL2ltWUhET1hJSGcvNVZIVGtPcERr?=
 =?utf-8?B?dGhhREoySFh2azZYN24yR1FVR3VvVFdUQkErZ1o1b1lUeGhGd1ZOWnVEbUFn?=
 =?utf-8?B?VVRsVlRHZVhzZDV4ZUR3Wjd6b1BJbWpJMHVHTFhmZmphYUNIWU1UQWNVaEJ5?=
 =?utf-8?B?eFZKUFRHbk52SWplTDNBQVgxWDRSSnNRYXVheEJpVEc4MWcwYXZyWHI3R3pM?=
 =?utf-8?B?T0V1VkExSTdvaW1ZL3pFSkRvbEVKVm1pQkJpcDVPSERCNVAvbzRJZDRIcGNF?=
 =?utf-8?B?OS92M3kyejg4REhKS0dnZFRSbUhlczBjVDhFZldTWDVQcVV5ei9RUmMySTN2?=
 =?utf-8?B?MFB3d0l0NnRldzdvNGU4WG5oaHJHS2NlTGwwdGdGZjA3dzJrMkdrdkFSUFZB?=
 =?utf-8?B?MlRNME1UaGRqTXh2S0xud1J1MEI1TG1DZ3NJREFvRnhGK3NCMWZnUkJTa282?=
 =?utf-8?B?dm13b0xTcGhyKzAyMWlZQTRyZnRTaFBKdytIeXpsc2JNT0I4WUFLZmZqd3lo?=
 =?utf-8?B?RTBuRjVPdzNYRnVocldIU1V4eE5OdmFBcEp3YjByZHYxUTB0aFRnYzVuRUp0?=
 =?utf-8?B?Y2xHL1JrWGxXR09vei84a2xKZUVadmFrTGROR1lPVnFkMldwWWdTMCt5Um9W?=
 =?utf-8?B?aUt1bjJxWUk4bWZXbTZVSGcxd3lmWFpiRTZrNnp5ZktDS2w2VFBKNVgreFcr?=
 =?utf-8?B?TVRiQTYrNDRUcjVsSlZ4TEZBV1hUYzlPaXBDWWpidVZYRGEzclJUQzNweUJL?=
 =?utf-8?B?NHpRbmFHUWs4SjFXLzU1NjJhN0xpQ09xU25QdkVxeXpPc0J5YzNwd0FwRkgw?=
 =?utf-8?B?R3lOM2JiSVB2R0NhdENCM1JiUU0yV0hpUUFCTjUwNlBCVk03TUh1blV5bzZs?=
 =?utf-8?B?bGs0ZExlMEhnZHRBZVR2Y3IvMjdzR3N1dFB5TGZ2K3hoK1cvOHpyai9waWxV?=
 =?utf-8?B?dURqY3hYR0QvOWtIK1UwaEpPSXFyNXdCKzVOaDM2cEw3bWp2QzdqMnIrajN4?=
 =?utf-8?B?R3RwSWZ3cFlGQjJzbHNjUVVJcjN3bEpzMk5lRVlFRzlGRlNsdjZHMWpOS3dk?=
 =?utf-8?B?UjB0aTZ5SDIyemV6OVhEcmpZYkV2Z0N1K3duMWVaQk9nQStCYmNqTFhXVE9H?=
 =?utf-8?B?ZGtXdEFRZVl0Z2JTZ3ExdVh1d0VXdEk3Y1NuNTNhM245eHJQY1pCWVB4YnV6?=
 =?utf-8?B?dXB6ckF0UHd1b2xXSEExbzc0OUsvc1V4NG4yand1VDlyWFVCQWduZk00TXUy?=
 =?utf-8?B?S1VGbkFzZWlOSTdKbDRYRXovaVB3WElMYzFUazFENGNLdE5SR29maEliYUxD?=
 =?utf-8?B?NnB1WkFDbTNGbVIyK3RhTnEzb0hIbWcxVWp3NmJUYldJVTMyNUY2cVFjeUZI?=
 =?utf-8?B?YTU3RU94akd5MFNpbDcxSi9qNCtRWFZSa1ZURTh2cFExWUJ2TzhRSjdzTTlh?=
 =?utf-8?Q?JvTGyWslEbZxu/qBFUWRdlAmm?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6167509b-e78f-494d-640f-08db9825531f
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 15:37:08.2956
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LQ2jwEqXSoJ8XqDsBBWWDHtfTVW+RpOsjh6wlr4WQdpkV9C4H9URItQIpScGTzJO5BX+NuVS12NQ07YH+AXXcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7580
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_NONE,URIBL_BLOCKED
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/8/2023 03:10, Meng Li wrote:
> AMD Pstate driver support enable/disable Preferred core.
> Default disabled on platforms supporting AMD Preferred Core.

Why default disabled?

Shouldn't this default enabled and then let users decide they don't want 
to use it if it's causing a problem for them?

> Enable AMD Pstate Preferred Core with
> "amd_prefcore=enable" added to the kernel command line.
> 
> Signed-off-by: Meng Li <li.meng@amd.com>
> ---
>   Documentation/admin-guide/kernel-parameters.txt | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 2de235d52fac..bc92e178431b 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -363,6 +363,11 @@
>   			  selects a performance level in this range and appropriate
>   			  to the current workload.
>   
> +	amd_prefcore=
> +			[X86]
> +			enable
> +			  Enable AMD Pstate Preferred Core.
> +
>   	amijoy.map=	[HW,JOY] Amiga joystick support
>   			Map of devices attached to JOY0DAT and JOY1DAT
>   			Format: <a>,<b>