Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 8 Aug 2023 09:34:03 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Nicolin Chen <nicolinc@nvidia.com>
Cc:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>
Subject: Re: [PATCH v4 09/12] iommu/vt-d: Add iotlb flush for nested domain
Message-ID: <ZNI2O4Upyna5AWDA@nvidia.com>
References: <20230724111335.107427-1-yi.l.liu@intel.com>
 <20230724111335.107427-10-yi.l.liu@intel.com>
 <BN9PR11MB527690EBAA872A16AE8926F88C0BA@BN9PR11MB5276.namprd11.prod.outlook.com>
 <DS0PR11MB7529F4D4DABBE29E9B7BF5C9C30CA@DS0PR11MB7529.namprd11.prod.outlook.com>
 <ZNGypUee/U9d68TZ@Asurada-Nvidia>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZNGypUee/U9d68TZ@Asurada-Nvidia>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fajDz3R9EKu21VOipfbnYokBRjrp1y9MTiACSpBl5BNkRbbDfku4Z6TMDIv1?=
 =?us-ascii?Q?pHJXH6ZiIjBbwHNojNtHU4ihzRp9wjudLBdN5ZXWaP3Z1l56+hb+ZTpGc7i8?=
 =?us-ascii?Q?+8UrZe1UeJPp9/mfTXV6zirzDND69OMUQWiLH1nFdDhly5dwa11ORWsyO4Bz?=
 =?us-ascii?Q?dJSjEZ9gkCAPvo5v9AlI/rPzohaXMUzzOTGwATs8o9RQ0D/OAjNvw0TUPCnO?=
 =?us-ascii?Q?GV4LdbivcCMFbZZqXE9K/PcIkVDiE+yXByigdW/M5UqIWb/pR0MnjpNeMmc3?=
 =?us-ascii?Q?XqcolfuWhRxz530hAEAzs/I8b4TGwu2JUnD9o7KN3PnlnbsSmOtZdMi4LKlE?=
 =?us-ascii?Q?AqFDh7e4/Pwr7XWns8TY0hmzjTiQkhFrsMhgBsvcRCvfV95RtjiUUdoMJXSV?=
 =?us-ascii?Q?y3Kiv/onc4vZKy+p1ZdGT+kI9qTVYeed9RzFZyPf8AyJVsrsWp3XVS+9BNkU?=
 =?us-ascii?Q?PNzejRCjAYkHcU5yAbQGfUvWbv2BdQTKFqaJHd2gEfx8P1L56RXb/DK7nakL?=
 =?us-ascii?Q?HYBSo9TWCLHzGtuqmzTKie3JL65BgNsCVYg+CPy6sq7eR21+yfIyMaSqqH1n?=
 =?us-ascii?Q?X3N3L3P5R2E47l4kfEP7KX/E9KklIL7OKZVzHmSu9np7u75STO5G7b21M4Ya?=
 =?us-ascii?Q?NyhpaDPZfGCaqiSEC0itQ3h83enLa+1HamGZTpu9E7NO++y5/QSAbw5l7rJx?=
 =?us-ascii?Q?eXC5XP5zYqq05HEbTnTC8nzPoq9Cd/jXCEW3TIvnHgo444rYDqzByd4FARtc?=
 =?us-ascii?Q?pxB2Wx1pskAm4apMVWqZo2Nq2NU6fjo4a7lZPHtDjnIYBHcBR+oxITKgQ6XY?=
 =?us-ascii?Q?tCs1LxoZyg/ghH50u14FJqPfChoAeGcl74ae4NzWig2cvP3H+zjpDZ7iSYho?=
 =?us-ascii?Q?kOW0UyEPBDfnUq4+avoTuCcQuGsVgsyfQ5or1PZf2mxdt7cPTUPnWD7BtCqN?=
 =?us-ascii?Q?fnm4chzS+5657Ziq3krlIrZGNg2OtcSn9nXH8A24/AGgbxCUqdoQ39flkhtR?=
 =?us-ascii?Q?OdeB+PVrB4dN24VUB5aIyyXyakTIhQpgGFJxytK/YoBLCnVvUc3JTbsMUcWQ?=
 =?us-ascii?Q?X1s7+hDRSXf57Ji+laLoUAOKo/kjCRKGVZ7znTibNwysFn9bLECx/R4ZBHFj?=
 =?us-ascii?Q?hCfVS/2exchZbLBoG+OF35DYTChsDN7LBTz5Zvzq2dghQgiRYp+B5f5oUetN?=
 =?us-ascii?Q?bt6K5evdBwat6tHvVzRxCSBuPQloHyu6IumtP+dkR8gEaLvLnFhIg/TJfgiZ?=
 =?us-ascii?Q?b1xOxl2BxOneRziZeJYD5oAiuF+YrClUWDRfd5q11fC/6ZSxg+4tRaZPF7l6?=
 =?us-ascii?Q?qUEfzjhx3sAK8Y/CI0LmcENC6ojIrwTeBcHScDOlBpm2qULYErCC+bcOvd/h?=
 =?us-ascii?Q?liTz+51JOGMOq/KbygTE2Uu+QEGDEmT8XS3xLXxLFSEQ3mfL/XQvosPoTTv0?=
 =?us-ascii?Q?c7MUcKMqfmkZ5dgbfIx8jyu2hh2UQU4eebNAX8S/WRV56ERz24Jrl2O4xWls?=
 =?us-ascii?Q?/DBfe8epPPQqbJMWrFWkuSnLErx4yqJKyqvMkQiVYTsTWu3Zn+Ve7/l3+syT?=
 =?us-ascii?Q?+BZ7td3PPWwJzIuRvyN6YXn+7ArK2bZi1bZGbEos?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 872e303e-03ed-4cb4-8c60-08db980bc07b
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 12:34:04.6406
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FGBHXbFASyVrxvh/1UKxpArogDT0UBptPzg3aMxUotDJWVRbsLKlsh8MiNXmbzRK
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4412
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_NONE,URIBL_BLOCKED
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 07, 2023 at 08:12:37PM -0700, Nicolin Chen wrote:
> On Mon, Aug 07, 2023 at 03:08:29PM +0000, Liu, Yi L wrote:
> > > > From: Liu, Yi L <yi.l.liu@intel.com>
> > > > Sent: Monday, July 24, 2023 7:14 PM
> > > >
> > > > +static int intel_nested_cache_invalidate_user(struct iommu_domain
> > > > *domain,
> > > > +                                         void *user_data)
> > > > +{
> > > > +   struct iommu_hwpt_vtd_s1_invalidate_desc *req = user_data;
> > > > +   struct iommu_hwpt_vtd_s1_invalidate *inv_info = user_data;
> > > > +   struct dmar_domain *dmar_domain = to_dmar_domain(domain);
> > > > +   unsigned int entry_size = inv_info->entry_size;
> > > > +   u64 uptr = inv_info->inv_data_uptr;
> > > > +   u64 nr_uptr = inv_info->entry_nr_uptr;
> > > > +   struct device_domain_info *info;
> > > > +   u32 entry_nr, index;
> > > > +   unsigned long flags;
> > > > +   int ret = 0;
> > > > +
> > > > +   if (get_user(entry_nr, (uint32_t __user *)u64_to_user_ptr(nr_uptr)))
> > > > +           return -EFAULT;
> > > > +
> > > > +   for (index = 0; index < entry_nr; index++) {
> > > > +           ret = copy_struct_from_user(req, sizeof(*req),
> > > > +                                       u64_to_user_ptr(uptr + index *
> > > > entry_size),
> > > > +                                       entry_size);
> > >
> > > If continuing this direction then the driver should also check minsz etc.
> > > for struct iommu_hwpt_vtd_s1_invalidate and iommu_hwpt_vtd_s1_invalidate_desc
> > > since they are uAPI and subject to change.
> > 
> > Then needs to define size in the uapi data structure, and copy size first and
> > check minsz before going forward. How about the structures for hwpt alloc
> > like struct iommu_hwpt_vtd_s1? Should check minsz for them as well?
> 
> Assuming that every uAPI data structure needs a min_size, we can
> either add a structure holding all min_sizes like iommufd main.c
> or have another xx_min_len in iommu_/domain_ops.

If driver is doing the copy it is OK that driver does the min_size
check too

Jason