Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp4674486rwb; Tue, 8 Aug 2023 11:56:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE3bULEpvKlHnAS96VkqvAA5V9U2ZtAd/neJYSHxuzOf82xGQq9/qVMawFfraAsHKXYXq93 X-Received: by 2002:a05:6a00:1d92:b0:67a:72d5:3365 with SMTP id z18-20020a056a001d9200b0067a72d53365mr11867521pfw.6.1691520972269; Tue, 08 Aug 2023 11:56:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691520972; cv=none; d=google.com; s=arc-20160816; b=UaxEt2elUI2EXutqC1aVEAmCz1hIcmaOJg08LFu1uDCs11HC0lFn3zKrI/4ka7zP43 qeyM6ycevZ1Ffln/i10WU9VaVouEvCqRzhRCZDa8lI5dG11ocsz7T/3vWvcEPbm2EL5G Pys8fNRBU393qXDJtiRLnwWQ52ELQFKJBMV33VgJQeqgKrBe++WirnUEP+ouU3ayYgGI qfZ9vSfsw6Atq58AJepaMYBBZZSBSfqx4tIcQm8nvFybv+/fEMii4NeWUeGntV+TpuVO 6uY8ALgFZ6f/JYtmSak4WboNX6dSYlC73ZViEAB74fsLkks9HIMX+tfB+he25z8wVKK2 ikJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=9rSG2TNU59Si5m6bljaLKJEJPmpsQdVWsYgo9RPk8Vs=; fh=S4URyNAad87Yxi2/a+HeVWcF+2cFa+H0Sd7mMFfPnYk=; b=zUzvAqZENeO6NAHsSp7laa9pZfQEnITt/BsXPoroDarxz5xJS16loZbADG9t+YG3gB VIXFGVIRazXe0bSx3QJh5YOphLJKyTrRbCPIyEWS3eWWC3skw+/QLG2EF4Lk7zCiM+aM 8P+7zMnEVYt/jqeO4mB9hnLPgmqMxyZTh9+rbgZaqE9s45uUo57O/gzt8RoveoelkkcT Xy8q4B84LZh9OGJ+g64y6bALrMlz7RVK0RzgOqigtxurgjEB+svFGsKEf9s3QLfOYnB6 XePJaaF+7hVbpkyV2IJxe4vlV1In7nHb9GvcmPYZUU2i0GRtLoQg8gVkyeBzVQs0l40t xTvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=h+LJD6xt; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b="6FFEp/Qp"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fi14-20020a056a00398e00b00666ad95e625si7711406pfb.337.2023.08.08.11.56.00; Tue, 08 Aug 2023 11:56:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=h+LJD6xt; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b="6FFEp/Qp"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232453AbjHHRw0 (ORCPT + 99 others); Tue, 8 Aug 2023 13:52:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232831AbjHHRvs (ORCPT ); Tue, 8 Aug 2023 13:51:48 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53378B5EB7 for ; Tue, 8 Aug 2023 09:23:09 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7C8AE2249A; Tue, 8 Aug 2023 12:45:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1691498734; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9rSG2TNU59Si5m6bljaLKJEJPmpsQdVWsYgo9RPk8Vs=; b=h+LJD6xtmsMgoKzXIYajVr2dasHn2amUpZS78uy35MwyA6LFc+YHFErJpRUR9hbjdxIWQa YJ9XVnbfCsYZKIo3i86BgphvWqG0C5/h9NiOhAdaQ2SXWsUsrAugo8LQ/pn6VFbX5fq90R C1dLXUHAj8aPgfgIUsWpMkTn4GWV+eE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1691498734; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9rSG2TNU59Si5m6bljaLKJEJPmpsQdVWsYgo9RPk8Vs=; b=6FFEp/Qp+ZGEym7OH90haRpGWAMBMY6R3VWqQ057Pu9vyE/e4JQ8CpO41gU4SmqFVfGQFc jF3wg/4I+zhosZAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 53ABD139D1; Tue, 8 Aug 2023 12:45:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id zoV6E+440mR/AgAAMHmgww (envelope-from ); Tue, 08 Aug 2023 12:45:34 +0000 Date: Tue, 08 Aug 2023 14:45:33 +0200 Message-ID: <87r0odhfde.wl-tiwai@suse.de> From: Takashi Iwai To: Ivan Orlov Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] ALSA: pcmtest: Move buffer iterator initialization to prepare callback In-Reply-To: <20230804110740.9867-1-ivan.orlov0322@gmail.com> References: <20230804110740.9867-1-ivan.orlov0322@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 04 Aug 2023 13:07:39 +0200, Ivan Orlov wrote: > > Trigger callback is not the best place for buffer iterator > initialization, so move it out to the prepare callback, where it > have to be. > > Minor enhancement: remove blank line. > > Signed-off-by: Ivan Orlov > --- > V1 -> V2: > - Split changes in the patch into two different patches Thanks, applied both patches now. Takashi