Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Aug 2023 22:42:48 -0700
From:   Shradha Gupta <shradhagupta@linux.microsoft.com>
To:     Ani Sinha <anisinha@redhat.com>
Cc:     Wei Liu <wei.liu@kernel.org>, Olaf Hering <olaf@aepfle.de>,
        linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Dexuan Cui <decui@microsoft.com>,
        Long Li <longli@microsoft.com>,
        Michael Kelley <mikelley@microsoft.com>
Subject: Re: [PATCH v3] hv/hv_kvp_daemon: Add support for keyfile config
 based connection profile in NM
Message-ID: <20230808054248.GA12620@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1683265875-3706-1-git-send-email-shradhagupta@linux.microsoft.com>
 <20230508095340.2ca1630f.olaf@aepfle.de>
 <ZFknuu+f74e1zHZe@liuwe-devbox-debian-v2>
 <20230508191246.2fcd6eb5.olaf@aepfle.de>
 <ZFkuY4dmwiPsUJ3+@liuwe-devbox-debian-v2>
 <20230523053627.GA10913@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <53E9AC1D-C907-4B55-97F2-FC10DCD4D470@redhat.com>
 <4142F3A4-8AB4-4DE2-8D03-D3A8F8776BF9@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4142F3A4-8AB4-4DE2-8D03-D3A8F8776BF9@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

On Tue, Aug 08, 2023 at 10:41:21AM +0530, Ani Sinha wrote:
> 
> 
> > On 12-Jul-2023, at 12:32 PM, Ani Sinha <anisinha@redhat.com> wrote:
> > 
> > 
> > 
> >> On 23-May-2023, at 11:06 AM, Shradha Gupta <shradhagupta@linux.microsoft.com> wrote:
> >> 
> >> On Mon, May 08, 2023 at 05:16:19PM +0000, Wei Liu wrote:
> >>> On Mon, May 08, 2023 at 07:12:46PM +0200, Olaf Hering wrote:
> >>>> Mon, 8 May 2023 16:47:54 +0000 Wei Liu <wei.liu@kernel.org>:
> >>>> 
> >>>>> Olaf, is this a reviewed-by from you? :-)
> >>>> 
> >>>> Sorry, I did not review the new functionality, just tried to make sure there will be no regression for existing consumers.
> >>> 
> >>> Okay, this is fine, too. Thank you for looking into this.
> >>> 
> >>> 
> >>>> 
> >>>> Olaf
> >>> 
> >> 
> >> Gentle reminder.
> >> 
> > 
> > I have a comment about the following change:
> > 
> > +		error = fprintf(nmfile, "\n[ipv4]\n");
> > +		if (error < 0)
> > +			goto setval_error;
> > +
> > +		if (new_val->dhcp_enabled) {
> > +			error = kvp_write_file(nmfile, "method", "", "auto");
> > +			if (error < 0)
> > +				goto setval_error;
> > +		} else {
> > +			error = kvp_write_file(nmfile, "method", "", "manual");
> > +			if (error < 0)
> > +				goto setval_error;
> > +		}
> > 
> > I think the method equally would apply for ipv6 as it applies for ipv4. 
> > We can use https://www.golinuxcloud.com/nmcli-command-examples-cheatsheet-centos-rhel/#18_Disable_IPv6_Address_for_ethernet_connection_IPV6INIT as a reference. 
> > So setting the method should be common to both ipv4 and ipv6.
> 
> Ping once more ???
> Can anyone comment on the avove and/or review the patchset?
That's correct Ani, this needs to be enabled for ipv6 as well, will send out another version. Thanks for catching this.