Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230808-riscv_static-v1-1-9f3dc99dafe8@google.com> <20230808162412.GA2172017@dev-arch.thelio-3990X>
In-Reply-To: <20230808162412.GA2172017@dev-arch.thelio-3990X>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Tue, 8 Aug 2023 09:27:19 -0700
Message-ID: <CAKwvOd=93QE6d1Runn9EO9A4KBAKvhx4RwZTpWNNFcf2eW1kWQ@mail.gmail.com>
Subject: Re: [PATCH] riscv: mm: fix 2 instances of -Wmissing-variable-declarations
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>, Tom Rix <trix@redhat.com>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev, kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Aug 8, 2023 at 9:24=E2=80=AFAM Nathan Chancellor <nathan@kernel.org=
> wrote:
>
> On Tue, Aug 08, 2023 at 09:15:41AM -0700, Nick Desaulniers wrote:
> > diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/=
pgtable.h
> > index 75970ee2bda2..4c8c0f83a974 100644
> > --- a/arch/riscv/include/asm/pgtable.h
> > +++ b/arch/riscv/include/asm/pgtable.h
> > @@ -188,6 +188,7 @@ extern struct pt_alloc_ops pt_ops __initdata;
> >  #define PAGE_KERNEL_IO               __pgprot(_PAGE_IOREMAP)
> >
> >  extern pgd_t swapper_pg_dir[];
> > +extern pgd_t trampoline_pg_dir[];
>
> Missing early_pg_dir too? It looks like there is already a declaration
> in arch/riscv/mm/kasan_init.c that could be hoisted here?

Yep, will respin. Good catch!

--=20
Thanks,
~Nick Desaulniers