Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <910a4a98-712a-5517-5a5b-ffb962f83463@ti.com>
Date:   Tue, 8 Aug 2023 15:14:31 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] dt-bindings: remoteproc: pru: Add Interrupt property
Content-Language: en-US
To:     Conor Dooley <conor@kernel.org>,
        MD Danish Anwar <danishanwar@ti.com>
CC:     Suman Anna <s-anna@ti.com>, Conor Dooley <conor+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Bjorn Andersson <andersson@kernel.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-remoteproc@vger.kernel.org>, <linux-omap@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <vigneshr@ti.com>,
        <srk@ti.com>, <nm@ti.com>
References: <20230807110836.2612730-1-danishanwar@ti.com>
 <20230807-euphemism-trailing-ef4130dc7437@spud>
From:   Md Danish Anwar <a0501179@ti.com>
Organization: Texas Instruments
In-Reply-To: <20230807-euphemism-trailing-ef4130dc7437@spud>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Conor,

On 07/08/23 8:09 pm, Conor Dooley wrote:
> On Mon, Aug 07, 2023 at 04:38:36PM +0530, MD Danish Anwar wrote:
>> Add interrupts and interrupt-names protperties for PRU and RTU cores.
>>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> ---
>>  .../bindings/remoteproc/ti,pru-rproc.yaml     | 22 +++++++++++++++++++
>>  1 file changed, 22 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>> index cd55d80137f7..6970316943bb 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>> @@ -66,6 +66,16 @@ properties:
>>        Should contain the name of the default firmware image
>>        file located on the firmware search path.
>>  
>> +  interrupts:
>> +    maxItems: 1
>> +    description:
>> +      Interrupt specifiers enable the virtio/rpmsg communication between MPU
>> +      and the PRU/RTU cores.
>> +
>> +  interrupt-names:
>> +    items:
>> +      - const: vring
>> +
>>  if:
>>    properties:
>>      compatible:
>> @@ -171,6 +181,9 @@ examples:
>>                <0x22400 0x100>;
>>          reg-names = "iram", "control", "debug";
>>          firmware-name = "am65x-pru0_0-fw";
>> +        interrupt-parent = <&icssg0_intc>;
>> +        interrupts = <16 2 2>;
>> +        interrupt-names = "vring";
>>        };
> 
> These examples would probably be more helpful if they used the
> appropriate defines, no?
> 

PRUSS Interrupt controller doesn't have any appropriate defines. This doesn't
use GIC so defines from arm-gic.h can not be used here. These are specific to
PRUSS INTC.

I think these example are OK. Please let me know if this is OK to you.

>>  
>>        rtu0_0: rtu@4000 {
>> @@ -180,6 +193,9 @@ examples:
>>                <0x23400 0x100>;
>>          reg-names = "iram", "control", "debug";
>>          firmware-name = "am65x-rtu0_0-fw";
>> +        interrupt-parent = <&icssg0_intc>;
>> +        interrupts = <20 4 4>;
>> +        interrupt-names = "vring";
>>        };
>>  
>>        tx_pru0_0: txpru@a000 {
>> @@ -198,6 +214,9 @@ examples:
>>                <0x24400 0x100>;
>>          reg-names = "iram", "control", "debug";
>>          firmware-name = "am65x-pru0_1-fw";
>> +        interrupt-parent = <&icssg0_intc>;
>> +        interrupts = <18 3 3>;
>> +        interrupt-names = "vring";
>>        };
>>  
>>        rtu0_1: rtu@6000 {
>> @@ -207,6 +226,9 @@ examples:
>>                <0x23c00 0x100>;
>>          reg-names = "iram", "control", "debug";
>>          firmware-name = "am65x-rtu0_1-fw";
>> +        interrupt-parent = <&icssg0_intc>;
>> +        interrupts = <22 5 5>;
>> +        interrupt-names = "vring";
>>        };
>>  
>>        tx_pru0_1: txpru@c000 {
>> -- 
>> 2.34.1
>>

-- 
Thanks and Regards,
Danish.