Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 8 Aug 2023 13:03:33 -0400
From:   Hugo Villeneuve <hugo@hugovil.com>
To:     Yue Haibing <yuehaibing@huawei.com>
Cc:     <agk@redhat.com>, <snitzer@kernel.org>, <dm-devel@redhat.com>,
        <heinzm@redhat.com>, <linux-kernel@vger.kernel.org>
Message-Id: <20230808130333.2207c675d008fa6c808a472f@hugovil.com>
In-Reply-To: <20230808150301.45196-1-yuehaibing@huawei.com>
References: <20230808150301.45196-1-yuehaibing@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH -next] dm: Remove unused declaration dm_get_rq_mapinfo()
Precedence: bulk

On Tue, 8 Aug 2023 23:03:01 +0800
Yue Haibing <yuehaibing@huawei.com> wrote:

Hi,

> Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()")
> removed the implementation but leave declaration.

Maybe change to "removed the implementation but not the declaration."

Hugo Villeneuve.


> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  include/linux/device-mapper.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h
> index 69d0435c7ebb..5bc69c6a64e0 100644
> --- a/include/linux/device-mapper.h
> +++ b/include/linux/device-mapper.h
> @@ -502,7 +502,6 @@ int dm_post_suspending(struct dm_target *ti);
>  int dm_noflush_suspending(struct dm_target *ti);
>  void dm_accept_partial_bio(struct bio *bio, unsigned int n_sectors);
>  void dm_submit_bio_remap(struct bio *clone, struct bio *tgt_clone);
> -union map_info *dm_get_rq_mapinfo(struct request *rq);
>  
>  #ifdef CONFIG_BLK_DEV_ZONED
>  struct dm_report_zones_args {
> -- 
> 2.34.1
>