Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230807130108.853357011@linutronix.de> <20230807135027.429700142@linutronix.de>
In-Reply-To: <20230807135027.429700142@linutronix.de>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 8 Aug 2023 14:37:58 +0300
Message-ID: <CAHp75VdbrvK4iPVuGP+Se+RgKUrwEh9VuLCN9Rn_yXJ5Z_u=4A@mail.gmail.com>
Subject: Re: [patch 19/53] x86/mpparse: Remove the physid_t bitmap wrapper
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Huang Rui <ray.huang@amd.com>, Juergen Gross <jgross@suse.com>,
        Dimitri Sivanich <dimitri.sivanich@hpe.com>,
        Michael Kelley <mikelley@microsoft.com>,
        Sohil Mehta <sohil.mehta@intel.com>,
        K Prateek Nayak <kprateek.nayak@amd.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Zhang Rui <rui.zhang@intel.com>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Feng Tang <feng.tang@intel.com>,
        Andy Shevchenko <andy@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Aug 7, 2023 at 4:53=E2=80=AFPM Thomas Gleixner <tglx@linutronix.de>=
 wrote:
>
> physid_t is a wrapper around bitmap. Just remove the onion layer and use
> bitmap functionality directly.

...

>  #include <linux/clockchips.h>
>  #include <linux/interrupt.h>
>  #include <linux/memblock.h>

> +#include <linux/bitmap.h>

Hmm... What is the ordering here? Reversed xmas tree?
Otherwise wouldn't it be better to put this before clockchips.h?

>  #include <linux/ftrace.h>
>  #include <linux/ioport.h>
>  #include <linux/export.h>

--=20
With Best Regards,
Andy Shevchenko