Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-624-g7714e4406d-fm-20230801.001-g7714e440
Mime-Version: 1.0
Message-Id: <487477f3-9708-4a28-a4fa-0c652353467b@app.fastmail.com>
In-Reply-To: <20230808072501.3393-1-Wenhua.Lin@unisoc.com>
References: <20230808072501.3393-1-Wenhua.Lin@unisoc.com>
Date:   Tue, 08 Aug 2023 10:02:28 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Wenhua Lin" <Wenhua.Lin@unisoc.com>,
        "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
        "Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
        "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
        =?UTF-8?Q?Nuno_S=C3=A1?= <nuno.sa@analog.com>,
        "Samuel Holland" <samuel@sholland.org>,
        "Robert Jarzmik" <robert.jarzmik@free.fr>,
        "Mattijs Korpershoek" <mkorpershoek@baylibre.com>,
        "Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
        "Orson Zhai" <orsonzhai@gmail.com>,
        "Baolin Wang" <baolin.wang@linux.alibaba.com>,
        "Chunyan Zhang" <zhang.lyra@gmail.com>
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        "wenhua lin" <wenhua.lin1994@gmail.com>,
        "Xiongpeng Wu" <xiongpeng.wu@unisoc.com>
Subject: Re: [PATCH] input: keyboard: Add sprd-keypad driver
Content-Type: text/plain
Precedence: bulk

On Tue, Aug 8, 2023, at 09:25, Wenhua Lin wrote:
> Add matrix keypad driver, support matrix keypad function.
>
> Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>

Looks fine to me, just one minor thing to remember:

> +static int __maybe_unused sprd_keypad_resume(struct device *dev)
> +{
> +	struct sprd_keypad_data *data = dev_get_drvdata(dev);
> +	int ret = 0;
> +
> +	if (!device_may_wakeup(dev)) {
> +		ret = sprd_keypad_enable(data);
> +		if (ret)
> +			return ret;
> +		ret = sprd_keypad_hw_init(data);
> +	}
> +
> +	return ret;
> +}
> +
> +static SIMPLE_DEV_PM_OPS(sprd_keypad_pm_ops,
> +			sprd_keypad_suspend, sprd_keypad_resume);
> +

SIMPLE_DEV_PM_OPS() is deprecated, please use the new
DEFINE_SIMPLE_DEV_PM_OPS() for all new drivers, and
remove the __maybe_unused annotation that is no longer
needed with that.

With that addressed (for the driver in general, I know nothing
about the drivers/input specifics)

Acked-by: Arnd Bergmann <arnd@arndb.de>

     Arnd