Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4c682c3d-7066-108f-4e40-8127adf160e0@kernel.org>
Date:   Tue, 8 Aug 2023 10:10:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH 1/2] hwmon: Add driver for EMC181x temperature sensors
Content-Language: en-US
To:     Mathew McBride <matt@traverse.com.au>,
        Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>
Cc:     linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
References: <20230808013157.80913-1-mark.tomlinson@alliedtelesis.co.nz>
 <0248d597-b72a-5b7c-63a4-6d72384f9854@kernel.org>
 <b84c2fba-1bbe-4842-a861-525784d8a361@app.fastmail.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
In-Reply-To: <b84c2fba-1bbe-4842-a861-525784d8a361@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/08/2023 09:54, Mathew McBride wrote:
> Hi Krzysztof,
> 
> On Tue, Aug 8, 2023, at 5:38 PM, Krzysztof Kozlowski wrote:
>> On 08/08/2023 03:31, Mark Tomlinson wrote:
>>> This patch adds a HWMON driver for the EMC1812, EMC1813, EMC1814,
>>> EMC1815 and EMC1833 temperature sensor chips from microchip. Does not
>>> currently support the alert outputs.
>>>
>>> Signed-off-by: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
>>> Co-developed-by: Mathew McBride <matt@traverse.com.au>
>>> Signed-off-by: Mathew McBride <matt@traverse.com.au>
>>
>> The order of these tags is clearly not correct. It says Mathew is
>> sending, but you are not Mathew?
> 
> Just to clarify, Mark has developed this version based off something I wrote a while ago:
> 
> https://gitlab.com/traversetech/ls1088firmware/traverse-sensors/-/blob/master/emc181x/emc181x.c?ref_type=heads
> 
> Hence my copyright is listed in the header.
> 
> I advised him to list the authors in that order following the example in the kernel's "submitting patches" guide [2] which provides an example of such a situation:
> 
> https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

The last entry is:
Signed-off-by: From Author <from@author.example.org>

So it is expected to be Mark.

Best regards,
Krzysztof