Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <da5d1a11-93d4-3952-9a2b-8313b9206660@collabora.com>
Date:   Tue, 8 Aug 2023 14:45:01 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] dmaengine: mediatek: Fix deadlock caused by
 synchronize_irq()
Content-Language: en-US
To:     Duoming Zhou <duoming@zju.edu.cn>, sean.wang@mediatek.com
Cc:     vkoul@kernel.org, matthias.bgg@gmail.com,
        angelogioacchino.delregno@collabora.com, dmaengine@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230806032511.45263-1-duoming@zju.edu.cn>
From:   Eugen Hristev <eugen.hristev@collabora.com>
In-Reply-To: <20230806032511.45263-1-duoming@zju.edu.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/6/23 06:25, Duoming Zhou wrote:
> The synchronize_irq(c->irq) will not return until the IRQ handler
> mtk_uart_apdma_irq_handler() is completed. If the synchronize_irq()
> holds a spin_lock and waits the IRQ handler to complete, but the
> IRQ handler also needs the same spin_lock. The deadlock will happen.
> The process is shown below:
> 
>            cpu0                        cpu1
> mtk_uart_apdma_device_pause() | mtk_uart_apdma_irq_handler()
>    spin_lock_irqsave()         |
>                                |   spin_lock_irqsave()
>    //hold the lock to wait     |
>    synchronize_irq()           |
> 
> This patch reorders the synchronize_irq(c->irq) outside the spin_lock
> in order to mitigate the bug.
> 
> Fixes: 9135408c3ace ("dmaengine: mediatek: Add MediaTek UART APDMA support")
> Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
> ---
>   drivers/dma/mediatek/mtk-uart-apdma.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/mediatek/mtk-uart-apdma.c b/drivers/dma/mediatek/mtk-uart-apdma.c
> index a1517ef1f4a..0acf6a92a4a 100644
> --- a/drivers/dma/mediatek/mtk-uart-apdma.c
> +++ b/drivers/dma/mediatek/mtk-uart-apdma.c
> @@ -451,9 +451,8 @@ static int mtk_uart_apdma_device_pause(struct dma_chan *chan)
>   	mtk_uart_apdma_write(c, VFF_EN, VFF_EN_CLR_B);
>   	mtk_uart_apdma_write(c, VFF_INT_EN, VFF_INT_EN_CLR_B);
>   
> -	synchronize_irq(c->irq);
> -
>   	spin_unlock_irqrestore(&c->vc.lock, flags);
> +	synchronize_irq(c->irq);
>   
>   	return 0;
>   }


Reviewed-by: Eugen Hristev <eugen.hristev@collabora.com>