Date: Wed, 31 Oct 2007 21:50:25 -0700 (PDT)
Message-Id: <20071031.215025.195350296.davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: greearb@candelatech.com, djohnson+linux-kernel@sw.starentnetworks.com,
       linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
       bguo@sw.starentnetworks.com
Subject: Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?
From: David Miller <davem@davemloft.net>
In-Reply-To: <47292A99.5070805@linux-foundation.org>
References: <20071031123359.3954befc@freepuppy.rosehill>
	<4729269A.6090606@candelatech.com>
	<47292A99.5070805@linux-foundation.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 810
Lines: 18

From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Wed, 31 Oct 2007 18:23:37 -0700

> The code in AF_PACKET should fix the skb before passing to user
> space so that there is no difference between accel and non-accel
> hardware.  Internal choices shouldn't leak to user space.  Ditto,
> the receive checksum offload should be fixed up as well.

The hardware has stripped the VLAN header completely and has not
provided it to us at all.

In my opinion trying to cobble one up by hand using the known TAG is
worse than not providing a VLAN header at all.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/