Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp4766544rwb; Tue, 8 Aug 2023 13:32:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEM64Jl02DoEqwFLI+KyyAcFzZ4AcE02rs7ziplk4GizEugqhwXJ496y/kkObBMOZJ/jUVD X-Received: by 2002:a05:6a00:2d89:b0:668:8596:752f with SMTP id fb9-20020a056a002d8900b006688596752fmr683276pfb.4.1691526772713; Tue, 08 Aug 2023 13:32:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691526772; cv=none; d=google.com; s=arc-20160816; b=q1PTp1PrfkP+yKvfsKIKY0PCnH4KHMn9xnLnXQJiaUl5gmWbNlulJTLcRtF8PH8QaE Mx/Xi2toW8Rp/e43EDZuhdpXGqpTISA8hLULJoHprzENP0NMTQvzNbEGFzyk/eEeRv2w sjYVAiXzxBpRNkYU3ZPuGIyeZ2/VsU0pkvyu6ifJnBP4FbWar3UFkdXS16Lu5zk6xGFh Spaw6TrbuftiADy8utxCovu8fOaUeAp/Qjm4B1fgMtdwPtOdRBpSq+2wzcON7Yex9S0f WpvGv9DJDb+Oscw4V2gZ3xchK3AW5m5tojr24C4Ts96B/R1spnoWHINrbDxCK3/+mgRh cJnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=9nUiw4hJK7/Sk678dMlTFdsFNk9UZV8JT6mDURM0k34=; fh=kqFpIKHDkbJvpK3dGZ+YK6To74RZCcll8VeY9E08UC4=; b=WB8CtwNKkJy5WMyfzPuOyilDE9YbXZ9oONsbDNlvfLy9PAMRwW31wjPHIk5QJq1Rxt vwbqPXOlwj25P9XTUSlfgxwRC/0JQoqMtIOcogztMBfBhHXafsC0js+iX7EsTASiC7yp qjvA5oXDhDsRBI5M5uyjo3wdl2TQpw6Z2AwbkfZGV19pbg2YOwHNIIAitqIO3/n4+XkB Ry4EJImiOh8XhM8FroFPDJNkre95CwIfq3eNZ9MBDs6UN4MfgTnhCdAocXgBGeiJke7d L7dQyJLcMm1CS8KvJMzbkfEjCgKc2jaUKaHQm3NuiuFHqyj2TTXoZ2Pl8v83WHLfb1zj PqBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=QZBb0EFg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a11-20020a63d20b000000b0056345699503si435635pgg.2.2023.08.08.13.32.39; Tue, 08 Aug 2023 13:32:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=QZBb0EFg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233744AbjHHTrb (ORCPT + 99 others); Tue, 8 Aug 2023 15:47:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235939AbjHHTrN (ORCPT ); Tue, 8 Aug 2023 15:47:13 -0400 Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C92712260B; Tue, 8 Aug 2023 09:51:09 -0700 (PDT) Received: from relay6-d.mail.gandi.net (unknown [IPv6:2001:4b98:dc4:8::226]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 457BBD4C69; Tue, 8 Aug 2023 08:44:47 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id CDBB0C0011; Tue, 8 Aug 2023 08:44:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1691484284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9nUiw4hJK7/Sk678dMlTFdsFNk9UZV8JT6mDURM0k34=; b=QZBb0EFgqssUT+yAxk29eDTjBMqFKHe4zPB1Smvyc+r9fR/tpmYpbax2btHCBtrJ0JveOQ SLfeDDBlE9c33fmD8j8hb0+2e4T0kQOwo4HkFuefiM4/FTN3Qixx+U9a0Lr46Zpybcvhk/ pzfqXkJVEK6u6AuwEp9In8Fri7fCoasFyYBjwMbGHW2x81o0rcjV7vfIV/7OGspbkZCXS2 UrlV5ZcAPgDJe2OMs4EUsIvewgY6Zd2BHitCnMItMwzgzOZ5eNl6yKxTIuUZMuMRIDLoYX ZPFdIRfr4+fIGi+NiAyTBb1Q6Kip8TN6o7JB9xQlS463pwiOEXmyVfbepPKRoA== Date: Tue, 8 Aug 2023 10:44:39 +0200 From: Herve Codina To: Christophe Leroy Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Randy Dunlap , "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "alsa-devel@alsa-project.org" , Thomas Petazzoni Subject: Re: [PATCH v2 22/28] mfd: core: Ensure disabled devices are skiped without aborting Message-ID: <20230808104439.6265cd01@bootlin.com> In-Reply-To: <651ad095-8753-762e-d3f0-aec74c5794c2@csgroup.eu> References: <20230726150225.483464-1-herve.codina@bootlin.com> <20230726150225.483464-23-herve.codina@bootlin.com> <651ad095-8753-762e-d3f0-aec74c5794c2@csgroup.eu> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Aug 2023 08:13:27 +0000 Christophe Leroy wrote: > Le 26/07/2023 à 17:02, Herve Codina a écrit : > > The loop searching for a matching device based on its compatible > > string is aborted when a matching disabled device is found. > > This abort avoid to add devices as soon as one disabled device > > is found. > > s/avoid/prevents/ Yes, will be changed. > > > > > Continue searching for an other device instead of aborting on the > > first disabled one fixes the issue. > > > > Fixes: 22380b65dc70 ("mfd: mfd-core: Ensure disabled devices are ignored without error") > > Signed-off-by: Herve Codina > > Reviewed-by: Christophe Leroy >