Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <90be12db-6aa5-cb8d-df98-fca3c994e4e8@infradead.org>
Date:   Tue, 8 Aug 2023 08:51:16 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH v3] sparc: Use shared font data
Content-Language: en-US
To:     linux@treblig.org, davem@davemloft.net, sam@ravnborg.org,
        benh@kernel.crashing.org, akpm@linux-foundation.org
Cc:     sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
        mpe@ellerman.id.au, glaubitz@physik.fu-berlin.de
References: <20230807010914.799713-1-linux@treblig.org>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230807010914.799713-1-linux@treblig.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/6/23 18:09, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> sparc has a 'btext' font used for the console which is almost identical
> to the shared font_sun8x16, so use it rather than duplicating the data.
> 
> They were actually identical until about a decade ago when
>    commit bcfbeecea11c ("drivers: console: font_: Change a glyph from
>                         "broken bar" to "vertical line"")
> 
> which changed the | in the shared font to be a solid
> bar rather than a broken bar.  That's the only difference.
> 
> This was originally spotted by PMD which noticed that PPC does
> the same thing with the same data, and they also share a bunch
> of functions to manipulate the data.
> 
> Tested very lightly with a boot without FS in qemu.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

This survives lots of build testing with no problems, so

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> 
> v3
>   Added 'select FONT_SUPPORT' (to stop modconfig causing the font to be
>    linked into a module rather than the main kernel)
> 
> ---
>  arch/sparc/Kconfig        |   2 +
>  arch/sparc/kernel/btext.c | 365 +-------------------------------------
>  2 files changed, 11 insertions(+), 356 deletions(-)

-- 
~Randy