Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp4773336rwb; Tue, 8 Aug 2023 13:41:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFXBJIjcrxG6FTohIJJ0Ru/aBLMEiBExZNd4l13xF8mgP0cIOF794Q7LK6j9femmFUAwwF6 X-Received: by 2002:a17:907:7625:b0:99c:9e84:fbd7 with SMTP id jy5-20020a170907762500b0099c9e84fbd7mr531207ejc.21.1691527282412; Tue, 08 Aug 2023 13:41:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691527282; cv=none; d=google.com; s=arc-20160816; b=xjqV3SdT6aS7hJzoWuYap9omjPyLV5WdyhnY8/n2d3qZDaNOg1NYJKH0SagmjDgoxN s75X7pvdUlSvmGJuupaCZY8hNuIKm+vEWXC2sXNkuBQLk8N2qMj3t295DDdpzaeUTfxo Jj/4tueoOUbk+zYbhxDTd/ixQVbWO9F9IFe7GBDe3/4iGQGcRnH2wQ9oYsfB8qnPZPAS RBial3vyx+0H2C7sT8l7tJzicojZMR6Qzz1ol78I6Lv/qCehcoUELXknzFnpnvkZxJIN iPq+iMfmmnCeQweVq5yBTaLuI/mCMFSQCXBm7ZTYWX2cRqji1HtMGHrRPNg9vwNKJhhB 0q8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=D5tOMi2Z0cR19MTalJt3bKlq65/4prc9uW9uZwhx7ko=; fh=zPOmMl/68beCSc8p95Vd3VtUhtELYPOPcjp5ObP3jV0=; b=QljrI4mXhbLtTa4HKvs31zaSZEFwxzq/PJKUcOT2Hy7WkO0yMxRXoUH7t2SbQ5P5c7 RKwmZwFkAU/PVEZ40pjDtsZwu8aEuMURDHigjV3YD4mQL9b8RuLwgZDNXxL2PEbwo0Wh LcYMMP9SrywAfc6eUgpyJCJ1t8Mga5twQZ1XK1hsg38bzGci8SjTn5ycHJcMB8i7PY7H EsWcFHuwWdXVtcq0XMH1zuR0zy/Jy1oR/rpNBQ7y364x3aokdhN3Q+PGMOEP/bZKgmD3 c4tl5EitUM7DCDXqW8apfTU2u9sKi9soJGJeABTrI6RMGowFq3QvxJijt0lF/CD5aU5G ASJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TiwXfQp8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k15-20020a1709063fcf00b0099bd4572594si7747849ejj.563.2023.08.08.13.40.57; Tue, 08 Aug 2023 13:41:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TiwXfQp8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231634AbjHHUJM (ORCPT + 99 others); Tue, 8 Aug 2023 16:09:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230413AbjHHUIr (ORCPT ); Tue, 8 Aug 2023 16:08:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C05C627EE for ; Tue, 8 Aug 2023 11:41:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E028162A3A for ; Tue, 8 Aug 2023 18:41:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2236AC433C8; Tue, 8 Aug 2023 18:41:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691520065; bh=+f2YihxhO0jWYS9TiQ7dwe3/Y5WOlZkCJXUozzMIN8o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TiwXfQp81mCOTX+fFaQs+SOTfJsofSr468SdjRQtV85L2YcuvTNnoQX2lZ53e5v85 k85N3sWyxQI7nn21CzQajNtkWevT/dXOLvyV/wBCGhDSFQoDObTk+nc+sN2NRkeXsm VQ8qvyp2BkLrZ15kgHRf0Eh0jYRDZcrLOdfzj4eIVEsTLKdqLRHth/QRpRJ3U4CYJ8 jAtiL9CxnfyiDN5+nWFtOyG9wWkZn5+cWjLTsMtPH+wx13Ab+Rhc3wwDQAf2511OSY ubaQAG4KKsRufmhzlnXH91rfTCVKzNIrgx26SmYFUykP4Q/wVMnPabi2AWKIciCquk WjQ/PKTF0oTtw== Date: Tue, 8 Aug 2023 21:40:58 +0300 From: Leon Romanovsky To: Jijie Shao Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, shenjian15@huawei.com, wangjie125@huawei.com, liuyonglong@huawei.com, wangpeiyang1@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 net 2/4] net: hns3: refactor hclge_mac_link_status_wait for interface reuse Message-ID: <20230808184058.GD94631@unreal> References: <20230807113452.474224-1-shaojijie@huawei.com> <20230807113452.474224-3-shaojijie@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230807113452.474224-3-shaojijie@huawei.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 07, 2023 at 07:34:50PM +0800, Jijie Shao wrote: > From: Jie Wang > > Some nic configurations could only be performed after link is down. So this > patch refactor this API for reuse. > > Signed-off-by: Jie Wang > Signed-off-by: Jijie Shao > --- > .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky