Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2c3a9d22-4e7b-ccf9-d43e-8e785401945f@canonical.com>
Date:   Tue, 8 Aug 2023 13:39:26 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH -next] apparmor: cleanup unused declarations in policy.h
Content-Language: en-US
To:     Xiu Jianfeng <xiujianfeng@huawei.com>, paul@paul-moore.com,
        jmorris@namei.org, serge@hallyn.com, mike.salvatore@canonical.com
Cc:     apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230725141239.233372-1-xiujianfeng@huawei.com>
From:   John Johansen <john.johansen@canonical.com>
Organization: Canonical
In-Reply-To: <20230725141239.233372-1-xiujianfeng@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/25/23 07:12, Xiu Jianfeng wrote:
> The implementions of these declarations do not exist, remove them all.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>

Acked-by: John Johansen <john.johansen@canonical.com>

this has been pulled into apparmor-next


> ---
>   security/apparmor/include/policy.h | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/security/apparmor/include/policy.h b/security/apparmor/include/policy.h
> index 545f791cabda..6e5ec9c37b48 100644
> --- a/security/apparmor/include/policy.h
> +++ b/security/apparmor/include/policy.h
> @@ -227,10 +227,6 @@ extern enum profile_mode aa_g_profile_mode;
>   #define profiles_ns(P) ((P)->ns)
>   #define name_is_shared(A, B) ((A)->hname && (A)->hname == (B)->hname)
>   
> -void aa_add_profile(struct aa_policy *common, struct aa_profile *profile);
> -
> -
> -void aa_free_proxy_kref(struct kref *kref);
>   struct aa_ruleset *aa_alloc_ruleset(gfp_t gfp);
>   struct aa_profile *aa_alloc_profile(const char *name, struct aa_proxy *proxy,
>   				    gfp_t gfp);
> @@ -239,14 +235,12 @@ struct aa_profile *aa_alloc_null(struct aa_profile *parent, const char *name,
>   struct aa_profile *aa_new_learning_profile(struct aa_profile *parent, bool hat,
>   					   const char *base, gfp_t gfp);
>   void aa_free_profile(struct aa_profile *profile);
> -void aa_free_profile_kref(struct kref *kref);
>   struct aa_profile *aa_find_child(struct aa_profile *parent, const char *name);
>   struct aa_profile *aa_lookupn_profile(struct aa_ns *ns, const char *hname,
>   				      size_t n);
>   struct aa_profile *aa_lookup_profile(struct aa_ns *ns, const char *name);
>   struct aa_profile *aa_fqlookupn_profile(struct aa_label *base,
>   					const char *fqname, size_t n);
> -struct aa_profile *aa_match_profile(struct aa_ns *ns, const char *name);
>   
>   ssize_t aa_replace_profiles(struct aa_ns *view, struct aa_label *label,
>   			    u32 mask, struct aa_loaddata *udata);