Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 8 Aug 2023 12:37:55 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Lin Ma <linma@zju.edu.cn>
Cc:     corbet@lwn.net, void@manifault.com, jani.nikula@intel.com,
        rdunlap@infradead.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] docs: staging: add netlink attrs best practices
Message-ID: <20230808123755.43610137@kernel.org>
In-Reply-To: <20230808035636.148552-1-linma@zju.edu.cn>
References: <20230808035636.148552-1-linma@zju.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue,  8 Aug 2023 11:56:36 +0800 Lin Ma wrote:
> Provide some suggestions that who deal with Netlink code could follow
> (of course using the word "best-practices" may sound somewhat
> exaggerate).
> 
> According to my recent practices, the parsing of the Netlink attributes
> lacks documents for kernel developers. Since recently the relevant docs
> for Netlink user space get replenished, I guess is a good chance for
> kernel space part to catch with.
> 
> First time to write a document and any reviews are appreciated.

Oh, you put quite some effort into this!

I have a hard time coming up with reasonable review comments, because
while the doc is informative and pretty correct, it focuses on what's
legacy use of netlink at this point. People writing new code will only
get confuse with this information :(

Modern families are all generic netlink, and validation is taken care
of in the core :(

If you post a v2 please make sure to CC netdev@