Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Cc:     andrew.cooper3@citrix.com, arjan@linux.intel.com, jgross@suse.com,
        linux-kernel@vger.kernel.org, mikelley@microsoft.com,
        pbonzini@redhat.com, peter@keresztesschmidt.de,
        peterz@infradead.org, thomas.lendacky@amd.com, wei.liu@kernel.org,
        x86@kernel.org, qiuxu.zhuo@intel.com
Subject: Re: [patch V3 45/60] x86/apic: Sanitize APID ID range validation
In-Reply-To: <20230808133407.10901-1-qiuxu.zhuo@intel.com>
References: <20230801103817.624346203@linutronix.de>
 <20230808133407.10901-1-qiuxu.zhuo@intel.com>
Date:   Tue, 08 Aug 2023 20:55:15 +0200
Message-ID: <87msz1l5yk.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Tue, Aug 08 2023 at 21:34, Qiuxu Zhuo wrote:
>> From: Thomas Gleixner <tglx@linutronix.de>
>> ...
>> Subject: [patch V3 45/60] x86/apic: Sanitize APID ID range validation
>> Now that everything has apic::max_apic_id set and the eventual update for
>> the x2APIC case is in place, switch the apic_id_valid() helper to use
>> apic::max_apic_id and remove the apic::apic_id_valid() callback.
>> 
>
> This patch removes default_apic_id_valid() and all references to it.
> So may also need to remove the useless declaration of
> "extern int default_apic_id_valid(u32 apicid)"
> from arch/x86/include/asm/apic.h?

Yes. Seems I missed that.