Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 8 Aug 2023 16:37:35 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Yazen Ghannam <yazen.ghannam@amd.com>
Cc:     "Limonciello, Mario" <mario.limonciello@amd.com>,
        linux-edac@vger.kernel.org, hdegoede@redhat.com,
        markgross@kernel.org, platform-driver-x86@vger.kernel.org,
        "Luck, Tony" <tony.luck@intel.com>, linux-kernel@vger.kernel.org,
        avadhut.naik@amd.com
Subject: Re: [PATCH 1/2] platform/x86/amd: Introduce AMD Address Translation
 Library
Message-ID: <20230808143735.GDZNJTL0DlJd3225db@fat_crate.local>
References: <20230802185504.606855-1-yazen.ghannam@amd.com>
 <20230802185504.606855-2-yazen.ghannam@amd.com>
 <58934edf-4fad-48e0-bc5d-62712b11e607@amd.com>
 <894b3737-1a0a-4139-9c73-686a95481795@amd.com>
 <B3BE6B56-FBAB-4878-A45D-E95AFAC86AB1@alien8.de>
 <f989cd56-a066-409a-8d82-40d0bc6ff89b@amd.com>
 <20230808142007.GCZNJPFy8PqTJgTAN5@fat_crate.local>
 <a62282e0-3784-4d96-b632-fdd6d2627ca3@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <a62282e0-3784-4d96-b632-fdd6d2627ca3@amd.com>
Precedence: bulk

On Tue, Aug 08, 2023 at 10:28:51AM -0400, Yazen Ghannam wrote:
> Because this isn't intended to be only for MCA errors. The translation code
> is related to the AMD Data Fabric. And it'll be a common back-end for memory
> errors coming from MCA and CXL.

But EDAC is not only about memory errors. Why not extend this into
something which does other RAS functionality instead of doing a second
one which is more or less related?

mce_amd is already loaded on the system, why add a second module if it
can be part of the first one just the same?

Strictly speaking, this all should've been drivers/ras/ from the very
beginning and all EDAC should move there but that's going to be madness
to do now.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette