Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230808032510.31754-1-luke.lu@libre.computer> <2023080851-duh-scroll-09bf@gregkh>
In-Reply-To: <2023080851-duh-scroll-09bf@gregkh>
From:   Luke Lu <luke.lu@libre.computer>
Date:   Tue, 8 Aug 2023 06:09:45 +0000
Message-ID: <CAAzmgs5U=BNzNNeskUMe_YEken1-CmzssRFPDCmsmar9SQo+WQ@mail.gmail.com>
Subject: Re: [PATCH] usb: dwc3: meson-g12a: do post init to fix broken usb
 after resumption
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Neil Armstrong <neil.armstrong@linaro.org>,
        linux-usb@vger.kernel.org, linux-amlogic@lists.infradead.org,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Da Xue <da@libre.computer>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

HI Greg:

On Tue, Aug 8, 2023 at 4:56=E2=80=AFAM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Tue, Aug 08, 2023 at 03:25:10AM +0000, Luke Lu wrote:
> > Device connected to usb otg port of GXL-based boards can not be
> > recognised after resumption, doesn't recover even if disconnect and
> > reconnect the device. dmesg shows it disconnects during resumption.
> >
> > [   41.492911] usb 1-2: USB disconnect, device number 3
> > [   41.499346] usb 1-2: unregistering device
> > [   41.511939] usb 1-2: unregistering interface 1-2:1.0
> >
> > Calling usb_post_init() will fix this issue, and it's tested and
> > verified on libretech's aml-s905x-cc board.
> >
> > Signed-off-by: Luke Lu <luke.lu@libre.computer>
>
> What commit id does this fix?
Using "git blame" to explore the history, found dwc3_meson_g12a_resume() wa=
s
introduced along with the file of drivers/usb/dwc3/dwc3-meson-g12a.c.
as Da Xue pointed out, the suspend/resume was never tested in GXL based SoC=
,
so it's broken since the beginning..

For the Fixes tag, I think it's proper to use "5b0ba0caaf3a: (usb:
dwc3: meson-g12a: refactor usb init)"
since the usb_post_init() function was introduced in this commit and
this patch will depend on it.

> Should it also go to stable kernels?
>
Yes, It would be great if the patch can go to stable tree, thanks for
suggesting this
I have it tested on 6.1-lts tree.

Btw, I would wait for a few days for more comments and CC to stable in
next v2 if no objection.

> thanks,
>
> greg k-h

Luke