Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp4841286rwb; Tue, 8 Aug 2023 15:03:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHU5Yiky3IUBmfEZu+viGt7anPMTHRVlbytlK4pgPJjNqLqHe6bY5saoWvFaev9watotRLP X-Received: by 2002:a17:907:728e:b0:966:1bf2:2af5 with SMTP id dt14-20020a170907728e00b009661bf22af5mr11630686ejc.22.1691532184321; Tue, 08 Aug 2023 15:03:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691532184; cv=none; d=google.com; s=arc-20160816; b=zAgjWN+YHVMCm2rWp1iXxW63JQVt8r73bm+Lm8hIlCLGkuhM6rU937p6EzQcyyYbhf 9GenNL3CwzRqToc3GJ7cB0tJbMcobrsf5QeIHopWBngDjc99N8K+9F0WLdISwtsS2R+l Z4a9lVSHSemt+6dFaNg9v/hFkSkYxA5yXJd120SSXeLJSphCi9+kK/zK8+xlIzIigtck 8H5+nOufc7ehPyxu0cQ+XLNASAtNrrRAL5xYYaSlxueaxanfmkygcKnyMo1sndojV8oq pNBNAWabxKlX34UTVh5c4BwDhCj16Hncp2iLVPuuSnPz5TFEDb6/As3IkdHGsuJdkKTd BtAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tVIKy6MjP7aJ60ve3vfR8RU35LW2l7/9U5Sif9WffWM=; fh=zG6/xcfX3iL0lf31dUpTWPk2aFZKgBJUYluWZE1WaR4=; b=Yxxt77y+2aOpsMpjQwfRTjdQM/34Xm0w+4ocpQThwXTBKCZFLktkqObiPpY+xtIGoz asB7WU0xHjhO79MoiaWQ6vBdf+Uc7ef81nXSywssdtxwZGip/+qT19231Lsmd3xSAc86 oIquWjs47f/6NLRO66XMqX72nSvAOOhbGy/lidQGMCqtjOmx51UIACOqS23FFmKqMaBm HKZMyar34S4Z1dO6mQrw2urrN4FQAkEofpTjXoTeikf7J8aPYbbDJTEbeNP6c+byPOJA 9CcBA8InS/UK7xLM9bevMcb+duXzQjFPTJXthapyR8f1h+ZIIRlWcyfCW2N3F2oealsY 9xJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eP3OhvsF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g23-20020a170906c19700b00992a36ceca1si8674230ejz.35.2023.08.08.15.02.39; Tue, 08 Aug 2023 15:03:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eP3OhvsF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233156AbjHHUeI (ORCPT + 99 others); Tue, 8 Aug 2023 16:34:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232460AbjHHUd4 (ORCPT ); Tue, 8 Aug 2023 16:33:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5DB61BAFD for ; Tue, 8 Aug 2023 12:59:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3275562BFF for ; Tue, 8 Aug 2023 19:59:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8D7FC433C8; Tue, 8 Aug 2023 19:59:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691524755; bh=vaL2GmK6E30etgPK/7amdzCna9Tu7rMpzE4Hc5iSZ1Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eP3OhvsFV740uKM4wAelsA49oWXmvK9xYJHKORXwcTkDrSeQp+Xdqc/mvhWuQMbZg pu3WzPRtCxrVoaon4argOZWH/7Gf3fPWD7R1e9/pGriWEboaYGN7O87Hoc1zt5Gp42 AawQxcbbq9OdbOM/KhVTxNnezvS1Yvj4jDQG5pHdiukdD6ciNEfVwRLAz0TtC/Eh+L 6aChhUkEzYBezywSBFJikE0og6LXAYWNCZm/4DOCxbbLK8ZblLQcJHp7FNYjIJb1EB Ijsei8Gve7vDojv3odcpuWgr1J7hDyOWCJranWmKVDFGKtyoh1f8SmhsAXFWptXGt1 vxn8Hd0urihmA== Date: Tue, 8 Aug 2023 21:59:10 +0200 From: Simon Horman To: Furong Xu <0x1207@gmail.com> Cc: "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , Simon Horman , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Subject: Re: [PATCH net-next v2 1/1] net: stmmac: xgmac: RX queue routing configuration Message-ID: References: <20230808021906.1120889-1-0x1207@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230808021906.1120889-1-0x1207@gmail.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 08, 2023 at 10:19:06AM +0800, Furong Xu wrote: > Commit abe80fdc6ee6 ("net: stmmac: RX queue routing configuration") > introduced RX queue routing to DWMAC4 core. > This patch extend the support to XGMAC2 core. > > Signed-off-by: Furong Xu <0x1207@gmail.com> > --- > Changes in v2: > - Convert the shift ops to FIELD_PREP Thanks! FWIIW, I think if the code moved to using FIELD_PREP then probably the _SHIFT defined can be cropped. Reviewed-by: Simon Horman