Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp4848956rwb; Tue, 8 Aug 2023 15:10:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFfzqavdcl0V2vZm6EzcO4F2nByzKLLJXnTCnEKdGa1inlRS+dN1pampZ855Pk3oBr9SyfE X-Received: by 2002:a17:906:1ba1:b0:99b:f392:10b2 with SMTP id r1-20020a1709061ba100b0099bf39210b2mr617103ejg.39.1691532607943; Tue, 08 Aug 2023 15:10:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691532607; cv=none; d=google.com; s=arc-20160816; b=wnhfkR5DycHDEwDgcd2s9U+tahFkFmR9ieKgNjF6RDNayH3ovIU/KP6p4mEabIIkbJ yk04ceghv0JGQki1KZts7jiRkgXWNVVvyZUqp7pfBISgDW1uo1asOcOAGJEKZ7p7M+BV rEN2OLv/fDEWlq6/cvCKAlNt5o4nwk8EnNG0/SG/ApnEFHg5FoPaUr41SuvhbOsOgKqk ALJjYaSmeeALJ0NeWL9INgZ9btvvYFirjzibc/3xiPJvX+QL3OuhTEXI9PptO2cBXESH w593Ho99lYai7TuRGJiGVryLOna7K3Mqp2pq3NYNEYYzvc6uW5qD/C9flOauLRIfSUtS +6Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=7bw2MRgpkFm1vILiE0Y5MYyZNNxscMVN+eqSvqqHwK4=; fh=yrD7Y9M3JbTlrkncnsixCKz/YOK0zp8mUc4u1guxmrs=; b=H826+WWbpG9YIUxDka3A5UO/Joh/AiXO3FHwetCEDvC/2Or/spN7qDZwHrnfvHEFP7 PyOcdzHPkCz/zVmYQK9THy7ty3uMtG+pvO7h7Hf/W8isTpRUYkQQeaaSgApoogddxKL4 0B4Gx+C63lCaZl4J0AMIQyJz+Sl0G0/Gxbh6PQh8QvfyICYSKPmTv6BxoKfautqy0I3/ 5hKpUmFw8REa+nctMWlj1cKY3xngYLB6fVFnGlUKQVpFASksuAhCQzRiHyPU2GDp7Foy +rHK58+dwff2ujY5la1wry1anWZM0/+o/94fG+g9bZhZTcznjLnn/OwgqvgAidCB0cy8 lUww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@isovalent.com header.s=google header.b=EePW+ss0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=isovalent.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o5-20020a170906358500b00992d2630d08si7690322ejb.788.2023.08.08.15.09.42; Tue, 08 Aug 2023 15:10:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@isovalent.com header.s=google header.b=EePW+ss0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=isovalent.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234189AbjHHSpB (ORCPT + 99 others); Tue, 8 Aug 2023 14:45:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231847AbjHHSoW (ORCPT ); Tue, 8 Aug 2023 14:44:22 -0400 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 896BF3CD00 for ; Tue, 8 Aug 2023 09:41:38 -0700 (PDT) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-99c1c66876aso816979666b.2 for ; Tue, 08 Aug 2023 09:41:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent.com; s=google; t=1691512570; x=1692117370; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7bw2MRgpkFm1vILiE0Y5MYyZNNxscMVN+eqSvqqHwK4=; b=EePW+ss015g11YgFFHMy90Z5WBj/PCKy6a/lhF3ExOntSwvl8wOFfJQ1JbeQoQrrOx xGv9mUGakIoi++O8fmZPptc9lYFC2bKDg9uXW/+1Mxi9bbiHs3cBrG5MKCqPjOigSNk/ 6O3T2Scei8koWcY2M/Eaj3ZH5HH0kvS2OwUipqKRF44XHNPvdm7NRKse4GbRIsRU3CNw MHRQ4gStC0CIZh/3TmsijzYoIO2grgcREPRoC80135uNlMXE9RheTTzhehwkkqfMOILw IG+BZkUNI0ZVxYlQC6LMviOYgjd4hQSn16di8r9dqB6kv/iUsDpTXsLNS+LLy0b/jFrX XBlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691512570; x=1692117370; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7bw2MRgpkFm1vILiE0Y5MYyZNNxscMVN+eqSvqqHwK4=; b=OcKaT28zpA/VX1Qqs5brYjn9RRyXjznE1pXkW9Ysu8IcKFTjDXJSTdaQGtQlUKuAyp YB8nATh0sRmKQ9qdylEGr81GIFVg4OCMMwPmc6HAq5HaHUerUghs08BuBHR0WHI+YwYH jfaghMSHDX8p5gRDNZHIKfmqlACg2gd7h3x9kgRZtX0srgFuiXmN9PUHdLF2FH+at759 naJAaf0OBD1fS+Folg87Pl4qnKBRKEZWk17O6ccVpAXq6snweswuoJaT/q8pKFz1PfWq AcdmcuA1w+JecGsXLKCCIb0tFPrnsDWg7VbdsNqbjZZuAxuaEK5zs+4pzJeQg0lpkdAX GqtA== X-Gm-Message-State: AOJu0Yz/wQge3rprcvm8M3yrSFiBV1eHJsqBIHKrkBWX2OqN8F8q4XAx bVBjy5qubEZULC747WRa9Ba44n8nzyTAG0YYNNIvmQ== X-Received: by 2002:a17:906:217:b0:98d:4000:1bf9 with SMTP id 23-20020a170906021700b0098d40001bf9mr85402ejd.65.1691512570147; Tue, 08 Aug 2023 09:36:10 -0700 (PDT) MIME-Version: 1.0 References: <20230720-so-reuseport-v6-0-7021b683cdae@isovalent.com> <20230720-so-reuseport-v6-7-7021b683cdae@isovalent.com> In-Reply-To: From: Lorenz Bauer Date: Tue, 8 Aug 2023 17:35:59 +0100 Message-ID: Subject: Re: [PATCH bpf-next v6 7/8] bpf, net: Support SO_REUSEPORT sockets with bpf_sk_assign To: Kumar Kartikeya Dwivedi Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Ahern , Willem de Bruijn , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Joe Stringer , Mykola Lysenko , Shuah Khan , Kuniyuki Iwashima , Hemanth Malla , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Joe Stringer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 8, 2023 at 5:23=E2=80=AFAM Kumar Kartikeya Dwivedi wrote: > > Hi Lorenz, Kuniyuki, Martin, > > I am getting a KASAN (inline mode) splat on bpf-next when I run > ./test_progs -t btf_skc_cls_ingress, and I bisected it to this commit: > 9c02bec95954 ("bpf, net: Support SO_REUSEPORT sockets with bpf_sk_assign"= ) Thanks for the report. I forgot about struct request_sock again... I'll have a fix shortly, I hope. Lorenz