Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 8 Aug 2023 10:28:28 +0200
From:   Marek =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        linux-gpio@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>
Cc:     linux-kernel@vger.kernel.org
Subject: regression from commit b0ce9ce408b6 ("gpiolib: Do not unexport GPIO
 on freeing")
Message-ID: <20230808102828.4a9eac09@dellmb>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

the commit b0ce9ce408b6 ("gpiolib: Do not unexport GPIO on freeing")

  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b0ce9ce408b6

causes a regression on my mvebu arm board (haven't tested on other
systems), wherein if I export a GPIO to sysfs and then unexport it, it
does not disasppear from the /sys/class/gpio directory, and subsequent
writes to the export and unexport files for the gpio fail.

  $ cd /sys/class/gpio
  $ ls
  export       gpiochip0    gpiochip32   gpiochip512  unexport
  $ echo 43 >export
  $ ls
  export       gpio43       gpiochip0    gpiochip32   gpiochip512
  unexport
  $ cat gpio43/value
  1
  $ echo 43 >unexport
  $ ls
  export       gpio43       gpiochip0    gpiochip32   gpiochip512
  unexport
  $ echo 43 >unexport
  ash: write error: Invalid argument
  $ echo 43 >export
  ash: write error: Operation not permitted

Marek