Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <091884b4-d479-9b24-013c-8d5dd9eb4ecd@amd.com>
Date:   Tue, 8 Aug 2023 11:29:20 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v6 7/8] x86/resctrl: Introduce "-o debug" mount option
Content-Language: en-US
To:     Reinette Chatre <reinette.chatre@intel.com>, corbet@lwn.net,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc:     fenghua.yu@intel.com, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, daniel.sneddon@linux.intel.com,
        sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        bagasdotme@gmail.com, eranian@google.com,
        christophe.leroy@csgroup.eu, jarkko@kernel.org,
        adrian.hunter@intel.com, quic_jiles@quicinc.com,
        peternewman@google.com
References: <168980872063.1619861.420806535295905172.stgit@bmoger-ubuntu>
 <168980893967.1619861.7249871216790436466.stgit@bmoger-ubuntu>
 <68d6d4a4-80e4-2aa5-409f-0e2744c20e88@intel.com>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <68d6d4a4-80e4-2aa5-409f-0e2744c20e88@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWxQUVJHUTduMFRYenIrNm4xSnRuZWwzaXo4NEZxQ2I2cXZacjU2M2pvRnh5?=
 =?utf-8?B?QkJjMEFINk4vdXBTdlUzUjZXanJwb3A5ZnJOK1AzZHNHU2M4aTRXbjVDN1Vv?=
 =?utf-8?B?dFhFTGRuS3c5cm9vbjJsU3VmMU1GalpnTHQ5UFZPZkpiNExDWVBRTy9lU0ZU?=
 =?utf-8?B?NE1BdzQ2aFJnWXJWTGdRS0lBZ1BBK21hT3I4MmxqMWNsRlNLWDd5VXM3T0Fr?=
 =?utf-8?B?WVRBc1JFVTlHOERHNE1ESGNhTGtqWWVDbldHM29ybzFiVEVPWHdZSW5ha0s1?=
 =?utf-8?B?djBLdzZXZXVXZXNUT2RGcjg5aW03QVQzcGYvQSt0WjZjbkNObzQ2KzN6NS9n?=
 =?utf-8?B?ZTVNS3dQZTUrckFzSGhPL09xNTB3dS9mR3JCWjFybTYvM1o3Tmp3U2paeXNY?=
 =?utf-8?B?Q0tiQm1mTGZhZFo5YVVEUi83eVNIS2FkMUdVMG9GRmFsZjIwcVlvZmUvTDJT?=
 =?utf-8?B?dU5qMFN0U3BjaUpCd3crektBWjlFMS9iY2dDOEVRVmsxa2YvVUNFZVU4dSsv?=
 =?utf-8?B?NlRSdUkvZ0x3MEcrMjBPbUpmTkhGVXVpdDl3aThiSm9YZlNYc09KOVBNaVl6?=
 =?utf-8?B?Z0RPT2NzTldjUVdPaExlZ3ladGJqR25CNzMyU0Foc3hBUnhsWllTeVlad0t0?=
 =?utf-8?B?UktUWFU4TUpjSEZmemZKZDN3WXJLMk1MdkNXeG14TVhRTjFWOXZpM2lrY2tF?=
 =?utf-8?B?SWVxZ2lSVDBZSmo0Z3N3c21IMlM1S1ArU2ZwajlhZjVlTTFzeGU4Rkg1UlIy?=
 =?utf-8?B?UjZjYlFLLzJKeFBZWDlldzd0ZFZWRmRNaFgvOXJGenNld0pDYkRhMnphMjBX?=
 =?utf-8?B?NWM0ZjQzODNsNzdLVFlLY1RYa1Z2azcxUytOZXNTRTloVGxNSngrR3Fqd25Z?=
 =?utf-8?B?aFcwYlBQVjA5ZkRzaFZWdmxHTmFuUjE1bmxKcUpQaHZwaDUySEJsUGZtRzI1?=
 =?utf-8?B?VHVHZlAyczNkVnhUYmxPcFpvamY3T0NsVHF6ZlJLL3Vta25GbGhtb1VkV0oy?=
 =?utf-8?B?c0c2WmFlNVMwMXdrUHBOclBqMFVlM2FCWEl5b05XdWk3WXJyM1A3T21qSVZ3?=
 =?utf-8?B?Mzh0aTVaM3BNUUZmY1BoQlBvK0U3QnAzWEZSUmFUOEhzMDVucXp0R3RBWFI4?=
 =?utf-8?B?cnluamJLK0FuS0lPUTdsWXJnMXBOTUZQSnF2RDhUbDZZOUxlSUxYZzVwUHRa?=
 =?utf-8?B?SDVwdnRXSzFpdGtKZ3VReVY3SzNSc2VydXF5aE1XeGc3NXVDMGlTakZoemhz?=
 =?utf-8?B?d3B1VlNQQ2RIVS9VV0c2dHJOSGtFeGFUajR2VmZFbzFsY2hiWW5BZUV0SExZ?=
 =?utf-8?B?ZVh2VkV5K3hwL2gxTXhJU2hidVlkMFhIWHc2ZitKVUN6NElrM1craG13TkNQ?=
 =?utf-8?B?Ri9xMndoclphMTl2bDlJV3J2SDdKSFZOblVYdWFRMDZubVJxRld2aEZsd3JH?=
 =?utf-8?B?dVNtMGlWbldzaUJNTkJDR3QrUkNOUWE0ZDA4WldqZ2tIZEQ1RVNlOGpqbFdt?=
 =?utf-8?B?blJ3RjVUU1VaaWhDalJSU2RLSWVtbTJ0akRZMkVzY2hFb0RsTU0yRmRWdlN1?=
 =?utf-8?B?VjNNcG0xL1ZmM3lIWTMyRXgzem9YMnhuYml2RFNVZ05lajRETHcrQklNMXZp?=
 =?utf-8?B?RXZvaUY4a2I0eFg2bHpvOTdjcGlpOHR0NGNiN1J6SmQxcVBFSWF4SEp5bEdU?=
 =?utf-8?B?VStNcWxzamdjUTEvSVJSbFdSUWlWaEY5K3F6YWN2T2JBMzhtSUFNSDJQTGlo?=
 =?utf-8?B?anNwYlBUVkV3akxIdHluY05UY1hIdXZYSnAybSsvdUJJUDBvdzVQeWgyTFJh?=
 =?utf-8?B?aXpjNlRBYXZwNC9ISE1RWkoxVTV1NTNFbTZqTHB4YllyMExaTFBhelRsM2tx?=
 =?utf-8?B?a1JQTWVkV1RVNTRkbXdRZksvNDZVR1RuM3NFTFNKVmVIRjQyaUw2UUNxblRW?=
 =?utf-8?B?UEM0MlNON0ZvUXVPNDBHcFVkR3hiM2FZaUd1QmxiV1drY0ZISFdReGY0RStM?=
 =?utf-8?B?b0dxbTM3aldiQjBLTFhuVnVLaWZSdmwyVXh2cWtKa084eWtPTFArZ1Q3TWdS?=
 =?utf-8?B?UnVQdUVhaktWNnkzTm1qUnJBbDNYZ1ArR1pJSmN6WjJWbVk0U1A4M2krWWtW?=
 =?utf-8?Q?Rrog=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5e8054d-3960-4f15-1309-08db982ca073
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 16:29:24.3211
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bdE6NNr/5PIRBN3aUPV9a+Z9CZmeWZDeh5dBhLpPUGwwe6C9nW4m/OYnkz+OLEbo
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9452
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,SPF_HELO_PASS,SPF_NONE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Reinette,

On 8/4/23 15:42, Reinette Chatre wrote:
> Hi Babu,
> 
> On 7/19/2023 4:22 PM, Babu Moger wrote:
>> @@ -2591,6 +2599,8 @@ static int rdt_get_tree(struct fs_context *fc)
>>  out_schemata_free:
>>  	schemata_list_destroy();
>>  out_ctx:
>> +	if (ctx->enable_debug)
>> +		resctrl_debug = false;
>>  	if (ctx->enable_mba_mbps)
>>  		set_mba_sc(false);
>>  	cdp_disable_all();
> 
> These changes are a red flag to me. Developers still need to
> do what patch #4 was aiming to prevent.

I think you meant patch 5 (x86/resctrl: Unwind the errors inside
rdt_enable_ctx).

I can take care of this unwind part in rdt_disable_ctx() and call it here.
https://lore.kernel.org/lkml/9fd70ef3-ca90-65e3-4746-7d574bdd159b@intel.com/#t

Hope that is what you meant.

-- 
Thanks
Babu Moger