Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp4871431rwb; Tue, 8 Aug 2023 15:38:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHly+0gdfw59kmp9nlac25IHXQqQcX8/uVnpYDKp51R1z63rrrFwx7W5UKIeL/FJxlKnLCO X-Received: by 2002:a05:6a21:2724:b0:127:76ab:a707 with SMTP id rm36-20020a056a21272400b0012776aba707mr801357pzb.30.1691534286224; Tue, 08 Aug 2023 15:38:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691534286; cv=none; d=google.com; s=arc-20160816; b=EPSA/zan+pORgd0CAC7Gm8/HMi0VXG/ok3DmPpuCTkJ5pCJSwWb43iZKAd8bMsgLxs xJ8JGErdpwu/+Eme6QuJrh+SqM63/e8Ssr9o11XJ5xos+N3gFJPufoLDPUtpaH1DaGdE TIU4JRD94K+aUII/6ogSx4BdDcOVPbv3AACGbTE0HhWVAg+3Zbw542YNYDHSg/YaYz1o quQexOo+nMOGwsrM5Pa8QnJbpci0H2GhyXjVm0tfqboo4GyS4ztR6FStnvr7zjqb5YNH 9Cm/AtmLQfpANCuVf0b3zS4cpNq23fZHvhIwEf3L3EzCe12Q6ns7kChSuQlVTeUJyq32 h+kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=e5Kq1LJc+7Xua2Kq4jL8Y3azeq9CaYf9ma2OpUQOoes=; fh=dIVXBOOnArBJY8Fm3omL5qhbRR7wBFNyTfYhv33+TBo=; b=kCO7FoW4XMG0w1YZklUXfCy6pbI275Aw3vPyKCy53c5vMuABy+oXR5L41V7Jj4wh3P Ra3nmrskR3BCWeqUclOQCAmEu+HIYVigyFdAFmPfWA6UuBy80Erp3E86D7+jasWlzvil t/lOUELsVzBpOWUQ0ZRj2CxdaqbuyB891JrXZFieT8GcitzcSgIYN7C6BV0owmFYP5g+ loVZw2DpX5r+euqfx8Rc0xn/ZmtWWRE1+w37OLZQ9RFuoSOBZitxW8P10zXlR9ytQ3a0 KpJqewmcY0d8sRRdd8FR7NGczB6nImwRH8VSZMu/L8yp1d1nvtXhP4wNvXU94pzl9B3I 4ZoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=be1D7x5H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y16-20020a056a00191000b006875bd6d8d9si7881392pfi.169.2023.08.08.15.37.54; Tue, 08 Aug 2023 15:38:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=be1D7x5H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234723AbjHHUNF (ORCPT + 99 others); Tue, 8 Aug 2023 16:13:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234636AbjHHUMs (ORCPT ); Tue, 8 Aug 2023 16:12:48 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 346C235C65 for ; Tue, 8 Aug 2023 11:43:30 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-2685102cd16so3256090a91.1 for ; Tue, 08 Aug 2023 11:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1691520209; x=1692125009; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=e5Kq1LJc+7Xua2Kq4jL8Y3azeq9CaYf9ma2OpUQOoes=; b=be1D7x5HcJqbJr27O9QIV9joDE3vudd1QIP8F4Qgp4v2bIvgL98wvF67K8ptum1zM2 rVcVlh0E9HVHGLUq0+J8M8cOP1JhiobRwtXpij1/CVCLwuDLT7bzIzY2/aOD4ne8lf9k 7pCgsClRPSqKYWjp5s9RKFzKoygpeelVphLGe1NAcNrjZL98IrObDkQ9HoPqTSAqn/Nx R+a48BRECFN1JYwlMmbLUgBF7Ux/Z4kpdO3jWANdx5bINZyb6UQkvIzVR8lyDgalWF+Q rBZ6jyci9piCzF3KNNqc7ARsHaNSlDYNmR1odClyIV95XJDZ/zmL6NWmvkQMrzYdgbiK wOQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691520209; x=1692125009; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e5Kq1LJc+7Xua2Kq4jL8Y3azeq9CaYf9ma2OpUQOoes=; b=Yn2zh78fc2UcqnDWpO5Ka1zZUFYZlQcdTX3BHMOk68pKYAwuCM//Aq9FhpqoL631+q Q05Zf/jouXK90jlsyHhmUzEgp8xK/GjA6vAIBli7iQyJLMwUgHY0uFtqg/Wl5J2x2oBd qOHHJm+VzERR6BChefL/S/wvfUFre4KGdY+B8UILiyhT/aWQdRQSmTJKpqcS5LFQf4EI KobqETsPImWgIBkqFfKJXQ3eoFu/khawAJrpl7zZjBFH2QJSOJHpsfYNFgmbjicNAn9i Ar12A9+9oxgxZRQQ7n9oeUm+L2nsHFiLnjQCFF+iRO8huoX0MMT9aUqaAYfr56mVR4Tb jNeQ== X-Gm-Message-State: AOJu0YyUg6S8RAvZJ0nP+jkCmjBXXFc4+GetZqwSkg+JSlAeXgs2zOTV 8h1JkminctaMwSUqG/83XDlGhQ== X-Received: by 2002:a17:90a:7e12:b0:25e:d303:b710 with SMTP id i18-20020a17090a7e1200b0025ed303b710mr329838pjl.35.1691520209601; Tue, 08 Aug 2023 11:43:29 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id n7-20020a17090a394700b0025c1cfdb93esm8968536pjf.13.2023.08.08.11.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 11:43:29 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qTRfz-004vcj-KZ; Tue, 08 Aug 2023 15:43:27 -0300 Date: Tue, 8 Aug 2023 15:43:27 -0300 From: Jason Gunthorpe To: "Tian, Kevin" Cc: Lu Baolu , Joerg Roedel , Will Deacon , Robin Murphy , Jean-Philippe Brucker , Nicolin Chen , "Liu, Yi L" , Jacob Pan , "iommu@lists.linux.dev" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 08/12] iommu: Prepare for separating SVA and IOPF Message-ID: References: <20230727054837.147050-1-baolu.lu@linux.intel.com> <20230727054837.147050-9-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 03, 2023 at 08:16:47AM +0000, Tian, Kevin wrote: > Is there plan to introduce further error in the future? otherwise this should > be void. > > btw the work queue is only for sva. If there is no other caller this can be > just kept in iommu-sva.c. No need to create a helper. I think more than just SVA will need a work queue context to process their faults. Jason