Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 8 Aug 2023 10:38:48 -0700
From:   Andi Kleen <ak@linux.intel.com>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Ian Rogers <irogers@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
        Claire Jensen <cjense@google.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf stat: Don't display zero tool counts
Message-ID: <ZNJ9qBoBt2spEy4Y@tassilo>
References: <20230801205452.3380578-1-irogers@google.com>
 <ZMwUI/YtEHsO3Cc8@kernel.org>
 <ZNEFt3w/wNCvdawF@tassilo>
 <ZNFJatDztFNS90d3@kernel.org>
 <ZNFMqzSAfno/+BcV@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZNFMqzSAfno/+BcV@kernel.org>
Precedence: bulk

On Mon, Aug 07, 2023 at 04:57:31PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Aug 07, 2023 at 04:43:38PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Mon, Aug 07, 2023 at 07:54:47AM -0700, Andi Kleen escreveu:
> > > On Thu, Aug 03, 2023 at 05:54:59PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > Em Tue, Aug 01, 2023 at 01:54:52PM -0700, Ian Rogers escreveu:
> > > > > Skip zero counts for tool events.
> > > > > 
> > > > > Reported-by: Andi Kleen <ak@linux.intel.com>
> > > > 
> > > > Andi,
> > > > 
> > > > 	Have you tested this? Can we please have your Tested-by?
> > > 
> > > I thought I had sent it earlier?
> > > 
> > > Tested-by: Andi Kleen <ak@linux.intel.com>
> > 
> > Yeah, you did it, sorry, somehow I didn't notice.
> > 
> > Applying.
> 
> Would be good to have the original link with your report and to figure
> out the cset that introduced the problem, so that we could have a Fixes
> tag to help justifying getting this into 6.5.

Just bisected it. The original patch was below. Remarkably it had a "Fixes"
tag too)

My report was 

https://lore.kernel.org/linux-perf-users/ZMlrzcVrVi1lTDmn@tassilo/

commit b897613510890d6e92b6a276a20f6c3d96fe90e8
Author: Namhyung Kim <namhyung@kernel.org>
Date:   Tue Dec 6 09:58:04 2022 -0800

    perf stat: Update event skip condition for system-wide per-thread mode and merged uncore and hybrid events

    In print_counter_aggrdata(), it skips some events that has no aggregate
    count.  It's actually for system-wide per-thread mode and merged uncore
    and hybrid events.

    Let's update the condition to check them explicitly.

    Fixes: 91f85f98da7ab8c3 ("perf stat: Display event stats using aggr counts")