Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp4876662rwb; Tue, 8 Aug 2023 15:45:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHmlz33JZoOLK0jYj/Pfkz7G8J+5Q3P1+lyO4YbN1vn9YnIlq+95lp9a9crlH5/uaja/9TF X-Received: by 2002:a17:903:32d1:b0:1b5:522a:1578 with SMTP id i17-20020a17090332d100b001b5522a1578mr13941593plr.29.1691534740331; Tue, 08 Aug 2023 15:45:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691534740; cv=none; d=google.com; s=arc-20160816; b=cVTbew7WkaGONvqhuE3ydMR3Mo2f/LszbDqynnF3ewo0Zi5fsefa2/OOjjVicTIsmt qWvvznsw/SZXGJ2r9d5M1Wwf/RYUMUqLufDR53qY4A1jQeTbZoWGEZ+sJmZUD7Ibp7Ul BPkHiPMYSgf8iMQDRpDOoUA5PFDNil4YlVcSPIryXH6WcLlMBwbosm3WFAai/sSjNAuk d+dESI2ZfMsyBlLkNuiqD+r0sr7I9f8U+MMttB81go8nHOcBL99d85RDqrSqpZ8cR/m7 Xr8a6rJwtBmkETh5sge0MN3KVI6QuqZEmszeDRUXbI6Xl1gl6ZFe7/8xDRAMijSSZlVO K9lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=4OY6Tz/dJl4GDUSQB7m2I8b1RnZ8n/fQz5+GNLuPyY0=; fh=FxSiZQg5t3fYgf+wqDd80S/rVynm6Zzctx54Dmtiqlc=; b=aVfdwIz/cvTiHRfpHIGit8bldouMEmQt5STlC2H22pFhe7zimqz99aWXGt6H79xQhV PQdtxvZiGm3nTkBCZe6nqaqRgWK1JbXXNLTGZSQiw2A84AQBiD6Eiy7YPINKp1QiM4+Q q4notL9+/x7Z0ZQupCF9qAXF9uToDLB7qFEeZADlLF19YUnwosvDwHfB29dqKBQe/4gd nt2L/hUB3uouEB2lBOgxo4DqO294qJpS2PS6KsZYvA4DQ47ZnVTcBnsTLWFbQi9REl6Q pmK7McCVfBbORU1yIYRDbQm0DopGPnlwWoYDunldw+mU+X5g9EM8QiF8n6Sd+rYiSAxq Y5Hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=ixxVfvUx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n13-20020a170902d2cd00b001b8af83d939si8247659plc.537.2023.08.08.15.45.28; Tue, 08 Aug 2023 15:45:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=ixxVfvUx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231166AbjHHTRc (ORCPT + 99 others); Tue, 8 Aug 2023 15:17:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231180AbjHHTQS (ORCPT ); Tue, 8 Aug 2023 15:16:18 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73A635244; Tue, 8 Aug 2023 09:39:04 -0700 (PDT) Received: from [192.168.0.192] (unknown [194.146.248.75]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: andrzej.p) by madras.collabora.co.uk (Postfix) with ESMTPSA id DD3206607205; Tue, 8 Aug 2023 12:46:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1691495212; bh=4dORhiAb1e4NGjwwINdcxjyAgqLtFCQXF43zipS7tmc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ixxVfvUxrpp3dAMWGwXJ+yAmn3KGSU7CuvwISpyoclLNq757jpirsV8RajgxC8fgs pd8SwO8raFOKghjNf269/OMe757HAmEGtHfohVZExTMaMXbYFjxqMBSZEh398faYkj XxtousaLqRU61TejpvLjz3de3zo7wITYELNsqk9bs+RzPfoVU1d3upYFQ4zsnv0JPX kEoEdvjLCK3QR/s4QuMQwDPTCFbxkBZDcYdv10md+hpqDOXDVMI8RsV4jO7NMWIPDr szMn6hmP7CmNjNOsrBaYlTEq2n02A6gEpCZOM5ywRq568TG14uYcWfmXhZR6is0poJ unXFgc5cd5kfg== Message-ID: <3c69cdf0-c79e-f3b9-44f7-1dec0eb6a312@collabora.com> Date: Tue, 8 Aug 2023 13:46:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 4/5] docs: uapi: media: Add a layout diagram for MT2110T To: Nicolas Dufresne , Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno Cc: kernel@collabora.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230804192737.19016-1-nicolas.dufresne@collabora.com> <20230804192737.19016-5-nicolas.dufresne@collabora.com> <2e08b843-d1f3-a095-8e5c-cc4997773040@collabora.com> Content-Language: en-US From: Andrzej Pietrasiewicz In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, W dniu 7.08.2023 o 21:29, Nicolas Dufresne pisze: > Le lundi 07 août 2023 à 20:40 +0200, Andrzej Pietrasiewicz a écrit : >> Hi Nicolas, >> >> W dniu 4.08.2023 o 21:27, Nicolas Dufresne pisze: >>> This diagram details the partitioning done in each tiles. >> >> If I understand correctly there are 8 partitions in the diagram, each partition >> consists of 80 bytes, 64 bytes containing MSB data and 16 bytes containing LSB >> data. The diagram says "MSB 8 bits" and "LSB 2 bits" which might be confusing >> because it suggests that the length of the partitions is maybe 8 bits plus 2 >> bits. IOW it is not clear that the numbers (8 and 2) refer to the kind of >> contents rather than lengths. Maybe to the left of the diagram should be some >> arrows/curly braces describing the partitions' lengths? > > You mean you'd add the partition height (4) in pixels ? Note, I'm thinking of I thought of the partition size in bytes. > using "8 MSB of pixel data", as it seem to translate to a better english "8 most > significant bits of pixel data". "8 most significant bits of each pixel data"? Maybe it's just me, but when I see "8 MSB" I imagine exactly 8 bytes, whereas this partition chunk is probably 64 bytes long and the following one is 16 bytes long (and not 2). That is why I would imagine partition sizes to the left of the diagram - so that it is clear which number is partition length and which numbers are NOT lengths (8 and 2) but description of each partition contents. Regards, Andrzej I'm trying to avoid replacing the text, it only > meant to be a visual support. An alternative, is really to leave the details in > the text, and label it "MSB of pixel data" and "LSB of pixel data". Any > preference ? > > Nicolas > >> >> Regards, >> >> Andrzej >> >>> >>> Signed-off-by: Nicolas Dufresne >>> --- >>> .../userspace-api/media/v4l/mt2110t.svg | 268 ++++++++++++++++++ >>> 1 file changed, 268 insertions(+) >>> create mode 100644 Documentation/userspace-api/media/v4l/mt2110t.svg >>> >>> diff --git a/Documentation/userspace-api/media/v4l/mt2110t.svg b/Documentation/userspace-api/media/v4l/mt2110t.svg >>> new file mode 100644 >>> index 000000000000..d4fc223f5fde >>> --- /dev/null >>> +++ b/Documentation/userspace-api/media/v4l/mt2110t.svg >>> @@ -0,0 +1,268 @@ >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + MSB 8 bits >>> + >>> + >>> + >>> + >>> + >>> + >>> + LSB 2 bits >>> + >>> + >>> + >>> + >>> + >>> + >>> + MSB 8 bits >>> + >>> + >>> + >>> + >>> + >>> + >>> + LSB 2 bits >>> + >>> + >>> + >>> + >>> + >>> + >>> + MSB 8 bits >>> + >>> + >>> + >>> + >>> + >>> + >>> + LSB 2 bits >>> + >>> + >>> + >>> + >>> + >>> + >>> + MSB 8 bits >>> + >>> + >>> + >>> + >>> + >>> + >>> + LSB 2 bits >>> + >>> + >>> + >>> + >>> + >>> + >>> + MSB 8 bits >>> + >>> + >>> + >>> + >>> + >>> + >>> + LSB 2 bits >>> + >>> + >>> + >>> + >>> + >>> + >>> + MSB 8 bits >>> + >>> + >>> + >>> + >>> + >>> + >>> + LSB 2 bits >>> + >>> + >>> + >>> + >>> + >>> + >>> + MSB 8 bits >>> + >>> + >>> + >>> + >>> + >>> + >>> + LSB 2 bits >>> + >>> + >>> + >>> + >>> + >>> + >>> + MSB 8 bits >>> + >>> + >>> + >>> + >>> + >>> + >>> + LSB 2 bits >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + 16 px >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + 32 px >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >>> + >> >