Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 8 Aug 2023 14:36:46 -0700
From:   Bjorn Andersson <quic_bjorande@quicinc.com>
To:     Eric Chanudet <echanude@redhat.com>
CC:     Bjorn Andersson <andersson@kernel.org>,
        Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Caleb Connolly <caleb.connolly@linaro.org>
Subject: Re: [PATCH v2] arm64: dts: qcom: sa8540p-ride: enable rtc
Message-ID: <20230808213646.GK1428172@hu-bjorande-lv.qualcomm.com>
References: <20230718145105.3464105-1-echanude@redhat.com>
 <dtussvqzf7x5p633pxt3julkffhzt5rxwp3aghs4ocj5odq4la@ed6jhcv76hbk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <dtussvqzf7x5p633pxt3julkffhzt5rxwp3aghs4ocj5odq4la@ed6jhcv76hbk>
Precedence: bulk

On Fri, Jul 21, 2023 at 08:59:30PM -0700, Bjorn Andersson wrote:
> On Tue, Jul 18, 2023 at 10:46:10AM -0400, Eric Chanudet wrote:
> > diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
> [..]
> > +&pmm8540a_sdam_7 {
> > +	status = "okay";
> > +
> > +	rtc_offset: rtc-offset@ac {
> > +		reg = <0xac 0x4>;
> 
> I'm still trying to get confirmation that this is a good choice.
> 

I'm recommended that you use 0xa0 from SDAM2, "preferably in the second
PMM8540", instead.

Can you please give this a try, Eric?

Regards,
Bjorn