Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp4881957rwb; Tue, 8 Aug 2023 15:52:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHV+G9/Fkulp61Lan5PiSPXccaaFpJnRw/KTXVTeK88GK2H6TfdYlEBhChP6+t7hBbAOdpk X-Received: by 2002:a05:6a21:3e0c:b0:131:6464:217b with SMTP id bk12-20020a056a213e0c00b001316464217bmr820348pzc.16.1691535178482; Tue, 08 Aug 2023 15:52:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691535178; cv=none; d=google.com; s=arc-20160816; b=0gnGYuSmf0yzVrY+EwrIDIwmz83XoTJ00qfvFn12tqcsNhvlXUuIZaXW6NCW42j/QX lLDlap+VkldIrBiWJKPO7r6ChaGq8XITZFUZHQZ/ocWAl8Ixr0o51OwryJZ+YCH9Ek+z S1v9KyH64DLJZyliGvwdNoXAfFZZ90UGkETXi98jAzOZOifQCxsDMXNt8Uv5FAAwPm9D ZhQotWu77Vghgf92LRN+5hldNz9f0juntYkpAHNsy+DDN6Q6NtVek6We0ib+kUS/nUYw ctmaiJ0d9MFFLJ4HShDzaqixCxuVdFpJUNM89pnWT+InELkRBROyh+SLWYcR+zD2ajzc xlRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=m12kzZN53IMQvTnsANViF0li6YYyhC19zBBHQ0jIm7I=; fh=LrmwQhT5U8hDEydi+5R45d4GfgVLVEctXoQlH7yo578=; b=v/SXidIXWamVH126ky8+4w/SATk+k+/RzHpRQFLcuXLQGkU7s4vrGS5DszIRS6YJ4Y NWllFn+oYUHS+VuXZg4yCWsP/zQo4QI7NsHnXGm/r/akV0mXOQJrV+Meh+aQRPlgz73k /TyDSukabDUx/QOjkwVKKPzZTQLKMyuvHQQdr8U0W9iBtUsyfnQ6mSxN104yz49mX/4f RArpnt4YRtpq/cbYOjJoUIp4aMxnrlELKkzM7UwYg9z+cXW5C03JNawf8bYxi+c3Yezz 49qcnznTlsoIccUxzBZL73VCQZRQu8vMfzg0rRr7Pb4VEXIlZWdRF3UC61jKkr/dyMxO 9ang== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=OkeUWhkb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g21-20020a056a0023d500b0067b51fca490si6255234pfc.248.2023.08.08.15.52.47; Tue, 08 Aug 2023 15:52:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=OkeUWhkb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229983AbjHHVmW (ORCPT + 99 others); Tue, 8 Aug 2023 17:42:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbjHHVmW (ORCPT ); Tue, 8 Aug 2023 17:42:22 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFD6110C for ; Tue, 8 Aug 2023 14:42:21 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-5643140aa5fso859572a12.0 for ; Tue, 08 Aug 2023 14:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1691530941; x=1692135741; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m12kzZN53IMQvTnsANViF0li6YYyhC19zBBHQ0jIm7I=; b=OkeUWhkbXJYC83xSHTdERH+GDd/onOYGF9X/YhejGcbkv5o8BdT//Lw6k7l0Hn278i VfROO2znwsiBA3RKhmOmsH0Fppj7eMhfgfClGVRcz5cUmuyckpiptwFB/HSGdRs6PGpO 5q2BX2CRpB/O7Jj2tGxBIDF24Fhp36KOnFO/Y/LhzxTnbX0crsewjJOU1BdINwybSJo/ 8TciXuEUs1Z5ypnMkoExT7Sol3z4xbBipbtgoopbj1JaF9EmL/rChRUDcSEkLTCpa4ES hUO00yEol78psLo6qYKHRCcndBPxzQt/de/KcGS6cTDnFE5OXIhQ98IJE3Yit0Uo1B1B N0nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691530941; x=1692135741; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m12kzZN53IMQvTnsANViF0li6YYyhC19zBBHQ0jIm7I=; b=OJeyVF9zsI9JMcZEQT4gMhyww0arhJtJ9FxlHcGfRWn7tLBh1OHWOMR+CBmpdPv8v+ G3Jof5xgylLi+y6LGsCh6F9NEpeunc5zhoSL5fA4PuGqcZR9vQT3q6r3JaOpv4cVHQyJ 0echtD+/1vWtpX7c/bM2jGVJVoUyhn6/mYZ1oa/MMZKp48FVE8+5moAIZ7N0MjL4bfGC ZtLGDXsOnO/IbC2t/C39lgoKuTZYytJnofO7sGz5cU0cqtO7hpLkQ5QEvU9ctwe4nRta Yrk+uEp/lO6Zk+yfS3ZaOc52nqTCfftdKBxvcMOtzskxLdMJZZ5wBLpYLd5Kkjs7z8Ui O7Lw== X-Gm-Message-State: AOJu0YyRt1COhQhhQXemPyA1H91+g0uxTAewH3BTNzYF26HAwI7NTzW5 90LnnWuq0vCui5oCvLTDRyQGuA== X-Received: by 2002:a17:902:e88f:b0:1bb:d7d4:e2b with SMTP id w15-20020a170902e88f00b001bbd7d40e2bmr1076777plg.0.1691530941128; Tue, 08 Aug 2023 14:42:21 -0700 (PDT) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id x4-20020a170902ea8400b001b53953f306sm7338861plb.178.2023.08.08.14.42.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 14:42:20 -0700 (PDT) From: Jens Axboe To: tj@kernel.org, josef@toxicpanda.com, chengming.zhou@linux.dev Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com In-Reply-To: <20230804070609.31623-1-chengming.zhou@linux.dev> References: <20230804070609.31623-1-chengming.zhou@linux.dev> Subject: Re: [PATCH] blk-iocost: fix queue stats accounting Message-Id: <169153093995.139918.10632912851603759401.b4-ty@kernel.dk> Date: Tue, 08 Aug 2023 15:42:19 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-034f2 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 04 Aug 2023 15:06:09 +0800, chengming.zhou@linux.dev wrote: > The q->stats->accounting is not only used by iocost, but iocost only > increase this counter, never decrease it. So queue stats accounting > will always enabled after using iocost once. > > Applied, thanks! [1/1] blk-iocost: fix queue stats accounting commit: c992226e984b93b316005ae4b12f2dce1e11630c Best regards, -- Jens Axboe