Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp4900692rwb; Tue, 8 Aug 2023 16:15:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHvt/Y2k7DOZ7x3Xkeq7AqQc8NNeN8gPQ0kUMSAS1ENYY1POUfuM7gRuQL/Lkc9Mjj3p1cg X-Received: by 2002:a17:902:f542:b0:1b8:b382:f6c3 with SMTP id h2-20020a170902f54200b001b8b382f6c3mr1410890plf.13.1691536510871; Tue, 08 Aug 2023 16:15:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691536510; cv=none; d=google.com; s=arc-20160816; b=g/KQkKDqjXHK7yiRQo8D98jeAG9lAlweKDjJ0A2CHS1tzMAX5ejOuKLUQcSGlpw7Uc UoCOGvVSsoUNWgPsuPVMT90vSHo9LOV8CCRqYNd6YsWg6dzWqh+RUZap20PjLVrUnrVh OixYPWJU97/62i8S1NSbttk5xpSlI2Mkugdbf9K88Xcn1WpNpQWIJ1GqmhHXugQWFqI4 XBbRTRZ+IxWTBRtzNQnWwhYD6uFa+c+LYnkfKcJ+b1SKFI4i8do3rwJQe42oosZBunvW 4aXiVMGz//7Kqdny6cU0Uqr9wFyFJR4pqbfIAfYFthy4SCm4te5Tt3AxXL3ctdqQKU1t WlrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HNl0ltQ6dr9JUY5+74YSyRsm+xqmxQcOylgIxeDZAvQ=; fh=r3lvmPNhGgKSDUTq+KAS+3XsBrucTXpMUF+ulIo4NiE=; b=IN3niS6KzPoymdYH3rX2HiFu896j5Ed7nA/UafJoRFXYUfDEoXfrbtn9JtvB7e1Inl KbVqPifAB1bfIv4FN0zQSNSSBMuANjDH5yeDjgC1uR81uKmkxxf64m2Z2n+tAXbTmH0q bl9dzWuCA8n84u//tV7yupHaWH3BHqq8Yzch1u2cRqLio+aFBqgqsCJPQOCwZjx6x9cv tSEv+Ulan1tbyL/m4EBan3RGqIz54Ljhj3c4bCBH8SuediHaChWY3TaTkaEBkEQ0XVaR HxAWogjCfnTCKJ/bD6YciGzX6K6DKNtV2pbI/XflXspPKAcJbg6zUb6tIiziyrfjjsgw a8nA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="IT/M8A6l"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kb12-20020a170903338c00b001b89ecd8e66si7694621plb.188.2023.08.08.16.14.58; Tue, 08 Aug 2023 16:15:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="IT/M8A6l"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230247AbjHHWGi (ORCPT + 99 others); Tue, 8 Aug 2023 18:06:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229790AbjHHWGh (ORCPT ); Tue, 8 Aug 2023 18:06:37 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB0A6E51; Tue, 8 Aug 2023 15:06:36 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1bc8045e09dso9282575ad.0; Tue, 08 Aug 2023 15:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691532396; x=1692137196; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HNl0ltQ6dr9JUY5+74YSyRsm+xqmxQcOylgIxeDZAvQ=; b=IT/M8A6laE0SAk1/avwizLHXTFcVHzJieSsNfnyHwmiwh17WZfJsLAh4MsERQ4xX5b +dRQIl0bnMSrF2h85yryo4lSmVOUtm2b9zYe51uGocKsRR0sO2KD4Zd3CzszRxDDJxGU qfZN+28cvutmcl+rv98W46xpZxfyWVNEwuYrDrHR4WQ5V3APWci/v2tz4duF3gRtHeX2 YMiZPYlPrM/yrgRgiHH8a0B1pVrY+cd4214dkmnDffux9gzor3cM7sVDC28hx2/VMnNJ BuHHaDGg3Ze86yaI2vzmq2qR+WRIi8OJoxV+BWbwnb1JOv6nIPHCLMOMFvWvjUyUdNHR V0wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691532396; x=1692137196; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HNl0ltQ6dr9JUY5+74YSyRsm+xqmxQcOylgIxeDZAvQ=; b=kbLxdR76LJGgXi9vmIwNgOZCqg2qFNXOG7z9T103WCRgP34GrTl353NEgZeblN+MnM v3Vy/hB6TDiIccPYhTA5KBEjw7feWwcEx5Ti3phDUOnAXRhTFel43LX5NqQeockEBYSL CgGZovH2YCMewjrZwutwV6EouEEEwIrkFdMWE/q3C9AacwMIrEn8bLbV/wJULTTBxKB3 mVav8qUum06jhWeWG8Nzh8ldzC576pvE2S/BTk66dg89Mwse3n1weq/TY8lIjdKhtJEV ALndLdZDPL1JQum0sAhKoR8ssT3gZ6Ul7X5GHVUFh8TCsrKWX3PT70YQUYtfJCv1etfH JlsA== X-Gm-Message-State: AOJu0YwKFLAgRSkdxu5cg8tq7checdxE7SUmK6Bmv/DTqyv7InmQec7O uBjshtuSf5re/Pg3YsNJGXA= X-Received: by 2002:a17:903:2306:b0:1b8:89fd:6213 with SMTP id d6-20020a170903230600b001b889fd6213mr1044083plh.35.1691532396040; Tue, 08 Aug 2023 15:06:36 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:fa39:8c5:e5b:291b]) by smtp.gmail.com with ESMTPSA id b10-20020a170902a9ca00b001b9d88a4d1asm9463638plr.289.2023.08.08.15.06.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 15:06:35 -0700 (PDT) Date: Tue, 8 Aug 2023 15:06:32 -0700 From: Dmitry Torokhov To: Lyude Paul Cc: Sebastian Wick , Aman Dhoot , Mark Pearson , Raul Rangel , Wolfram Sang , Andrew Duggan , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "Input: synaptics - enable InterTouch for the ThinkPad P1 G3" Message-ID: References: <20230808152817.304836-1-sebastian.wick@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FSL_HELO_FAKE, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 08, 2023 at 05:49:23PM -0400, Lyude Paul wrote: > Hm, This looks fine to me (if not as a final fix, certainly as a workaround) > > Reviewed-by: Lyude Paul > > However, this is definitely something we probably should try to fix at some > point - as I imagine this must be happening because something regarding how > clicks are reported must have changed again. Andrew, do you have any idea? I would like to understand more about this. Is this with newer/older BIOS, or another hardware revision of the product, or something else? Lyude, do you still have access to the unit you originally developed the original change for? Is the behavior broken there as well? Thanks. -- Dmitry