Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2a8ece3c-76cb-c922-1ecc-3a4515aa406f@amd.com>
Date:   Tue, 8 Aug 2023 17:08:40 -0500
User-Agent: Mozilla Thunderbird
Subject: [PATCH v1 3/3] EDAC/amd64: Add support for AMD Family 1Ah Models
 00h-1Fh and 40h-4Fh
Content-Language: en-US
To:     Yazen Ghannam <yazen.ghannam@amd.com>,
        "Limonciello, Mario" <mario.limonciello@amd.com>,
        Avadhut Naik <avadhut.naik@amd.com>, bp@alien8.de,
        linux@roeck-us.net, x86@kernel.org, linux-hwmon@vger.kernel.org,
        linux-edac@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org
References: <20230706171323.3722900-1-avadhut.naik@amd.com>
 <20230706171323.3722900-4-avadhut.naik@amd.com>
 <e5b0063a-ae41-41ab-b3a7-2084dfa7f816@amd.com>
 <1606f9f9-5d5a-788d-b058-ec218fb73712@amd.com>
 <36bff484-f41a-4eed-bcd6-a96539b905b8@amd.com>
From:   Avadhut Naik <avadnaik@amd.com>
In-Reply-To: <36bff484-f41a-4eed-bcd6-a96539b905b8@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHJ0UGNxR296Ui9RaXk4OHFwSW8xTCtReWUrWG5ZeG92ME9na0tKbDVMc296?=
 =?utf-8?B?SXJBdHdnUVN2ZmFBYzJUeWpmaU5DSHR0THNMdnRFdlpTUFZxalJ1emRUeXlw?=
 =?utf-8?B?UFUwd1QyaDZsdFY1VjdsVDAxOUtyMGthZnhxSVpFTFRtSXlqK3FqR0tZcHlp?=
 =?utf-8?B?M0VhdGtZQUtXZ3k1cU45VjlRSVV1dmxFYTQvUnl3RFVOYXoxeDhaWFZQQVNx?=
 =?utf-8?B?ODVVZ1U3eDVDY0hFblF2UkdXMVdVa2s4OGhQQVRPeCtnSnBmeExLanBJbDhX?=
 =?utf-8?B?aXRiNVBGclFrUTdmTHE3SVRNWXlvRml2SURwUTBjRkdVUUpmaWlYM1htOUM5?=
 =?utf-8?B?a1N2aFZBL1RYTWthTG5qUERUZmhTa2lrTWpLY1hyNHVoeGQ3QStnSWdhaWZk?=
 =?utf-8?B?cVo5cnkvQ1dneVdzUGlpRE52MU9rZmtCUEZyTVpJS1J6ZG5wSTVVWE9BbGtW?=
 =?utf-8?B?emtobGpSTVdacWdPUFhDR1pIS2x5Z2hORUNtbkYwZ3VJWit2SC9GMnZkbVky?=
 =?utf-8?B?U1p0QncrdXNFekhQWk5ZMW45aWJOZmhWTVBpcUVRSllVTXhxaDRVektmaUZz?=
 =?utf-8?B?Y2swRk4zWmg3NzVpNWI3Y0dYWmhKVDJFUERoMHBRRjIveTNnc3ZwZm5IRUs0?=
 =?utf-8?B?Zmp1TjVLRTEwOXJlaWJCNjFBK2g5cjNZN1M4QnVyWnUySy91YURuQldoTDN1?=
 =?utf-8?B?MGhUZG9XRUFCSk52KzgwMzRoeXFrTDY3akNOZ0E4YjFGQ1BxUzJVZEZ5R0ZY?=
 =?utf-8?B?NDVWMWxrNFA0R3ZhUEhoVTQwbUVJbFZ0YUZqditVLzNvT2Y0bWN4K05DdEh5?=
 =?utf-8?B?THYvQ2VrRDAyT2JFeC9XQ1RNcEd1TWpiclR5Q2dreEtMTkQwMHdCSTJCYVQx?=
 =?utf-8?B?aTZVZXJTM21nbm5WM1ExN3h4M2J4S0JoSENlMFdoTllaWVNjNEY2T2VON2Jo?=
 =?utf-8?B?a2dwUGFTWU4yQ0R6YmxkS3dEMVJUOEk4bWZQOHFwRXQyeWdiRFlxWmMzeHVB?=
 =?utf-8?B?WVZYUUVXaTVEdXEzV2U5RE0xUVpsVUxRZEhkRFVPUjZueFJyZVR1dDFwbFZj?=
 =?utf-8?B?a0o4UnE0NlAra2dQL0RrU0xmenJQSEFnUmJQMGhnYzYxdlBVd3NzaGQyNEMx?=
 =?utf-8?B?SWRhNWU0aExWT1dpN21OVlFlRXE0MWVQN0M0OEZhM3Z1UXIwL2RNWFBtM2la?=
 =?utf-8?B?cHppQUtUODBSdlhDbmErbGpUZ1hJQ09lcWNGbjVLZTUxeHl6WUpjZXE2UFZF?=
 =?utf-8?B?U3FPcTc2L0VpcmNsMlB6NzJESjFzTjYrNkFHUGdNNUdrK3lCZjZ2eUNhOVBS?=
 =?utf-8?B?S1Aya05CWS9XL2hBNlRkS05VejF4aDBmc2dBbEZWRURZdjN3cHlMVTBhd2U2?=
 =?utf-8?B?ZTM4K0dXWmFDMFgxMWVoTzM2TTZObDFlSFpiaENVRUowSitLVXhvUDl4cE9s?=
 =?utf-8?B?RUJqWlB3WUdoWWRkR0c2SVlrMk94RldBa1h0SWNCOXNYQ0hEWUZGb01QK0Js?=
 =?utf-8?B?T09xN05HY3BnYkFCK1k5UzR1OG1jM2NjU3R2UVV1VzdmM0c5cE05ckpVZVlK?=
 =?utf-8?B?cExtWXU1YTVkVmtKUWNob25odmJqTVFTVm1JbGV5L2xXRW5MRVdBRWZja3dz?=
 =?utf-8?B?QW1lcTdrMGdlSExScHExMGxMTnFUQ2ZuU2JucnphVHJsak0ranlYNElETzFh?=
 =?utf-8?B?VUQ1a2NHTWdrV1hxU0xmWFlsblRXWnhDSVNkZXRXV2xQL2ZDSTlhQjR5Y0Rs?=
 =?utf-8?B?dmVQeGVhYUYwcEJoNmhXRTMySTdqR0NaV0lpaE1xN2xFM3dIU2NTYXlRZHBM?=
 =?utf-8?B?amVPUklQZjR5MVovTjVZYlhJa3dRdHZmWHNTcmc1ZWpoT0pHc3dDTHE4UXAr?=
 =?utf-8?B?WFBoMS8zVlhtbVpwQ2dJYXVsNzRId2hyei91bzZIc01vZnNBSW5kSldobm9M?=
 =?utf-8?B?Nm85bC9iUFdQN2hYZU9vdXZLT2tLaGV0MVBjWlVETHUwalNqbnJVWk1XOHM1?=
 =?utf-8?B?UmRKb1dUNTFsZURISzR0MUJoZWk0QUZidG5GbklEeVhjNzVvRm9saFh2dkZL?=
 =?utf-8?B?dFdkRzdEWDY2dkJJc29LY0hxVEVDUk4xOVZOeUlrN2tpKzdxNUNZN0pqMEJz?=
 =?utf-8?Q?2WEnxpwinN4zk34czghKSV48M?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0d54ad2-150f-4341-8624-08db985c0743
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6203.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 22:08:43.0798
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KWp9SVIhSyVvDxM0I/VCGaygzgD5gr2jwC54WvFOv43S829V3lxZmdZO2hN5ovGgZrrHawL/8rlGBy8D3XE4kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5177
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 8/7/2023 08:48, Yazen Ghannam wrote:
> On 8/4/2023 12:03 PM, Limonciello, Mario wrote:
>>
>>
>> On 8/3/2023 7:25 PM, Yazen Ghannam wrote:
>>> On 7/6/2023 1:13 PM, Avadhut Naik wrote:
>>>> From: Avadhut Naik <Avadhut.Naik@amd.com>
>>>>
>>>> Add the necessary support in the module for AMD's new Family 1Ah-based
>>>> models 00h-1Fh and 40h-4Fh.
>>>>
>>>
>>> The first patch in this set adds PCI IDs for models starting at 20h. And this patch adds support for models 40h-4Fh.
>>>
>>> Can you please elaborate on the discrepancy?
>>>
>>> Thanks,
>>> Yazen
>>>
>>
>> Model 40h-4fh shares some of the same design as some other platforms.
>>
>> The root port ID PCI_DEVICE_ID_AMD_19H_M60H_ROOT and DF_F3 ID PCI_DEVICE_ID_AMD_19H_M60H_DF_F3 covers it.
> 
> That's fair. Can these details be included in the commit message?
> 
	Sure thing! Will include these details in the commit message of the first patch where PCI IDs are being defined.
> Thanks,
> Yazen

-- 
Thanks,
Avadhut Naik