Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <20fc56ef-6240-e86e-6d38-9278592a3b25@lwfinger.net>
Date:   Tue, 8 Aug 2023 14:20:06 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH] vboxsf: Use flexible arrays for trailing string member
Content-Language: en-US
To:     Kees Cook <keescook@chromium.org>,
        Hans de Goede <hdegoede@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-hardening@vger.kernel.org
References: <20230720151458.never.673-kees@kernel.org>
 <169040854617.1782642.4557415464507636357.b4-ty@chromium.org>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <169040854617.1782642.4557415464507636357.b4-ty@chromium.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/26/23 16:55, Kees Cook wrote:
> 
> On Thu, 20 Jul 2023 08:15:06 -0700, Kees Cook wrote:
>> The declaration of struct shfl_string used trailing fake flexible arrays
>> for the string member. This was tripping FORTIFY_SOURCE since commit
>> df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3"). Replace the
>> utf8 and utf16 members with actual flexible arrays, drop the unused ucs2
>> member, and retriain a 2 byte padding to keep the structure size the same.
>>
>>
>> [...]
> 
> Applied to for-linus/hardening, thanks!
> 
> [1/1] vboxsf: Use flexible arrays for trailing string member
>        https://git.kernel.org/kees/c/a8f014ec6a21

Kees,

This patch has not been applied to kernel 6.5-rc5. Is there some problem?

Larry