Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c0aed6a4-23e0-d947-5c17-26e580d5c40a@intel.com>
Date:   Tue, 8 Aug 2023 17:13:12 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH RESEND] x86/pti: Fix kernel warnings for pti= and nopti
 cmdline options.
Content-Language: en-US
To:     Jo Van Bulck <jo.vanbulck@cs.kuleuven.be>,
        <linux-kernel@vger.kernel.org>, <dave.hansen@linux.intel.com>,
        <luto@kernel.org>, <peterz@infradead.org>, <mingo@redhat.com>
CC:     <x86@kernel.org>, <bp@alien8.de>, <tglx@linutronix.de>,
        <hpa@zytor.com>
References: <20230808195615.9795-1-jo.vanbulck@cs.kuleuven.be>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20230808195615.9795-1-jo.vanbulck@cs.kuleuven.be>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RExoUnJldHFXTTJIcGNLUVBHcGFFNU15MjArMlF3VVRNSG1XRTNieEJZZ3ZR?=
 =?utf-8?B?N1F3anBpZlY3ajNiRHVvUGl2YWQ4QzhiaG5kTCtxUFgxQm9iVmhLQ3N3WUpm?=
 =?utf-8?B?Z08zdGw1dWdNUVJueXB2S0dSZkRoWktYaGgycjhTZUVPd0N1YjkzNmRzY3g2?=
 =?utf-8?B?a1Z4eG9Zc0I2aFZPV2dHSHAzZzFqUk90WWZmZmg5c2htMGN4RGJ2RlhjM0Nj?=
 =?utf-8?B?bXFYS1ZRYVY1UWZldEdZR1hLaVhOazJDTnZ3a0xPUVN4eHhqMWY2T0FXMkVO?=
 =?utf-8?B?N3dXWlJxQi9CWkx1M2gyOG5zR0VEVWRTSFlwTzI0TnFpSURZWlljbHFiUU9h?=
 =?utf-8?B?UzJ4cUJoYmpEWmhIem4vU0NyZnhGLzc2MTl6ZEtUSHV6UnB1NjdYUy9lYlpF?=
 =?utf-8?B?T29LZUJlODNIVE5Na0J1V08xd3FDWEZ2T0VKbDFwWFhrMTRMNFFVM1ErVFhR?=
 =?utf-8?B?Z0IyWFA3UDVhanZvVkRqYVpOS1VkVUFmRjBIc1JWbVFDdlNRdDB4NkNBMmxz?=
 =?utf-8?B?a1N4Sk1mWnJnOWR5bEQvWVVQNEo4MWJndUJvU3NXc3hNODRLTU9YekRHQ1JF?=
 =?utf-8?B?OHduN2lES3RJV294LzdML3dDQjdYdEJFa21EQW4ySFVWNzEzVlhnaUZHYmp1?=
 =?utf-8?B?SEZlZnRlK2lWb1RRNnI4SjNlWnRwbWhQL0t0UGttM2VQdDdSK0UxU2Y3aW1h?=
 =?utf-8?B?ZmxLdm0zcm41TXJ0VGNqWUpWZ3AwNWNuMVF3dW1Jc1NUdUNhUVNnajdTOGZq?=
 =?utf-8?B?LzBrRHZkQlZ4NWd1RjV2QjkvSEZiNEoybVgwbkt5dDROVzM5aDhoYkhiaW4y?=
 =?utf-8?B?ZTN0aFlMWDgwNC8yQlZzdEVsZkZrMWl1Rk13N0hobTdBTTYzRVZVS2FKNmNW?=
 =?utf-8?B?SVo5S0JESXhiaFFaVmhHNUxwdFc2VFRvOVJoZENyZ29FVmFuRUdUaHg4eUE0?=
 =?utf-8?B?UUFXeTZsWXFabXBvMEtGZDdjUVh0Qm5vZmYxRDVYZG13RzNYa2xYakh2SkVL?=
 =?utf-8?B?MnJtNFdSZDZyeFQ0aVE2NTNnVXBnbENCOHo4RHprU2EyVXFraGZYRlhTRUF5?=
 =?utf-8?B?YUJUbnNZVDc1ekN3VE95RVErSnV6VzBobFVyK0FUa3p2RHJmZG9KNEd2UFF6?=
 =?utf-8?B?OGx6QUc5QmRMK3RLVTA2bHZFdEQ2YTN6cFJ6dHpZenJXQ0FwelNCWmpkMzdC?=
 =?utf-8?B?OVFTSHdwUFRpZm04MXArUVppK2hXQ3Y0VlcvRExtUEFlQWFRaUpMZHJnZWY5?=
 =?utf-8?B?UGdFZVZsUjdWMUt3UkxuSjdON0p5TkpKM0VvYWhBc2NoTEs1d0Nja25ab2tm?=
 =?utf-8?B?QzVRSzhTYTJUTXdWQnVJb2tEVTZYU2RWZkx5c2RNVDFUS3dsbWFnRVpZR0JS?=
 =?utf-8?B?cENqSjJGcWI4NXFmaE85aEM3ZXN5cUEvVzNTWkgvc2VGZk8wcm5SVlVuUExq?=
 =?utf-8?B?c2phMlVnWE9wK094YUxIQzRrOGtZbkRNNDF2TW9Mb0xidEkrR3duVDFxdm1O?=
 =?utf-8?B?MjhhN1pMY3RpZTJRTkViejlsZEdKVzhVbFliR2ZyUnBpV09yNWNYQ1Jkb3Y0?=
 =?utf-8?B?V0RQMy8rcmo5TzMwQTc0bFluOGlkRkovU3VJTWZHYUZTdFFubi9xb0RyRXd1?=
 =?utf-8?B?VzFQdnJkOVgyTEdGSkhxUy95b001V3FWT2VTN1RzVnJTUVZ1eklMcVBTaVZn?=
 =?utf-8?B?bWVpdGcrSkhWdkp6d25EbHdlemhzYTM3dDRQMGlnNkNuZHRXMkF5NDMrU2JP?=
 =?utf-8?B?enNsNlVGRjU3K3p6dDNBQmRUUFlCemxiNWptQmE3L3EvZ1FySXl6VE9sUmJ3?=
 =?utf-8?B?akNCQWt2Y1VxKzYzcGNIamtvd0RSQUx2c2hpYXJMOEhZNlE4cG1lc3cvcE1Q?=
 =?utf-8?B?UXEyLzFGTnU5WThOUUlmVE0yTmtzS1l3bkFFSjl0ZE85NnVoQVN0N0FFWUht?=
 =?utf-8?B?OHZXbHc0TU5OY1NQU2VTRTcvbXQ2QnJ0RkUwVWd2cTVCZmZ4dmx2MTNiT21l?=
 =?utf-8?B?bi9UQUV2c2JtUm5HbzQ3dXQwV2UydWNnMG8wS2gwWlpWZFg5SHJTVGdsV0Fm?=
 =?utf-8?B?b0lRM3p6Q3VrY1VmSlhaSmp0WXJUbHptY1BKUlF3VldZejZuVVlYMmdiL05Z?=
 =?utf-8?Q?YSGjkPqRFzWR/0scS6YNAAEE+?=
X-MS-Exchange-CrossTenant-Network-Message-Id: aabf167d-badc-4b4a-b550-08db986d6c83
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 00:13:14.6249
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iJIALn2tAXcgmpTcl6ztbU1/Dtm6XKkHf+w/Zx1oy3gcR/NTEqVMLvsJxyQCl8j7ehrG0aLtWG81hKmaEmOXcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB8266
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/8/2023 12:56 PM, Jo Van Bulck wrote:

> -
> -	if (cmdline_find_option_bool(boot_command_line, "nopti") ||
> -	    cpu_mitigations_off()) {
> +	if (pti_mode == PTI_FORCE_OFF || cpu_mitigations_off()) {

Can mitigations be off through some other mechanisms such as kernel config?

Maybe split the mitigations_off check into a separate if and it's own
unique print message?

The existing code might have the same issue as well.

Also, with the separated check you can avoid the unnecessary re-setting
of pti_mode when pti_mode == PTI_FORCE_OFF is true.


>  		pti_mode = PTI_FORCE_OFF;>  		pti_print_if_insecure("disabled on command line.");
>  		return;
>  	}
>  
> -autosel:
> -	if (!boot_cpu_has_bug(X86_BUG_CPU_MELTDOWN))
> +	if (pti_mode == PTI_AUTO && !boot_cpu_has_bug(X86_BUG_CPU_MELTDOWN))
>  		return;
> -enable:
> +
> +	if (pti_mode == PTI_FORCE_ON)
> +		pti_print_if_secure("force enabled on command line.");
>  	setup_force_cpu_cap(X86_FEATURE_PTI);
>  }
>  
> +static int __init pti_parse_cmdline(char *arg)
> +{
> +	if (!strcmp(arg, "off"))
> +		pti_mode = PTI_FORCE_OFF;
> +	else if (!strcmp(arg, "on"))
> +		pti_mode = PTI_FORCE_ON;
> +	else if (!strcmp(arg, "auto"))
> +		pti_mode = PTI_AUTO;
> +	else
> +		return -EINVAL;
> +	return 0;
> +}
> +early_param("pti", pti_parse_cmdline);
> +
> +static int __init pti_parse_cmdline_nopti(char *arg)
> +{
> +	pti_mode = PTI_FORCE_OFF;
> +	return 0;
> +}
> +early_param("nopti", pti_parse_cmdline_nopti);
> +

In the rare case that both pti= and nopti is set the existing code seems
to ignore the nopti option. Would the new implementation do the same?

Sohil