Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f9452c1fa9081ae44bb76eec48c6debd81ee0db7.camel@redhat.com>
Subject: Re: [PATCH] Revert "Input: synaptics - enable InterTouch for the
 ThinkPad P1 G3"
From:   Lyude Paul <lyude@redhat.com>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     Sebastian Wick <sebastian.wick@redhat.com>,
        Aman Dhoot <amandhoot12@gmail.com>,
        Mark Pearson <markpearson@lenovo.com>,
        Raul Rangel <rrangel@chromium.org>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Andrew Duggan <aduggan@synaptics.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 08 Aug 2023 18:08:45 -0400
In-Reply-To: <ZNK8aG/y4ol7MXVp@google.com>
References: <20230808152817.304836-1-sebastian.wick@redhat.com>
         <f13f4ff7d46ecf887ca652b664860c4e07ec8b73.camel@redhat.com>
         <ZNK8aG/y4ol7MXVp@google.com>
Organization: Red Hat Inc.
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-08-08 at 15:06 -0700, Dmitry Torokhov wrote:
> On Tue, Aug 08, 2023 at 05:49:23PM -0400, Lyude Paul wrote:
> > Hm, This looks fine to me (if not as a final fix, certainly as a workar=
ound)
> >=20
> > Reviewed-by: Lyude Paul <lyude@redhat.com>
> >=20
> > However, this is definitely something we probably should try to fix at =
some
> > point - as I imagine this must be happening because something regarding=
 how
> > clicks are reported must have changed again. Andrew, do you have any id=
ea?
>=20
> I would like to understand more about this. Is this with newer/older
> BIOS, or another hardware revision of the product, or something else?


oops, somehow when typing that response I totally forgot I was responding t=
o a
revert ._., which changes everything

so yes - we should definitely look into this a bit more, I still have acces=
s
to this machine so I'll try to take a look tomorrow and see what's up
>=20
> Lyude, do you still have access to the unit you originally developed
> the original change for? Is the behavior broken there as well?
>=20
> Thanks.
>=20

--=20
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat