Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f5c7b43e-80cf-53b6-730b-ff9e1c023f13@intel.com>
Date:   Wed, 9 Aug 2023 11:11:01 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH v5 04/19] KVM:x86: Refresh CPUID on write to guest
 MSR_IA32_XSS
Content-Language: en-US
To:     Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>
CC:     <peterz@infradead.org>, <john.allen@amd.com>,
        <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <rick.p.edgecombe@intel.com>, <chao.gao@intel.com>,
        <binbin.wu@linux.intel.com>
References: <20230803042732.88515-1-weijiang.yang@intel.com>
 <20230803042732.88515-5-weijiang.yang@intel.com>
 <ZM0hG7Pn/fkGruWu@google.com>
 <8066f19d-68e9-711b-acdb-7554475602e6@redhat.com>
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <8066f19d-68e9-711b-acdb-7554475602e6@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODV3KzVYdGU1LzZVcllxU0N1ZTY3aEhSQnUzMWFrV3pPUThoTTRXTXY2ekpR?=
 =?utf-8?B?L25lZ0RuSVlRVXBoaE1UOGwwRlgxMnF0QmxsS1ZadHluVmxRelpMS2oyeWx1?=
 =?utf-8?B?dmpqZ01GZ1l3bWUzSExmUkk5UWJuQzNxaUdDQzcwTlpTOHpreXFGaXJtNnlT?=
 =?utf-8?B?TktQeVh2eTcwb1I0K0x2M1FVNkRvQVdUZnk2bzNFQTU5V3N3M0dnRE9oR2lJ?=
 =?utf-8?B?bjhMZ1oxS0VCbmduOTNiTHZQd3duVW9vemxVQmttVkdMN2pnU1pLR3NhVVM1?=
 =?utf-8?B?SFR4Y1ZEQ0lnY2xGdG5WK2tiNHNWR2djZjQzNE9mZTdLNHF2TzBXRitKWlVh?=
 =?utf-8?B?elpQZzdSQy8rQVV5aUo4eFpnemdoNjMwMkxmbk8wR0I1NFRjZGRnZ3liSkFQ?=
 =?utf-8?B?RFVKT1h6d1JxeWQ2MmNKdVRnZElndC8rUDc0OFJ0WjJjbXJyVHQycDNZbDJ2?=
 =?utf-8?B?MGtpRG1jdzQrNzl3N2lGa3BUZHdWM2xUTm90b3JRaTRPT2NISHdQY1k3ZXJH?=
 =?utf-8?B?YldIcWVSTW16NEdtT3ZCTEUwZjRwUFBOT0lhZXZ5anVNWlNJWWE5a3Uzc2Vy?=
 =?utf-8?B?QllKVVZQaEFyMHRHSHB2ZXU4YzNxWm1WdUdvVndxZklZQUE1dUlmMGVLS08z?=
 =?utf-8?B?WjN1UlNuME1jZExpUXk2aVBVMFFQRDdtVVNTL1J2dk5JTmxTUmkzOHJwZjd5?=
 =?utf-8?B?eFg5ZC9YNHhqQWpKaEZaY3V5L0xGWVJXbG5MZXNhMHhSSTc2ZnN4Qk4wc2Qv?=
 =?utf-8?B?SndBNkZaMjIwb0JkSmpHV1BRV1lIcnBvQlBNaE56WDdReUF6RmRZZjZJQkFF?=
 =?utf-8?B?d0NoeE9ScndHUGJOU1JwRXFjczBMRUQ4OEFkUklNZi9xZjFIYkd6VFN0NkYy?=
 =?utf-8?B?cndNeVNIQVRpOGREUkZpbjZZVFI0OHNibXB3d2RxTERoYVZCaGo3YmNtT1Az?=
 =?utf-8?B?bG5LMUFVVWU4elN5dFdqaEZyV2pJNitTaTh6UkJYUFhtUWdWREpGRmkwVGZL?=
 =?utf-8?B?UVE0L0F2eWRuNzFvSDh4YUNmNEpFZENrTHZjYmZsazVOV0R6UmpOeDVTak92?=
 =?utf-8?B?UWg5anhGTkt6eXl6bGcvMkxYTFBZa2V6cy9HdlVrRStZMmdXZU9iOUhWVE9F?=
 =?utf-8?B?Ykp0M2lUYkpFUHU3dVZhK2svd0pSUnlBREp2SDJ2V0pZM003MVRTY2dxNWV5?=
 =?utf-8?B?Vk4ybmtLRmtId3V4YTdUTXpYSW9NME5nQmxNN1N2V0lrdWxBNjBCVDBVcGdQ?=
 =?utf-8?B?Y2xPdTFEMjNXK1p1bWQ0Z0pGRjA0L21sUjE3Q1J4MmJPUjJUWEZRYWtWRnlV?=
 =?utf-8?B?Rm1YTVM5U2lncHlrTStXZ3F2R1pCd2JwVEhJT1Y4REh0OCtwaGd6TlZ3SVJC?=
 =?utf-8?B?bzFhbS90NnRnY1JPQnFacHBtMG84UnA1NTNoY1ZvVldZanoxVXgwZkpYRFNY?=
 =?utf-8?B?SDNkN1dxc2xjLy8zdzQ2dlV4cStjWUtxekhFZ3RwK1djSXp0WTlSK05ORzBU?=
 =?utf-8?B?STVtQll1MzlrSUZRaFZkdzlTV3E4Y2U4YUI0andoOU1UdWJyYU5aOGNKbUdo?=
 =?utf-8?B?UTE2MmJZelNNTTExdy9TNWNxOGptZ2lKcTBZcWt6dUl3Y2xBTy9lRUtHT2Qy?=
 =?utf-8?B?Q05XaGZEYk95SG85RFhiMFF4cTN3K28vVWhtN0FIRXdTNExKMkQ1UEdpT0Q1?=
 =?utf-8?B?OFNQRGdlWGRzTFp5VnNGM3RUaUZ1MEJrZ2RzT0xRemUrNGl4LzZaTmZWWFM4?=
 =?utf-8?B?TUxEcnNXMkx5dGZhZVgxVjBVanZ1bXp3cWgxNUNtZGFXTGw4S1UrcXI4NlBK?=
 =?utf-8?B?STRMYU96M0M5elpmT3grQWdGNUlERnROcFdodVNKZmJQRTJuUzZVc3F1YWpY?=
 =?utf-8?B?RXY4ZE9zWWRSVWFXOW5USXpEVEFYRUsySGhvbzlkbytlTnU3ckcrWmFhNlJ3?=
 =?utf-8?B?V3pWRi9XTGVTNG0zMU1nMlM4clpUMW1SQkx1Szl2cXhPSDdlQUFzNWV5UjBq?=
 =?utf-8?B?T2VjQVp5aE5HRXJlWmlJUkIzeTFhbnFzcDA4aFdkYm5ld1BQZWFqSVN1UWdF?=
 =?utf-8?B?anJ3SUhqbHk1cFV5eDJiN3ljaEd2cWExL21iMnh3SHY1dDJJbE05SGpiN25V?=
 =?utf-8?B?d2YwTlBsWW13a2tuWHNDYWUvMVgxblFPR2pVTFRiZ09MbXppY0d2SFNpa1gy?=
 =?utf-8?B?NEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1347669d-c7cc-4d90-c669-08db9886499c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 03:11:13.2370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oUnnrtbHNzuNQM2kzuqFBWK8+LVgJRckeVRZdAMjbqOLfPtS/96DnZaIjXmC/cephiR9F2yhlrxeJ7iA1+R7Cg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6962
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/5/2023 5:43 AM, Paolo Bonzini wrote:
> On 8/4/23 18:02, Sean Christopherson wrote:
>>> Update CPUID(EAX=0DH,ECX=1) when the guest's XSS is modified.
>>> CPUID(EAX=0DH,ECX=1).EBX reports required storage size of
>>> all enabled xstate features in XCR0 | XSS. Guest can allocate
>>> sufficient xsave buffer based on the info.
>>
>> Please wrap changelogs closer to ~75 chars.  I'm pretty sure this isn't the first
>> time I've made this request...
>
> I suspect this is because of the long "word" CPUID(EAX=0DH,ECX=1).EBX. It would make the lengths less homogeneous if lines 1 stayed the same but lines 2-4 became longer.
Yes, more or less, but I need to learn some "techniques" to make the wording looks trimmed and tidy. Thanks!
> Paolo
>