Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH -next] dm: Remove unused declaration dm_get_rq_mapinfo()
To:     Hugo Villeneuve <hugo@hugovil.com>
CC:     <agk@redhat.com>, <snitzer@kernel.org>, <dm-devel@redhat.com>,
        <heinzm@redhat.com>, <linux-kernel@vger.kernel.org>
References: <20230808150301.45196-1-yuehaibing@huawei.com>
 <20230808130333.2207c675d008fa6c808a472f@hugovil.com>
From:   Yue Haibing <yuehaibing@huawei.com>
Message-ID: <2c73f603-4c0b-36d8-df9f-be33db589c69@huawei.com>
Date:   Wed, 9 Aug 2023 11:03:11 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <20230808130333.2207c675d008fa6c808a472f@hugovil.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2023/8/9 1:03, Hugo Villeneuve wrote:
> On Tue, 8 Aug 2023 23:03:01 +0800
> Yue Haibing <yuehaibing@huawei.com> wrote:
> 
> Hi,
> 
>> Commit ae6ad75e5c3c ("dm: remove unused dm_get_rq_mapinfo()")
>> removed the implementation but leave declaration.
> 
> Maybe change to "removed the implementation but not the declaration."

Thanks， will do this in v2.

> 
> Hugo Villeneuve.
> 
> 
>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>> ---
>>  include/linux/device-mapper.h | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h
>> index 69d0435c7ebb..5bc69c6a64e0 100644
>> --- a/include/linux/device-mapper.h
>> +++ b/include/linux/device-mapper.h
>> @@ -502,7 +502,6 @@ int dm_post_suspending(struct dm_target *ti);
>>  int dm_noflush_suspending(struct dm_target *ti);
>>  void dm_accept_partial_bio(struct bio *bio, unsigned int n_sectors);
>>  void dm_submit_bio_remap(struct bio *clone, struct bio *tgt_clone);
>> -union map_info *dm_get_rq_mapinfo(struct request *rq);
>>  
>>  #ifdef CONFIG_BLK_DEV_ZONED
>>  struct dm_report_zones_args {
>> -- 
>> 2.34.1
>>
> 
> .
>