Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <93eb5aa1-4cde-875d-5acc-5d697834b170@intel.com>
Date:   Wed, 9 Aug 2023 11:00:38 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH v5 18/19] KVM:nVMX: Refine error code injection to nested
 VM
Content-Language: en-US
To:     Sean Christopherson <seanjc@google.com>
CC:     <pbonzini@redhat.com>, <peterz@infradead.org>,
        <john.allen@amd.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <rick.p.edgecombe@intel.com>,
        <chao.gao@intel.com>, <binbin.wu@linux.intel.com>
References: <20230803042732.88515-1-weijiang.yang@intel.com>
 <20230803042732.88515-19-weijiang.yang@intel.com>
 <ZM1vvHXCOtbHVX8z@google.com>
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <ZM1vvHXCOtbHVX8z@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXlwUSs4L0ZCZ1BFbXJ5aUJyOUJEYUVTd2tLN0tVYVdYWjlUeEtDUm9zb3dp?=
 =?utf-8?B?SjJ0dXRYUVd5OVBVclpLTkNMRVZjcVBPMTI5SERpNlNuZDd1SDMxcUlHOFlZ?=
 =?utf-8?B?NGwzQmtHUzdiTnJiQjY1cHpMaFYwdFpnSTA3ZWZEQUFQcm5lbGZrbngzVE5C?=
 =?utf-8?B?U1ZORFBzU0o4b2NoYUoxcXlERTlWUjNnVzRqN25DelpicDdiUUF5ZWY2Slhk?=
 =?utf-8?B?OTAxaVZMY0Z6VTk3VDdJb0JzZWpWYk82Q2VnU2RFOHVaMFdWYUlFTmdxYkhG?=
 =?utf-8?B?N3lpSVV6VWRpV0ZVOGxqVWdlZnN1ZzlnYjlrYjdBUTJZWWcxdlU5TXl4b2tZ?=
 =?utf-8?B?amdEU3Q2eC8wWEl2b1luU1BvTFlzZmExSTJkS1d5Vy9XLzlJTlRiS3FKbHp2?=
 =?utf-8?B?Y0NKOFVXR0ZNNnlKbzI5YXZzeVFrb0VIZXljbndqRkh5aE1QM2FJWC8yWTNV?=
 =?utf-8?B?U0pHUkpFQjZYdzAwRFBzQ3NEOW9KTmNLTGNpbTJGTG9OdS9kQWxtNGhyUXUx?=
 =?utf-8?B?Q25tOVp6eVVhMEFzTXk2R0JsTGVWSUpPc1VHaUJBVFRWUkxqcHMvUFEvWWxv?=
 =?utf-8?B?V2l5blVmbm5jejBLTysxOTZhK09EWTFMWnY4Q2lObWcxK09nL09lSkpvWnVE?=
 =?utf-8?B?R0VsSUhMZVFMWlhiYXVNbGZJYnY5NDVNV2dNb0l2cTROaENpWGlxVnBJMWYy?=
 =?utf-8?B?WFI4NHFZN2NRZFQ0b3RlVDUxT0k3ZW9LWnh3ZC8wSWhmWWlEMDFBZFBzWW01?=
 =?utf-8?B?REkya1BaTDlkSTcwam9hcjAyTWpVUnlGR1NZbloyeUV3eG03cTNFa2lBL0N4?=
 =?utf-8?B?RDljcGljT3RBcjZOdEhxR0h3WVBqcE90R3R1cGMxbUluSnMzTldnMDRmTWlj?=
 =?utf-8?B?Nld2cjVUZExHL05oYXJZZFpyVGkzenRvZUpJWjJvaU0vUVEyRmExSzhvd0FU?=
 =?utf-8?B?bCtMNHVBYUhoSUxJdDltSzA2ZVJ6QVNKRU9qa0xYNGs0Y3JKZ0JzbUJvWlRK?=
 =?utf-8?B?QkF1YXNpd2svUmZJbFlVYThVN1RmcmNoaysxZTFOeXhuOXRKdUNZR2JCS1hZ?=
 =?utf-8?B?c0d4R1JEK1pNRGkyQXhBZ1hOMWpDdE1vKzFST3pwVTJpTE90WUxEM29GbzRX?=
 =?utf-8?B?T0Z4NHI3Q1BrUXZ4ZVF6V3VLVGtnZmZDbW9oQmZDZngxZjMyRFd5WUYxZjlJ?=
 =?utf-8?B?TFRpUUdlQWVVU2crSTBuSXcxNEx2T3JJSWlyTzB2Qi9EQXZXREl3QlNHdnVR?=
 =?utf-8?B?UWtvZjBiZkRZeXVUUXh5SkQrMzRBTGg0R3RaTWx4Ti9KNnRpck5YQ1kwWU91?=
 =?utf-8?B?RlJ4S0E1K2o5WTRPVGF5NUdYYzhYTmtHY3ppMjZVU3owSDBONE9zTlN4T2N3?=
 =?utf-8?B?NExnQjgvVE12Nm1uczdudkVtdERmbmlzYmxaMVJhY2k0M3ltTTBsdk4rMHFt?=
 =?utf-8?B?SGdoNVRFS2RSOEc2YjFiUkl4SEtyZXVjRFJpdW5ZSFpDTUo5cVhvWDE5bkpB?=
 =?utf-8?B?Ti9RWVRYeDdZWkF6ZENnay9tb1pQVVRxaVRzcUc2eDZoRGh4b21rcTluZ1NT?=
 =?utf-8?B?eXVtRkdNb1NPRGNmWXc4dG1KTm9nT3hoNXdhOUlJbGJzalUvbkNKZTRCcCtH?=
 =?utf-8?B?WGVjczMybWF5K09vQnNZeWJKMmtNRGdRTjRXRDhtME1MTU9SZ3pEQlg0OXht?=
 =?utf-8?B?TFhXMWdrdk5hMm9tejR4Z09yL2NPbkM2eHpMNGNCOThod2tvcDJxVGFHQjhD?=
 =?utf-8?B?eUFTMDB6TWdlTUo0d1luWWJkTUs4SHYvM0F2RVYwZmJ3cTRnTU5zK0RFbW5y?=
 =?utf-8?B?M1pJTys1RjhZMnZVakJpZjdoOXFjZmN2QTJmZVlzcUtGbitzSkh2RUV3VWlz?=
 =?utf-8?B?OUlzL3ZQaE5BUmZmbzE1OS84a0gzSnltTmJtRElyM3c0K1Zpb3N3UHVzeVlX?=
 =?utf-8?B?RTdycnBSL2x5b1p3UlVBbUVUOWk4c01SbElERDB2b3p4MlpDak9HL1pEV0xh?=
 =?utf-8?B?MEkzZ2VTWE1DVVpZTlhZb1hhKy80M0dZT1FNWkdqWGFKM3dnMmY3U0hVSnU2?=
 =?utf-8?B?QXlBVWM0eENhVFhVeW84cFg1N3FIZ0kvOGlkM1BqTlZHaE5CV2orSUlIWjN0?=
 =?utf-8?B?R1RFOXdjVDdKa3IvR1RvSUx6SnBrRzY5WDNzN1Y2MHVOUG9PSWpmMkxSOEVC?=
 =?utf-8?B?UVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1078ef77-0b7a-47f3-42f2-08db9884d72c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 03:00:51.7381
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ue6pc5FFUCx9oegdiiALPQdcCwFGeJxhcpCL3LJ1/BVHAHMEr9pGgLUuqxvYzm6uuJ+wC7amejhUOS4xbbsEUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7810
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/5/2023 5:38 AM, Sean Christopherson wrote:
> This is not "refinement", this is full on supporting a new nVMX feature.  Please
> phrase the shortlog accordingly, e.g. something like this (it's not very good,
> but it's a start).
>
>    KVM: nVMX: Add support for exposing "No PM H/W error code checks" to L1
>
> Regarding shortlog, please update all of them in this series to put a space after
> the colon, i.e. "KVM: VMX:" and "KVM: x86:", not "KVM:x86:".
OK, will update this part.
>>   static void nested_vmx_setup_cr_fixed(struct nested_vmx_msrs *msrs)
>> diff --git a/arch/x86/kvm/vmx/nested.h b/arch/x86/kvm/vmx/nested.h
>> index 96952263b029..1884628294e4 100644
>> --- a/arch/x86/kvm/vmx/nested.h
>> +++ b/arch/x86/kvm/vmx/nested.h
>> @@ -284,6 +284,13 @@ static inline bool nested_cr4_valid(struct kvm_vcpu *vcpu, unsigned long val)
>>   	       __kvm_is_valid_cr4(vcpu, val);
>>   }
>>   
>> +static inline bool nested_cpu_has_no_hw_errcode(struct kvm_vcpu *vcpu)
>> +{
>> +	struct vcpu_vmx *vmx = to_vmx(vcpu);
>> +
>> +	return vmx->nested.msrs.basic & VMX_BASIC_NO_HW_ERROR_CODE;
> The "CC" part of my suggestion is critical to this being sane.  As is, this reads
> "nested CPU has no hardware error code", which is not even remotely close to the
> truth.
Understood, I was not aware of the essence of "CC".
> static inline bool nested_cpu_has_no_hw_errcode_cc(struct kvm_vcpu *vcpu)
> {
> 	return to_vmx(vcpu)->nested.msrs.basic & VMX_BASIC_NO_HW_ERROR_CODE_CC;
> }
>
> [*] https://lore.kernel.org/all/ZJ7vyBw1nbTBOfuf@google.com