Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6ba8ab92-7771-d077-32ba-40896e06b035@intel.com>
Date:   Wed, 9 Aug 2023 11:14:20 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH v5 08/19] KVM:x86: Report KVM supported CET MSRs as
 to-be-saved
Content-Language: en-US
To:     Paolo Bonzini <pbonzini@redhat.com>
CC:     <rick.p.edgecombe@intel.com>, <chao.gao@intel.com>,
        <binbin.wu@linux.intel.com>, <seanjc@google.com>,
        <peterz@infradead.org>, <john.allen@amd.com>,
        <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230803042732.88515-1-weijiang.yang@intel.com>
 <20230803042732.88515-9-weijiang.yang@intel.com>
 <6d0b0da3-5df2-46f4-d6ba-75ae6a187483@redhat.com>
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <6d0b0da3-5df2-46f4-d6ba-75ae6a187483@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dS9mbTcyRjZ4Q0oyUlhFWUU5VTVjdmVaOWlubmc5YWprUVh1RExOTzZiakVY?=
 =?utf-8?B?T2tZeGRXZ2U0SUNvS28zQlVtK2hCcndZbnFrdHE4UXRzL3RiNWxSOXo3T2x6?=
 =?utf-8?B?eEMyM3BaYnB1TTkyYWQ2eTF0aTRNSjVZbzRqeWtLSW0va2gwVHFmN1NZbmRy?=
 =?utf-8?B?VnN2WHZ3TnFvQU5rNGROV3lJL1dnR212Ti9yTEMyOXMwcHBDQUtFVlV0SXFt?=
 =?utf-8?B?T1ZtTDljZDVNdVNZNDVQTjdhajQ3ZHZQRVB3UDBnN0NLK2lRRHRhZlRIanFR?=
 =?utf-8?B?OHpNdjhGWW9CeVRPRTRZMGgzQTVqKy9pZnJtOE5UNXpjWnJZV1lBc01tYjRS?=
 =?utf-8?B?MzlEd3UxZm8zamIwVnZWcitQRzQyeklZNGZVUUpLU25BSUNuRlRwOEwzWDRl?=
 =?utf-8?B?eHhnSE5rYUg3M1ZlamF6emNTUmNGQkxEUFZValJkQUNrNFowMkJZVmgwcUF1?=
 =?utf-8?B?NFFpMkFWUThYWjlxKzNPNEZuUVZyODd4SnVZVTJUMXBzY0tEamJkdWFSMXBG?=
 =?utf-8?B?V0hYZVJUTUQwalFoZTJ2YlJIOVZHdS9hVGpLd1p3K2JIa2l5UXRKRG1nZ1p0?=
 =?utf-8?B?Qm4yNUVwZk9jSmVyaU1zTUd5TnozajI3WlhxODJVQUJPWVBOZEo1cDMxL09o?=
 =?utf-8?B?ZTdEc3EyNktYcC9kM2lxRkdRcDAwcTRnaWd2SGt3QUgzQVgwdTkya3RTYkp0?=
 =?utf-8?B?TFJwamVZeDM4UmdtYW1PS0FuUTBISm01Q0EvQnNaMUt0RjNjNlNrekExZEsy?=
 =?utf-8?B?aVFua3dDMzg4VlpMSjVoZXVESDJHZGcrbWlndFo3UTAxWjBVY2RMNHp5Tmto?=
 =?utf-8?B?b3MyMVRIWjB4Z1FwanErQk9pVU9zQVh3SlhCODQxMC9WaElkLyt0bUExQllV?=
 =?utf-8?B?UUU5TExvbDJaenV6TjhkQ1NnM1RTQldkeGpOMjRCeWZvQ2lsQ0RjSlJZVnNv?=
 =?utf-8?B?TE5ldTZYcVYwSm9MUlJRbUpEMjhTNjZoN0J1S0wzcmx1RlhTT1VNbkRzQSs1?=
 =?utf-8?B?SzRFOTQ5VVM1aVRsVmF4TVM0K3dvSGhnc3ZHMUhGcTJXMXgrZ0w4U0c5TkFv?=
 =?utf-8?B?YTliK2p3UVlac2JBUDd6d1Y4ajBiVGU3VmF2RFg3MnlQbHFyZUVmclNzZ0pr?=
 =?utf-8?B?OTNhQjlFY0htNWVLT0s2RHZHd2U0WTF2ZkdmbFk2RnhMOUtGUWdkMGlwRnlm?=
 =?utf-8?B?eXVvT05DQ2ZtalIwWmsxcldEN3pPOTdCamlPOGsvRXVxVzBsMWU4aFFlak1k?=
 =?utf-8?B?SEYwZGNIQlJyWDQyeFhEVlN3Q3RlQWRTT2QvcTVmdC9DOEFxalhRRDMwQlk2?=
 =?utf-8?B?UjJvY2ZJMzJ2NU9nMWs5ZXZGdW5GNWtFL0t0NkZSQTdWaTNraWkxaW1FYVpp?=
 =?utf-8?B?NFJITWRZaTlieXRiMkg0aEdldnp4T1E2aEhJN1NUNWY0N2ZCNDhWWnBxWWI1?=
 =?utf-8?B?SFk4NjJNVTVvdE9wMUZ2bGtVRURRWW5qUjd3aW1CVnFqWjN5NFdKL2l6RUNj?=
 =?utf-8?B?S3BrTkNwQ2NsMm1xKzlWS3FNUTZOVTdadnVacGJnRVhmK2ZBU1RyeTZZL3hI?=
 =?utf-8?B?eEZBWmhLdWR2Vm9jSGZzTGpONDlTS3FobElYQ2JsT1lRRkRwckdPa3kzbmNQ?=
 =?utf-8?B?UkZLNnFjRzlJOGVSNkJobEpIU2xzVjJhYjVOaHRjOG5kcjFQcEdVdGpJdDk5?=
 =?utf-8?B?Njk3Q09kSGhodGRoVFRoNm5UWGtWc09DVUFtczIvL0tqOTFYTDN0ZmQ1RUlH?=
 =?utf-8?B?SjNXcEVpK3NqYXkrZDZEU0JXOWpGK3dveGlYa1MvK3lUKy9TVExpbHU0VEwr?=
 =?utf-8?B?N1U3Y3JDYUQzdkFtTHBvT05pWDBnZ1FFMGpRT2oyR0NROFdoaGh5eVk1Vk10?=
 =?utf-8?B?ZVQ0cjFFdndCby9PdHh3MXBxc3J6dFdlcEE4MHVMSlp5ZDNlbnBzV29TY1dJ?=
 =?utf-8?B?Z0dYdG9IcWhrUGE4U1hpT04wVVVUUmJnZG1pWlVGZnRlcllXUkpSRVowVTR6?=
 =?utf-8?B?ZHlJMzlFRjFueWZ4TVQ2MzE1UlI3UlFRMExSQ0hhQlB4MWlGMmFna2Z5bzlJ?=
 =?utf-8?B?RFcyT0ltdmVaSkpKNi9qNnB6eGNaVm15ODYyRUxtSG5SQ2cvbkVpU0Q2WENK?=
 =?utf-8?B?VVlMZzZzYitCZmNscmpjOEFXOTBZZGJsemRqazdKVE1YS1A1WlhDMXM5d1M1?=
 =?utf-8?B?WXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 02ccc645-9ad3-4fad-794b-08db9886c0b2
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 03:14:33.1896
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i16bXYTIrmr9YQ2aQoBr+EVippcm1JVQw2oDIJqmJ5URVsobYoiIfaJGFVwiv22sXNXk7BJ0/FJEcxc3iS6ZSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8605
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/5/2023 5:47 AM, Paolo Bonzini wrote:
> On 8/3/23 06:27, Yang Weijiang wrote:
>> Add all CET MSRs including the synthesized GUEST_SSP to report list.
>> PL{0,1,2}_SSP are independent to host XSAVE management with later
>> patches. MSR_IA32_U_CET and MSR_IA32_PL3_SSP are XSAVE-managed on
>> host side. MSR_IA32_S_CET/MSR_IA32_INT_SSP_TAB/MSR_KVM_GUEST_SSP
>> are not XSAVE-managed.
>
> MSR_KVM_GUEST_SSP -> MSR_KVM_SSP
>
> Also please add a comment,
>
> /*
>  * SSP can only be read via RDSSP; writing even requires
>  * destructive and potentially faulting operations such as
>  * SAVEPREVSSP/RSTORSSP or SETSSBSY/CLRSSBSY.  Let the host
>  * use a pseudo-MSR that is just a wrapper for the GUEST_SSP
>  * field of the VMCS.
>  */
>
OK,  will take it, thanks!
> Paolo
>